Mind Blast [GUI][MUI]

[Moderator]

Mind Blast | Reviewed by Maker | 30th Jun 2013

APPROVED

The spell is leakless and MUI The spell damages neural units No need to clear a group is you destroy it Don't get the current ability level in the looping trigger. Use the level at time of casting The importing instructions could say that any reference to the ability need to be set correctly

[tr]

Old reviews Can actually heal the target if ability level is > 4. Will not work if ability level is 4, division by 0. Check the damage equation. Do ((Picked unit) is dead) Not equal to (!=) True in the filter functiion. Hmm: Set MB_Caster[MB_TempKey] = No unit Unit Group - Remove MB_Caster[MB_TempKey] from MB_SpellGroup Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions Multiple ConditionsAnd - All (Conditions) are true Conditions (Percentage mana of (Picked unit)) Greater than (>) 1.00 (Percentage mana of MB_Caster[MB_TempKey]) Less than (<) 100.00 -> Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Percentage mana of (Picked unit)) Greater than (>) 1.00 (Percentage mana of MB_Caster[MB_TempKey]) Less than (<) 100.00 Add importing instructions into the map. Why exclude int bonus for damage? You should filter out dead units when adding units to Damage Group. Otherwise the spell looks ok triggering-wise. Pharaoh_: Review on request (updated) • In your loop trigger, check if the picked unit is magic immune to prevent further damage (and checks). • In your loop trigger, check the ability level of the caster, so that, in case he levels this ability up, while damaging the units, the new bonus will be applied instead (since it's a matter of personal taste, you might want to use a global boolean that checks if the user would like this change in the trigger). • I suggest improving it and further upgrading it to support stacks. This way, if a unit is struck twice by this spell, it should be dealt the additional damage, depending on the number of sources. Right now, it looks quite flat.

 

[Maker]

You need to rethink the logic with which units are added to the group in the cast trigger. Also rather than setting life, make the caster deal damage.

 

[Bribe]

Also, this indexing is really simple and potentially horrendous. I don't know why this
style is still being promoted.

The indexing works like this:

Unit casts spell; MaxSize is now 1,
Unit casts spell; MaxSize is now 2,
The first spell finishes, so when the loop starts it iterates over the empty first spell and
then gets to 2.

Now, if the spell overlapped several times, then you are looping over even more
finished spells until you can get to the working ones.

So here's the worst kick with the indexing - if the spells are always being cast, always
overlapping each other, it's doomed. You'll be looping over dozens, then hundreds then
thousands of instances waiting to get to the active ones, then you'll hit index 8191 and
your "MUI" system will completely and utterly fail.

Therefore, you want to use one of the following to make sure this does NOT happen:

Hanky's Dynamic Indexing: http://www.hiveworkshop.com/forums/spells-569/gui-dynamic-indexing-template-144325/

Hashtables: http://www.hiveworkshop.com/forums/...9/complete-beginners-guide-hashtables-197381/

Or Unit Indexer: http://www.hiveworkshop.com/forums/spells-569/gui-unit-indexer-1-2-0-2-a-197329/

 

[Jay the Editor]

13oot-Me,
[1] It's more like burning the mana rather than draining the mana
[2] The loop will turn on everytime when the spell is cast when there are other still active
[3] Ineffective MUI system as Bribe said.

Bribe, I guess it's easier for new MUI learner though. :3

 

[Bribe]

Bribe, I guess it's easier for new MUI learner though. :3

Unit Indexer would be the easiest for a new learner IMO. I don't care if he uses hashtables
or hanky's indexing either, but this old system should only be for personal use and not for
public resources due to its issues.

 

[EvilCrizpy]

Unless anyone has not covered this not to sure , My bad

But when you use the indexing event;
Dont you normally use ;

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Index1 Equal to 0
  • Then - Actions
    • Trigger - Turn on <gen>
  • Else - Actions

Instead of having it later on in the trigger;
This allows it to detect if any instances of the spell are running?
Then in the second trigger, as i see you do, it turns if off if no one is using the spell;
I think thats right?

Evilcrizpy

 

[13oot-Me]

I am trying to change the indexing to Hanky's dynamic indexing, but running into a couple problems. Here is my progress.

 

[EvilCrizpy]

I am trying to change the indexing to Hanky's dynamic indexing, but running into a couple problems. Here is my progress.

Ahhh okay;
Possibly for new users like your self look into bribes Unit Indexer;
Unit Indexer
and then look to my spell;
Cloud spiral
For ideas on how to use the Unit indexer into creating spells;
Would be a greater idea, till you understand the use of recycling.

Evilcrizpy

 

[13oot-Me]

It's more like burning the mana rather than draining the mana. Ineffective MUI system as Bribe said.

I made it so that the mana is drained from the targeted units and added to the caster so it's more like drain now. Also, I changed the indexing by using bribes unit indexer.

Spell now runs and works smoothly

 

[EvilCrizpy]

I made it so that the mana is drained from the targeted units and added to the caster so it's more like drain now. Also, I changed the indexing by using bribes unit indexer.

Spell now runs and works smoothly

Shall test it once i get chance to download it;
But from the triggers it looks abit better.
Could do with some polishing off the triggers
Rating 3.5/5
Evilcrizpy

Edit :

Scrap that, just add remove MB_Caster from spell group,
then check if it is empty, and if true destroy spell group.

 

[13oot-Me]

@EvilCrizpy, ah ok that makes sense, and less variables to work with Thanks for the feedback by the way!

Made the changes below.

• Unit Group - Remove MB_Caster[MB_TempKey] from MB_DamageGroup[MB_TempKey]
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (MB_SpellGroup is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

 

[EvilCrizpy]

@EvilCrizpy, ah ok that makes sense, and less variables to work with Thanks for the feedback by the way!

Made the changes below.

• Unit Group - Remove MB_Caster[MB_TempKey] from MB_DamageGroup[MB_TempKey]
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (MB_SpellGroup is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

No no from the MB_SpellGroup,
and do that trigger outside of the pick all units in MB_SpellGroup
Also i was wrong my bad
dont turn off the trigger after checking just, destroy MB_SpellGroup if it is empty, still using the index to turn off trigger,
But i guessyou can do that way
Less triggers

 

[13oot-Me]

Oops, I thought I did use MB_SpellGroup. So I should put the trigger below on the top of the actions?

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (MB_SpellGroup is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

 

[EvilCrizpy]

Spell looks alot better now,
runs smoothly, Idea is quite nice;
Could be useful for hero maps such as AOS.
Improving my rating to 4/5

 

[Jay the Editor]

Bribe, nope. When I start to learn MUI, I found this old indexing system is easier to understand the concept of how a spell trigger run in MUI. For a new learner, they probably find it harder in understanding custom scripts in your Unit Indexer. :3 Anyway, at least the editor of this spell (Mind Blast) starts to learn Hanky's dynamic indexing system. I guess it's all solve :3

 

[13oot-Me]

@Jay the Editor, actually I ended up using Bribes Unit Indexer after all. But yes, it was pretty easy to understand the old indexing system.

 

[EvilCrizpy]

Well the spell is looking alot bettter now;
Bribes Unit Indexer, can be useful if you know how to use it and i would recommend it for new users, cause it saves them with actual indexing;

However,
Obviously this can change for some people, people find Indexing easier than Bribes Unit Indexer.

 

[Jay the Editor]

That's good :3 Bribe's Unit Indexer is great~

 

[EvilCrizpy]

It does do the job;
And the more people use it,
The better, will give a different amount of variety between styles of triggered systems/spells.

 

[13oot-Me]

Updated the spell!

-Added importing instructions into the map.
-Now includes intelligence bonus to the damage.
-Filters out dead units and does not add them to the unit group.
-Made a better test map.

 

[akheny]

The idea is good

 

[deathismyfriend]

anything u use twice or more should be stored into a variable and the variable should be used. example: u use picked unit a lot. store it into a tempUnit variable.

i also dont like all the groups u create and destroy by doing it this way. thats more of an opinion. this can be done without all the unit groups and just use an array indexed method.
u also wouldnt need bribes indexer if u dont use the groups.

 

[mckill2009]

- No need for MB_Caster[MB_TempKey] = No unit, and alike
- No need for Remove MB_Caster[MB_TempKey] from MB_SpellGroup during cast time
- Greater than or equal to >>> Greater than
- Save the ability level during cast time not in the loop
- The pick magic immune and unit is dead should be filtered at out at casting time or check if magic immune is false and unit is alive then do the damage
- Effects should be configurables

 

[deathismyfriend]

setting variables that may not be used for a while to null is a good idea IMO. if its going to be used again soon then theres no point but its better to null IMO

 

[mckill2009]

But it will slow the code and less efficient, one who's not using the spell yet is nulled when it's already nulled...

 

[deathismyfriend]

its really the ops choice for that one lol. it doesnt slow it enough to matter unless they null it at the wrong times.

 

[Dion King]

13oot-Me I have found a bug here. It is when you cast Mind Blast spell on any unit that has a spell of Spiked Carapace or Thorns Aura, it will cause you do deal the damage equal to the target unit that have been damaged.