Lightning Dash v0.7

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Lightning Dash v0.7 | Reviewed by Maker | 1st November 2013 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] You added some originality by having the hero charge twice, and charge spells are cool... ...but there have been many charge spells done over the years so it can be difficult to make an exciting rendition of the theme Triggers[/COLOR]] Good configuration settings The caster can have the collision turned off even after the spell is over You have a location leak in the looping trigger You can leak a unit group in the looping trigger It looks like you are forgetting to set a dummy unit to a variable in the looping trigger You might want to filter out flying units I recommend adding (optional) pathing detection so the hero doesn't go over/through cliffs or buildings Use variables for the dummy unit type and dummy ability Objects[/COLOR]] No unnecessary objects The learn tooltip is the same as the learned tooltip Effects[/COLOR]] The effetcs are ok The dummy trail could fade out The dash could make a sound Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS NEEDS FIX

 

[T. D. W.]

0.1.b Review

Personal Words

Review

Suggestions

Rating

Judgement

Note

Review Claimed by Chobibo, and this is what would've happened anyway since it's GUI

• Add Comments (explanations) in LD Config to what variables do
• Remove the Cleaning Trigger, it can be replaced by seting the death type of the unit to:
  
• Remove the Shadow of the Lightning Dash Dummy and change his death type to :
  

• Custom script: call RemoveLocation(udg_TempPoint3) [*]

  this should be at the end of the ELSE block of this condition:

  LD_RangeCounter[LD_AIndex] Greater than or equal to LD_Range[LD_AIndex] [*]

• You should make the Animation of the caster which is played at cast configurable via a variable
• LD_Speed should be an array

I think that's all, it's a cool spell, it's somehow original since you combined the trail to it

You may want to make the Dash STOP or Change TARGET if the target is Dead (before it his him)

If You want me to review an Update of This Spell, Please Notifiy me this by VM or PM

 

[goldenflame]

edit: fix minor problems as Suggestions and Reviews of Jad said.

however i don't think LD_Speed must be an array?

 

[T. D. W.]

All configurations except effects and attachments should be arrays, since the spell has 3 levels, each configuration of the spell should be an array to support each level

As for an example:
If i wanted to use this spell in my map, and i want it to damage the same amount for all levels, same amount of targets, but i want to each level has a greater dash speed...
And referring to the spell name "dash" tje first thing that should be flawlessly configurable is speed :3

 

[goldenflame]

Aww i guess we had different outlook on dash ok ill make it an array.

 

[T. D. W.]

Well, it's wasn't subjective by me to tell you this, you can see all spells' configurations here are all arrays :3

 

[goldenflame]

Hmm i should have not seen it, but is it becoming more spoonfeeding if all the things are configurable? anyways im changing it right now.

 

[T. D. W.]

Eh, those things are related to the rules, and if i didn't tell you then another user will, and if not another user, than the moderator will slash throughout for sure

 

[goldenflame]

Oh sorry i must have over looked it from the rules. Sorry

edit: Fix again minor issues

 

[T. D. W.]

No prolem

 

[FUJI]

The configuration is lacking.

 

[goldenflame]

What do i need to add??

 

[FUJI]

The configuration trigger must be documented, you must add the vertex coloring of the dummy and their transparency, ( maybe the user wants to change that so he will not touch nor harm the code ), and the animation of the caster.

 

[Rheiko]

Lightning Dash v0.2 Review By Rheiko Documentation Triggers Suggestions Contact Me Documentation Next time remember to update your description when you update the spell No importing instructions Triggers Pros A nice spell, dashing with trails are a good combination The Triggers are Readable and Clean leakless MUI Variables are descriptive Simple but useful Cons None Suggestions Check if the target is dead and cancel the spell Use check walkability by PurgeandFire Make dummy's color configurable Make a decent importing instructions Update your triggers when you update your spell Contact Me If you have a question concerning this review, post it here or send me a PM / VM 3/5 - Vote For Approval

 

[T. D. W.]

Check walkability is not nessesary, If and only If he doesn't make the spell stop when the target is dead, since he will go to the target's position, so no need to check walkability

 

[Rheiko]

it's not but it's a suggestion, it's up to him

 

[goldenflame]

Thanks for remindin @Jad i was shocked when @Rheiko suggested that.

 

[T. D. W.]

@rheiko
Suggestion? yes!
Useless? Totally!

@godenflame
You're welcome

 

[Rheiko]

why it is useless?

 

[T. D. W.]

I explained it before

 

[goldenflame]

Anyways i have made heavy change feel free to try again and @Jad thanks for the knockback.

 

[Rheiko]

if he move towards his target, it'll slide through pathing blockers.. unless he intended to do that

your first explanation is unclear

 

[goldenflame]

Hmm I turned off the collision will it still slide through the pathing blockers?

Why is this still not yet approved?

 

[FUJI]

Lightning Dash v0.4
This spell had been reviewed by jakeZinc.

The triggering looks good and clean. But simply notice that you misplaced removing location of TempPoint3, yo must remove it where you'd set it. You did not remove the dummy here:

• Unit - Create 1 Lightning Dash Dummy for LD_CastOwner[LD_AIndex] at TempPoint facing Default building facing degrees

. This dummy unit has a shadows and I consider that this is the caster of the thunder clap dummy.

The documentation is well good.

The configuration is lacking, you must add the Ability, Dummy Configuration so that it will not make the users to touch the trigger core

It is swag and beautiful.

The death art special of the dummy, the shadow of the dummy.

There's no importing instruction

The special effects are fantastic and the trail is awesome!

Useful can be use in chasing enemies and it is a dash spell that can jumps in every target.

Do not add shadows to the dummy, make the model of the thunder clap caster to be none.mdl. Set the death art special of the mountain king dummy to none. Do not add an ability to the dummy in the object editor, you must add it via triggers, so that it will not have an errors in the spell. Set the blend time of the thunder clap caster to 0.00. Set the movement type of the dummy to fly and set their collision size to 0.00. The dummy has a wide vision maybe make it 0. Use locust unit as a dummy because it is much faster than picking custom units that does not have a locust ability. The thunder clap caster must has a death type - Can't raise and does not decay. Must have at least two casters in the map. Make the max range, wait, and dummytime to be array configurability per level.

I think the tooltip is nice and it is support every level of the spell

Rejected: 1-10
Unacceptable : 11-30
Lacking : 31-49
Useful : 50-69
Recommended : 70-90
Highly Recommended : 91-100
Director Cut : 101-105

1) Triggering - 15/20
2) Documentation - 7/10
3) Importing Instruction - 0/10
4) Special Effects - 15/15
5) Usefulness - 15/20
6) Tooltip - 8/10
7) Configuration - 5/10

Total Score - 65/105
jakeZinc Rating - 3/5
Status - Useful and Needs Fix

 

[Rheiko]

@goldenflame
you have to wait for moderator to approve it, be patient
and it still slide through pathing blockers

Edit: just notice, in the description it's v0.6, in the title it's v0.5 D:

 

[goldenflame]

Oh is it? ill change it.

Changes made feel free to try again.

 

[Lender]

you should make attack and damage type customizable too.

 

[goldenflame]

Changed that also @Lender feel free to try again.

 

[FUJI]

Lightning Dash v0.7
This spell had been quick reviewed changes by jakeZinc.

• Unit - Cause LD_Cast[LD_AIndex] to damage LD_TargetUnit[LD_AIndex], dealing LD_Damage[LD_Level[LD_AIndex]] damage of attack type LD_AttackType and damage type LD_DamageType
  • Unit - Create 1 Lightning Dash Dummy for LD_CastOwner[LD_AIndex] at TempPoint facing Default building facing degrees
  • Unit - Add Lightning Dash (Thunder Clap) to LD_DummyTC[LD_AIndex]
  • Unit - Set level of Lightning Dash (Thunder Clap) for LD_DummyTC[LD_AIndex] to LD_Level[LD_AIndex]
  • Set LD_DummyTC[LD_AIndex] = (Last created unit)
  • Unit - Add a LD_WaitAttack[LD_AIndex] second Generic expiration timer to LD_DummyTC[LD_AIndex]
  • Unit - Turn collision for LD_DummyDash[LD_AIndex] Off
  • Unit - Set level of Lightning Dash (Thunder Clap) for LD_DummyTC[LD_AIndex] to LD_Level[LD_AIndex]
  • Unit - Order LD_DummyTC[LD_AIndex] to Human Mountain King - Thunder Clap

You misplaced setting the unit's dummy variable, this will not work.

• Unit Group - Pick every unit in TempGroup2 and do (Actions)
  • Loop - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
  • ((Picked unit) is A ground unit) Equal to LD_GroundUnit

Seems that you use it many times just filtering units then make it variable or store the picked unit to a variable to maintain efficiency.

• Set LD_KB_Angle[LD_AIndex] = (Angle from TempPoint to (Position of (Picked unit)))

This is leaking a point and it must be removed, store the Position of PickedUnit into a variable then remove it by using RemoveLocation ( udg_pointlocation ).

• Set TempGroup2 = (Units within LD_AOE[LD_Level[LD_AIndex]] of TempPoint matching (((Matching unit) is alive) Equal to LD_Alive))

you don't need a Matching Unit is Alive, you must filter it like you does in other filters.

• Set LD_Level[LD_MaxIndex] = (Level of Lightning Dash for LD_Cast[LD_MaxIndex])

Use your ability variable,

• Set LD_Speed2[LD_MaxIndex] = LD_Speed[LD_Level[LD_MaxIndex]]

You don't need this, use your variable.

• Set LD_RangeCounter[LD_AIndex] = LD_RangeCounter[LD_MaxIndex]
• Set LD_RangeCounter[LD_AIndex] = LD_RangeCounter[LD_MaxIndex]

You does a doubled deindexing in LD_RangeCounter.

• Set LD_SpecialEffect[LD_AIndex] = LD_SpecialEffect[LD_MaxIndex]

Your deallocating the de-affected in allocation in execution :///.

The documentation is well good.

Changes made. The acceleration speed must supporting levels and it must be configurable but just warned them that turning it in positive values will not make the unit Z's offset.

It is swag and beautiful.

None.

The importing instruction is nice.

The special effects are fantastic and the trail is awesome!

Useful can be use in chasing enemies and it is a dash spell that can jumps in every target.

Changes made but

• Set LD_CastOwner[LD_MaxIndex] = (Owner of LD_Cast[LD_MaxIndex])

you can use TriggerPlayer() than this always in the execution.

• Special Effect - Create a special effect at TempPoint using LD_FloorEffect
• Special Effect - Destroy (Last created special effect)

You can merge this into 1 line.

• Set LD_DummyDash[LD_AIndex] = (Last created unit)

This is not needed. The caster still moves order when the speed is low, better to set a unit's propwindow.

• (Number of units in TempGroup) Greater than 0

You can use an integer counter for this group enumerations.

• Set LD_Speed[1] = (LD_MaxRange[1] x 0.04)
• Set LD_Speed[2] = (LD_MaxRange[2] x 0.04)
• Set LD_Speed[3] = (LD_MaxRange[3] x 0.04)

Must be configurability in how far the unit goes to a distance per second in the speed value.

• -------- The space in which the dummy trail will spawn. --------
• Set LD_DummyWidth = 15.00

Can be supported every level.

• -------- Time before dashing again. --------
• Set LD_Wait = 0.20

This is must be supported every level.

• LD_MaxIndex Greater than or equal to 1

YOu can use Equal to.

I think the tooltip is nice and it is supporting every level of the spell

Rejected: 1-10
Unacceptable : 11-30
Lacking : 31-49
Useful : 50-69
Recommended : 70-90
Highly Recommended : 91-100
Director Cut : 101-105

1) Triggering - 4/20
2) Documentation - 8/10
3) Importing Instruction - 8/10
4) Special Effects - 15/15
5) Usefulness - 15/20
6) Tooltip - 8/10
7) Configuration - 5/10

Total Score - 63/105
jakeZinc Rating - 1.5/5
Status - Useful and due to the trigger code error and inefficiency Needs Fix

If you fix those then the rating will be higher

 

[T. D. W.]

Good review

Just a problem:

jakeZinc Rating - 1.5/5

it's 3/5 exactly not 1.5

 

[FUJI]

^ It's from my rating , the rating is not depend on the total score =), but the rating will be higher if he fix those errors.

 

[goldenflame]

ill fix those later when im not lazy anymore HAHA