Dash

[KILLCIDE]

As I said for your other submissions, please add the code to the description.

I would also appreciate it if you stop uploading more submissions without fixing the last 10 that needs fixed.

 

[Lobster_1234]

the description is in the code, what else to add unnecessary lines?

 

[KILLCIDE]

You have have misunderstood me. I asked for you to post the code in the description, not the description in the code.

 

[Tank-Commander]

The same issues I listed in your other named submission Omnislash
apart from the obvious ones that don't apply though I make special note for these further notes:
- This has a configuration, but it's lacking - it should also contain such things as weapontypes/damagetypes/attachmentpoint
- Your group filtering and usage is inefficient we have tutorials on the site on how to do them more efficiently (avoids ForGroup)

Please update your existing submissions before uploading more, it avoids us reviewers from repeating ourselves and helps both reviewers and you when you don't have to fix the same problems in more than one resource

 

[Lobster_1234]

Tank-Commander:
did you mean this type of group ?
call GroupEnumUnitsInRange(RushGroup, x, y, 200, null)
loop
set u = FirstOfGroup(RushGroup)
exitwhen u == null
if not IsUnitInGroup(u, g) and UnitCheck(a, u) then

call UnitDamageTarget(a,u,75.00,false,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_MAGIC,null)
endif
call GroupAddUnit(g, u)
endif
call GroupRemoveUnit(RushGroup, u)
endloop
endif

 

[Tank-Commander]

that style of filtering yes (though notable there is a few too many "endif" statements in what you've written there) obviously the constants should also be changed into configurable variables but yes that is what I meant

 

[Lobster_1234]

Tank-Commander:
Thank you , and with groups boolexpr
leaks?
?, and which group is more reliable ? )

 

[KILLCIDE]

Moved to Simple / Substandard because the author made it clear he has no intentions of updating.