GUI SpellEvent v2.1.0.0

[Moderator]

Everyone should use this for their GUI spells.

 

[gorillabull]

i dont get it

 

[Arhowk]

Neither do I. What does this do besides storing ability being cast into a global

 

[Magtheridon96]

If you assign "A unit starts the effects of an ability" to 400 triggers, you're creating 400 * 16 = 6400 spell effect events, and whenever a unit casts a spell, the conditions of all these 400 triggers will be evaluated (400 Trigger Evaluations :O)

With this, there will always be only 1 trigger evaluation/trigger execution per spell cast and only 16 spell effect events!

That's why this increases performance and keeps your FPS pretty high whenever a unit casts a spell!

Spell-spamming should never cause as much lag as it did ever again

 

[Deaod]

You forgot to mention that with this, there can only ever be one trigger responding to a particular spells effect. You cant have two triggers responding to the same spell.
You can of course argue that having two triggers respond to the same spell is bad practice and id agree. But you didnt mention this limitation.

Also, the concept you follow originated in 2009 at thehelper.net and wc3c.net.

 

[Magtheridon96]

I acknowledged that, but I can't come up with any good reasons as to why someone would want two triggers to run when you cast 1 spell :/

I will update the description with a disclaimer and solution to the problem.

Also, the concept you follow originated in 2009 at thehelper.net and wc3c.net.

Yeah, I know the idea isn't new :3

 

[Kazeon]

do you attach a spell for the example? I don't know anything to do with this (I haven't try this out yet).. :/

 

[Magtheridon96]

All you need to do is remove the "A unit starts the effects of a spell" event from your spell trigger, and register your spell to the system like this:

Trig

• Set SpellEventAbility = MyAbility
• Set SpellEventTrigger = MyTrigger
• Trigger - Run GUI SpellEvent (ignoring conditions)

And guess what, you don't even need to add conditions to check what the ability being cast is

edit
Updated.
Now has easier implementation.
The SpellEventAbility and SpellEventTrigger variables weren't auto-created before.

 

[Jay the Editor]

I'm still not sure how to implement it. How if I want to register more than 1 spell?
Set it up right after I set up the first one?

• Set SpellEventAbility = MyAbility
• Set SpellEventTrigger = MyTrigger
• Trigger - Run GUI SpellEvent (ignoring conditions)
• Set SpellEventAbility = MyAbility2
• Set SpellEventTrigger = MyTrigger2
• Trigger - Run GUI SpellEvent (ignoring conditions)

EDIT: Ohh you updated it. I got it now. Thanks. Epic system

 

[Magtheridon96]

I'm glad I cleared everything up :3
If there's anything else that seems unclear, be sure to point that out

 

[maddeem]

This is mighty useful if you want to efficientize your map ;p
Very good work.

 

[Arhowk]

Makes sense.

The only problem i have with it is, how would i get target of ability / unit target of ability?

 

[Magtheridon96]

You'd do it the same way you did before :>

 

[shadowvzs]

this faster than useing special unit event?

i mean compared with this

for a=1 to 12
if player(a-1) is playing and player(a-1) is user then
add event udg_hero[a] cast spell
endif
endloop

another side i am glad coz i waited for this, for non vjass version
(i think here also cant use triggerspeel right?)

 

[Magtheridon96]

I'm not going to filter out players who aren't users or aren't playing because some people could use those players for AIs and stuff

Everything that could've been done before, could be done here. (Including TriggerSleepAction)

 

[shadowvzs]

I'm not going to filter out players who aren't users or aren't playing because some people could use those players for AIs and stuff

Everything that could've been done before, could be done here. (Including TriggerSleepAction)

ok ok but if we talk theoritical then useing specific unit events then it is faster for rpgs where only heroes can get that abilities?

another question it's use ability start effect right? so not begins casting an ability,right?

i asked the triggersleep thing coz once i checked last timer RegisterPlayerUnitEvent then there was problem with wait, no? i thought this work same way jass converted to jass from vjass

 

[Bribe]

No, this doesn't have the same problem with waits, because he executes the trigger instead of evaluating it.

 

[Magtheridon96]

i asked the triggersleep thing coz once i checked last timer RegisterPlayerUnitEvent then there was problem with wait, no? i thought this work same way jass converted to jass from vjass

RegisterPlayerUnitEvent had a problem with waits because I didn't want it to be 2-3x slower

In this version, I'm forced to execute the trigger instead of just evaluating it because in GUI, you can't put all the code in the conditions block D:

ok ok but if we talk theoritical then useing specific unit events then it is faster for rpgs where only heroes can get that abilities?

The speed gain would be very marginal ;p
I don't want to complicate things and give users the ability to configure which players get registered to the system and which players don't D:
A user who has some knowledge of Jass could do that by himself and a GUI user would only loose an amount of speed so little, even Nestharus wouldn't care =P

another question it's use ability start effect right? so not begins casting an ability,right?

Yeah, it registers triggers to the start ability effect event.
This is because it's the most commonly used event for spells.
You don't need a system to handle the channel and begin cast events because typically, for every 100 or so spells, you might have 5-20 that use those events, so you wouldn't gain a worthwhile amount of performance ;/

You would gain performance, but not as much as you would with this ;P

 

[zv27]

1.The system is very good...

2.This is absolutely unnecessary - set SpellEventTrigger = (ThisTrigger),set SpellEventAbility = Lesser Clarity Potion

3.The only thing that I personally do not like in this system is,constant repetition of the system trigger [Trigger - Run GUI SpellEvent <gen> (ignoring conditions)
] so I started working on this a bit and the result is excellent. Now only need one call system trigger.

4.OMG you gave me a good idea with this!!!

5.Sorry I forgot to say 5/5

 

[maddeem]

I think you could make this super simple by saving the trigger onto a hashtable with the abilities as the arrays. Then load the trigger at each spell cast and run it ;p

Edit: Looking at the triggers, thats exactly what you did... lol

 

[Magtheridon96]

2.This is absolutely unnecessary - set SpellEventTrigger = (ThisTrigger),set SpellEventAbility = Lesser Clarity Potion

I put those there so that the variables are auto-created when you paste the trigger data

edit
I'm going to make working with this easier by using your idea zv27 =)

 

[Arhowk]

1.The system is very good...

2.This is absolutely unnecessary - set SpellEventTrigger = (ThisTrigger),set SpellEventAbility = Lesser Clarity Potion

3.The only thing that I personally do not like in this system is,constant repetition of the system trigger [Trigger - Run GUI SpellEvent <gen> (ignoring conditions)
] so I started working on this a bit and the result is excellent. Now only need one call system trigger.

4.OMG you gave me a good idea with this!!!

5.Sorry I forgot to say 5/5

1) lolk?

2) Incorrect. Thats to automatically initialize those variables when copying and pasting into a map

3) Eh sorta true but its essentially the only way to do it besides having 8192 variables, which would lag even more

4) lolk?

5) lolk?

 

[shadowvzs]

@Magtheridon96/Bribe ty

3) Eh sorta true but its essentially the only way to do it besides having 8192 variables, which would lag even more

rofl, i have over 50 variable array if not more and u dont see any lagg after initilizing

sorry but u dont know how its work in wacraft or just underestimate it

 

[Magtheridon96]

Or I could use an array and add 1 more variable to store the number of spells :3

Trigger

• -------- Set Abilities --------
• Set SpellEventAbility[1] = Blizzard
• Set SpellEventAbility[2] = MassTeleport
• Set SpellEventAbility[3] = Summon Water Elemental
• Set SpellEventAbility[4] = Holy Light
• Set SpellEventAbility[5] = Resurrection
• Set SpellEventAbility[6] = Divine Shield
• -------- Set Triggers --------
• Set SpellEventTrigger[1] = CastBlizzard <gen>
• Set SpellEventTrigger[2] = CastMassTeleport <gen>
• Set SpellEventTrigger[3] = CastSummonWaterElemental <gen>
• Set SpellEventTrigger[4] = CastHolyLight <gen>
• Set SpellEventTrigger[5] = CastResurrection <gen>
• Set SpellEventTrigger[6] = CastDivineShield <gen>
• -------- Set Number of Abilities --------
• Set SpellEventCount = 6
• -------- Run the Initialization Trigger --------
• Trigger - Run SpellEvent GUI <gen> (ignoring conditions)

 

[shadowvzs]

Or I could use an array and add 1 more variable to store the number of spells :3

Trigger

• -------- Set Abilities --------
• Set SpellEventAbility[1] = Blizzard
• Set SpellEventAbility[2] = MassTeleport
• Set SpellEventAbility[3] = Summon Water Elemental
• Set SpellEventAbility[4] = Holy Light
• Set SpellEventAbility[5] = Resurrection
• Set SpellEventAbility[6] = Divine Shield
• -------- Set Triggers --------
• Set SpellEventTrigger[1] = CastBlizzard <gen>
• Set SpellEventTrigger[2] = CastMassTeleport <gen>
• Set SpellEventTrigger[3] = CastSummonWaterElemental <gen>
• Set SpellEventTrigger[4] = CastHolyLight <gen>
• Set SpellEventTrigger[5] = CastResurrection <gen>
• Set SpellEventTrigger[6] = CastDivineShield <gen>
• -------- Set Number of Abilities --------
• Set SpellEventCount = 6
• -------- Run the Initialization Trigger --------
• Trigger - Run SpellEvent GUI <gen> (ignoring conditions)

i prefer this because more with 1 line but less with alot run trigger line

 

[Magtheridon96]

Updated this system

 

[Arhowk]

@Magtheridon96/Bribe ty



rofl, i have over 50 variable array if not more and u dont see any lagg after initilizing

sorry but u dont know how its work in wacraft or just underestimate it

variable arrays dont matter. its the 8192 arrays that kill. I had about ~10 8192 variables in my map once and the game wouldn't run any user-defined triggers whatsoever because of a handle overload due to the array size

 

[Maker]

You don't necessarily need the spell count variable. Exitwhen abilityArray[x] == null.

 

[Magtheridon96]

AbilityArray == 0*



Yeah, that sounds good

 

[maddeem]

This just gets better and better, a must have for spell triggering.
5/5

 

[Noobsmoke]

So, can it now be used ?

 

[RiotApe]

If you assign "A unit starts the effects of an ability" to 400 triggers, you're creating 400 * 16 = 6400 spell effect events, and whenever a unit casts a spell, the conditions of all these 400 triggers will be evaluated (400 Trigger Evaluations :O)

With this, there will always be only 1 trigger evaluation/trigger execution per spell cast and only 16 spell effect events!

That's why this increases performance and keeps your FPS pretty high whenever a unit casts a spell!

Spell-spamming should never cause as much lag as it did ever again

thanks for clearing that up, I will surely use this for my map, Good Job!

 

[zv27]

Well, now this is much better
The way you do this a little different from my,but the basis is the same.
As for me personally, this should look like any system,simple and useful

Scoreboard
JASS VS GUI
10 - 0

 

[shadowvzs]

variable arrays dont matter. its the 8192 arrays that kill. I had about ~10 8192 variables in my map once and the game wouldn't run any user-defined triggers whatsoever because of a handle overload due to the array size

then u made something really wrong coz i use alot array and dont ahve any problem, i mean i never got error from this also u can consider when u make a array its isnt 8192 size because u watched from ur thread too, when u create unit group array then u must create cgroup manually its mean other index's unused


i really doubt normally the arrays kill any map because u cant see any map without arrays
think about that before hashtable patch still was alot rpg and every map used arrays what was made in we

basically anyway u dont need array with 8192 size, u can use more array or if u use unit and others array and u scared about 8192 then u can null when unit die

arrays still better in alot case because u dont need extra function calls, dont need group (what mean also alot function call and check) also more readable and easier to use

 

[Magtheridon96]

@Illidans911:

Here's a tip to increase map performance when using arrays in GUI:
- If you always set the array sizes to 1, it won't make a difference at all
Arrays in Warcraft III are defaulted to:

• 0
• ""
• null
• false
• 0.00

Thus, setting the size to something other than 1 for any array would just add overhead to the map initialization.

The sizes are only useful when you're in need of default values.

edit

So, can it now be used ?

Yeah :3

Anyway:
Updated.
This is the final version.
I had one more idea to make this 100% bug-free even when the user doesn't read the instructions at all,
but then I realized that a user who doesn't read the instructions deserves what he's going to get :>

 

[Chaosy]

For once i can use one of the good systems! not jngp ftw!

edit, @mag (on post bellow) i know that but close to every system i want to use is in vjass. for example the witchers cam system, makers custom window, the movement system (allowing setting speed more than normal).

 

[Magtheridon96]

All of Bribe's GUI systems are just like this
GUI DamageEngine, GUI UnitIndexer, GUI UnitEvent, etc..
So I wouldn't say that this is the first resource that brings vJass libs to GUI

 

[Matarael]

But in all seriousness, this is incredible. I have 70+ Hero units in my map and each has at least 1 triggered spell/ability. My previous method of avoiding the check lag was to have the triggers be activated only when the related Hero unit type is picked/enters the game. But this method is tons better.

 

[Losam]

All Their Functions that use of vJass Cause Errors in My World Edit Example: When a function and then Inactive Active, a message from the World's Edit Speaking Mistakes (More than 200 lines) and Non Allows Enable New Function because of errors.
Someone know Fix This?

 

[Arhowk]

Download JassNewGen and update to the latest JassHelper

 

[Jazztastic]

Me gusta. A simple trigger + addition to my map init trigger to make it run loads better. Wish I could +rep you again.

 

[maddeem]

I am using this in MineralZ, credits ofc

 

[nafre]

As usual Magtheridon you make the best systems. Thx for this system.https://www.hiveworkshop.com/forums/members/magtheridon96/

 

[Magtheridon96]

Thank you and you're welcome ^.^

 

[Adiktuz]

Basically this is a GUI adaptation of his vJASS SpellEvent library...

Very nice for those GUIers out there, now they can have a good triggered spell runner... XD

 

[Magtheridon96]

Yeah
I need more ideas for what I can for GUIers

 

[Adiktuz]

Ever care to try your hand for a missile system?

 

[Magtheridon96]

Great idea!

 

[Adiktuz]

if you make it, you'll be the King of the GUIers...

and I could maybe start making a campaign...