Review

Paralyzing Cask v1.0.3
This spell had been reviewed by jakeZinchttp://www.hiveworkshop.com/forums/members/jakezinc/#visitor_messaging

Trigger Code

• Set PC_Point[1] = (Position of (Triggering unit))
• Set PC_Point[2] = (Position of (Target unit of ability being cast))

^ Use your stored variables ( PC_Caster and Target ).

• Trigger - Turn on PC Loop <gen>

^ You can check if the index is equal to 1 before turning on the looping trigger.

• (Level of (Ability being cast) for (Triggering unit))

^ Again: Use your stored PC_Caster in triggering unit(), Store the Level of the ability being cast in the integer variable because you used it twice ( and it does makes your code faster ).

• Unit - Create 1 Missile for (Owner of (Triggering unit)) at PC_Point[1] facing PC_Point[2]

^ Use TRIGGERING PLAYER instead of Owner of Triggering Unit().

• Unit - Add Crow Form to PC_Missile[PC_IndexMax]
• Unit - Remove Crow Form from PC_Missile[PC_IndexMax]

^ Instead of this two lines of work, you can use to enable the fly ability of the dummy by setting it's movement type to 'fly' because it is only a dummy unit, also there's another way:

• Custom script: if UnitAddAbility(udg_PC_Unit,'Amrf') and UnitRemoveAbility(udg_PC_Unit,'Amrf') then
• Custom script: endif

.

• Unit - Add a 1.00 second Generic expiration timer to PC_Missile[PC_Loop]

^ Just kill the missile.

• Set PC_Speed[PC_IndexMax] = PC_ConfMissileSpeed

^ This line is not needed, use PC_ConfMissileSpeed instead.

• Custom script: set udg_PC_X = udg_PC_X + udg_PC_Speed[udg_PC_Loop] * Cos(udg_PC_Angle[udg_PC_Loop])
  • Custom script: set udg_PC_Y = udg_PC_Y + udg_PC_Speed[udg_PC_Loop] * Sin(udg_PC_Angle[udg_PC_Loop])

^ Inline these lines and put it inside the call SetUnitX/Y Func because it does only use once.

( Reduced Score Points: -9 )

Other than that none. I'd see your code is not leaking.

Documentation

The documentation is lacking and incomplete.
( Reduced Score Points: -4 )

Configuration

Configuration Trigger

• Configurable
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- model's path of your missile --------
    • Set PC_ConfMissileType = Abilities\Spells\Other\AcidBomb\BottleMissile.mdl
    • Set PC_ConfOnImpactSfx = Abilities\Spells\Other\AcidBomb\BottleMissile.mdl
    • -------- range for missile to seek new target --------
    • Set PC_ConfDetectionRange = 500.00
    • Set PC_ConfHomingSmoothingFactor = 0.00
    • -------- max flying height for the missile --------
    • Set PC_ConfMissileArc = 0.50
    • -------- missile speed --------
    • Set PC_ConfMissileSpeed = 15.00
    • -------- damage per level --------
    • Set PC_ConfDamageLevel[1] = 75.00
    • Set PC_ConfDamageLevel[2] = 100.00
    • Set PC_ConfDamageLevel[3] = 125.00
    • Set PC_ConfDamageLevel[4] = 150.00
    • -------- number of bounces per level --------
    • Set PC_ConfCountLevel[1] = 2
    • Set PC_ConfCountLevel[2] = 4
    • Set PC_ConfCountLevel[3] = 6
    • Set PC_ConfCountLevel[4] = 8

^ It is lacking at the documentation and some of them does not supporting every level supporting every level of the spell.

• Set PC_ConfMissileSpeed = 15.00

^ You must compute the speed in the core trigger like: 500.00 x 0.03 = 15.00
Where 500.00 must be the configuration speed not the 15.00. It depends from you.

• Set PC_ConfHomingSmoothingFactor = 0.00
• Set PC_ConfDetectionRange = 500.00

^ It must support some of the documentation and levels.

• Unit - Cause PC_Caster[PC_Loop] to damage PC_Target[PC_Loop], dealing PC_Damage[PC_Loop] damage of attack type Hero and damage type Normal

Make the attacktype and damagetype to be configurable.
( Reduced Score Points: -5 )

Also you can remove Conf Prefixes in the configuration variables.

Pros

Clean spell, simple, leakless and MUI. Does not generates a lag.

Cons

Inefficient triggering and it has no importing instruction.

Importing Instruction

There's no importing instruction
( Reduced Score Points: -10 )

Special Effects

The special effects are fitting these simple spells and adding an arc in paralyzing cask is nice and beautiful even if it is simple but maybe add some nice combination of effects ^^.

Usefulness

Useful from bouncing skills that can stun every units and deals a damage.

Suggestions

Make the movement type of the dummy to fly. Add more documentation. Add importing instructions too.
Don't add an ability to the dummy because it can consume a small time in importing process, Solution? add only the ability in the core trigger and make that dummy ability to be configurable. Remove the useless trigger like PC HomingLoop(..).

Description Tooltip

Tooltip is good and it does support every levels.

jakeZinc Score Board

Rejected: 1-10
Unacceptable : 11-30
Lacking : 31-49
Useful : 50-69
Recommended : 70-90
Highly Recommended : 91-100
Director Cut : 101-105

Scores

1) Triggering - 11/20
2) Documentation - 6/10
3) Importing Instruction - 0/10
4) Special Effects - 11/15
5) Usefulness - 18/20
6) Tooltip - 9/10
7) Configuration - 5/10

Ratings

Total Score - 60/105
jakeZinc Rating - 3.8/5
Status - Useful and Needs Fix