Working on a GUI Fullscreen Inventory

[D4RK_G4ND4LF]

I decided to post my WIPs of the GUI Inventory System I am working on and ask for help since many heads are smarter than one

Feel free to post any suggestions

I'll update the following list of problems as well as the system from time to time

Problems/Ideas/Questions/Stuff:

• Right now it disconnects in multiplayer mode cause the blizzard selection function is using local script and I can't think of any way around it
• How should the User Interface look like?
• What should be possible? (like selling, combining, item sets, etc.)

Progress:

• stuff is clickable
• buttons are shown
• inventory can be opened and closed
• selection and camera does not get messed up by opening and closing
• Items are swappable in inventory
• added full MUI support
• items can be dropped and picked up
• switched some things to hashtables so it should support an infinite number of everything
• ...except item types (but who wants to initialize more than 8190 items)
• Trigger-stuff-bonus-system implanted

 

[Etzer]

I shall say, good luck with that. GUI is incredibly hard to make a fullscreen inventory in.

 

[Grey Nightmare]

Amazing! That was surprisingly smooth, I don't know if the code is efficient or not, I won't notice on this machine or single player (didn't bother checking WE yet), but it seemed to flow really nicely.

Suggestions:

-> Lock The Camera.

-> If you can, this is probably impossible... hide or deactivate the green arrows there really annoying! But this is a side effect of using a spell and is tolerable.

-> Keep it up

 

[Noobsmoke]

i have a "better idea" for your GUI inventory

• GIForceSelection
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • -------- Force player to cast selection spell --------
    • Player Group - Pick every player in GI_Player and do (Actions)
      • Loop - Actions
        • Game - Force (Picked player) to press the key E

I recommand

• GIForceSelection
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Select
  • Actions
    • -------- Force player to cast selection spell --------
    • Player Group - Pick every player in GI_Player and do (Actions)
      • Loop - Actions
        • Game - Force (Picked player) to press the key E

or you can just add this:

-------- Force player to cast selection spell --------
Player Group - Pick every player in GI_Player and do (Actions)
Loop - Actions
Game - Force (Picked player) to press the key E

to GISelect (trigger)

 

[cookies4you]

try to use units with custom models with icon textures pasted on them. make the units selected

 

[D4RK_G4ND4LF]

try to use units with custom models with icon textures pasted on them. make the units selected

why? it already works that way and units take far more space than destructibles

i have a "better idea" for your GUI inventory

• GIForceSelection
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • -------- Force player to cast selection spell --------
    • Player Group - Pick every player in GI_Player and do (Actions)
      • Loop - Actions
        • Game - Force (Picked player) to press the key E

I recommand

• GIForceSelection
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Select
  • Actions
    • -------- Force player to cast selection spell --------
    • Player Group - Pick every player in GI_Player and do (Actions)
      • Loop - Actions
        • Game - Force (Picked player) to press the key E

or you can just add this:

-------- Force player to cast selection spell --------
Player Group - Pick every player in GI_Player and do (Actions)
Loop - Actions
Game - Force (Picked player) to press the key E

to GISelect (trigger)

if you cancel the casting you can play around with the dummy and I don't want that
maybe there is some way to get the order for stoping to target something
gonna test it
already thought about that myself but didn't try it though

edit:
unit selection is not instant so I have to use a wait to cast it the first time
however it is still much faster than clicking but slower than the loop
but in other cases it's faster so I will use this
it is now possible to do other stuff with the selection dummy but since the dummy can't do anything it does not really matter...
both solutions have their (dis-)advantages
I'll use your idea

thanks anyway

 

[lolreported]

I like this. It's a very simple system at the moment and the good thing is that it's GUI. I think you can finish this to be a fully working fullscreen inventory system, it should not be that hard. A question though, will this work just as a bag or will you add a function that allow heroes to equip items too? Anyway, goodluck!

 

[Anachron]

I like this. It's a very simple system at the moment and the good thing is that it's GUI.

Actually this is the bad thing. This makes it harder to edit and a nightmare to import.
(GUI triggers are way heavier then JASS ones)

 

[D4RK_G4ND4LF]

Actually this is the bad thing. This makes it harder to edit and a nightmare to import.
(GUI triggers are way heavier then JASS ones)

yeah! your system is far better than I could ever make this
...and now go and make your custom whatever system which will be so complex and great that nobody but you fully understands it
I won't mess with you since I know I can't win anyway
just let me say that this is GUI and yours is JASS so it's on a totally different level

I think you can finish this to be a fully working fullscreen inventory system, it should not be that hard. A question though, will this work just as a bag or will you add a function that allow heroes to equip items too? Anyway, goodluck!

The bag won't be a problem but I still wonder how I could achieve all the item effects most easily
I will require many abilities with even more levels and this will make things complicated
Nevertheless I'm going to try it

Ohsh-, a GUI fullscreen inventory system :O
I think it would be best to do things like this in vJASS.
Pretty much all systems should be done in vJASS since it's easier to use those systems and integrate them into other systems. Customizing vJASS systems is also easier.

congratulations to your 1000th post
and there is a pretty good one in vJASS already so making another one would not make much sense

 

[The Reborn Devil]

Ohsh-, a GUI fullscreen inventory system :O
I think it would be best to do things like this in vJASS.
Pretty much all systems should be done in vJASS since it's easier to use those systems and integrate them into other systems. Customizing vJASS systems is also easier.

 

[GhostThruster]

F***. You weren't joking when you said you were going to make a better GUI Inv than mine!

So, it is left-clickable and smooth! Did you use dummy units?

Well, good luck.

 

[Grey Nightmare]

It may be easier if you understand vJASS, but not everyone does. Whether this is because they can't learn it, don't have time to or can't be bothered. Either way, this is a nice attempt to cater for those people, as I said before, it's looking good, keep it up, the above people will be grateful (you would hope) .

Btw don't bother flaming me, I KNOW vJASS/JASS is more efficient but that doesn't void the above point.

 

[D4RK_G4ND4LF]

huuuuuuuge update

• Items are swappable in inventory
• added full MUI support
• items can be dropped and picked up
• switched some things to hashtables so it should support an infinite number of everything
• ...except item types (but who wants to initialize more than 8190 items)
• Trigger-stuff-bonus-system implanted

so how should the user interface look like?
and are there any other things you would like to have?

edit:
blizzards selection functions disconnect in multiplayer mode
I don't know much about synchronisation but I remember a function with "sync" in it
any ideas how to fix?

 

[lolreported]

huuuuuuuge update

• Items are swappable in inventory
• added full MUI support
• items can be dropped and picked up
• switched some things to hashtables so it should support an infinite number of everything
• ...except item types (but who wants to initialize more than 8190 items)
• Trigger-stuff-bonus-system implanted

Nice update. Find a bug though with the "drop item" function:

It works perfectly but there's one issue. When you change position of an item in the inventory and then drop it, the dropped item won't be putted in the heroes inventory or on the ground. Else it works good.

 

[D4RK_G4ND4LF]

Nice update. Find a bug though with the "drop item" function:

It works perfectly but there's one issue. When you change position of an item in the inventory and then drop it, the dropped item won't be putted in the heroes inventory or on the ground. Else it works good.

fixed this and 2 other bugs
(buttons somehow "stacked" so they became higher and higher and when picking up items in inventory mode it would not show them correctly)
but I still have problems with the selection and I don't know if showing the buttons only to local player might cause disc like the unit selection

 

[lolreported]

fixed this and 2 other bugs
(buttons somehow "stacked" so they became higher and higher and when picking up items in inventory mode it would not show them correctly)
but I still have problems with the selection and I don't know if showing the buttons only to local player might cause disc like the unit selection

Okey, nice. I don't really think it would cause a disconnect by only showing buttons for one player. Isn't that how other inventory systems work?

And what, do:

• Game - Force p to press the key E

cause disconnects?

 

[Anachron]

Flood, nope that don't.
You disconnect when you create handles for players only.

 

[lolreported]

Flood, nope that don't.
You disconnect when you create handles for players only.

Ah, okey. So, kinda offtopic but, if I'll use GetLocalPlayer and create an unit between that function. That will cause an disconnect, right?

 

[Anachron]

Yes, exactly.

 

[lolreported]

Okey, then I get it.

 

[88WaRCraFT3]

Ooo, awesome, but it's hard to select.

 

[Anachron]

Right now it disconnects in multiplayer mode cause the blizzard selection function is using local script and I can't think of any way around it

Horrible con. Use trackables instead of units.

 

[D4RK_G4ND4LF]

Horrible con. Use trackables instead of units.

the button selection is perfect (and how the fuck do you want to use trackables in GUI? ) but I am talking about

• Selection - Select group for player

function SelectGroupForPlayerBJ takes group g, player whichPlayer returns nothing
    if (GetLocalPlayer() == whichPlayer) then
        // Use only local code (no net traffic) within this block to avoid desyncs.
        call ClearSelection()
        call ForGroup( g, function SelectGroupBJEnum )
    endif
endfunction

and it disconnects all players but the host
if you know any way around it please tell me

 

[Anachron]

There is no way around it, that is why I tell you to use trackables.