Approved
Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
22nd July 2012
Magtheridon96:
IcemanBo: Too long as NeedsFix. Rejected.
22nd July 2012
Magtheridon96:
- "|cff999999" should be configurable
- The Color dictionary is totally unnecessary. Allow the user to configure the color string himself.
- Instead of having all those events in the ChatEvent trigger, you should loop from 1 to 12 on map init and add the events.
- It would be good to store things you're going to repeat over and over again. It's good for efficiency.
- In the Command Close trigger, you don't need to cache the player number because you're only referring to it once.
- In the Command Clear trigger, you don't need to cache the player number because you aren't using it at all ._.
18 Feb 2012
Bribe: You should only remove leaks when you create the leak in the first place (see: Command Register trigger).
"Set CS_TriggeringPGroup = (All players matching ((Matching player) Equal to CS_TriggeringP))" why don't you just use "convert player to player group" instead of all this complicated stuff?
Why do you have this huge block of checking if a value is "Not equal" to a certain amount. What other value would it be? When I see huge blocks of very similar stuff like this I think of how it can be simplified:
Bribe: You should only remove leaks when you create the leak in the first place (see: Command Register trigger).
"Set CS_TriggeringPGroup = (All players matching ((Matching player) Equal to CS_TriggeringP))" why don't you just use "convert player to player group" instead of all this complicated stuff?
Why do you have this huge block of checking if a value is "Not equal" to a certain amount. What other value would it be? When I see huge blocks of very similar stuff like this I think of how it can be simplified:
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 1
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 2
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 3
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 4
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 5
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 6
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 7
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 8
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 9
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 10
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 11
-
CS_ChatPlayerTargetNumb[CS_ChatterPlayerNumber] Not equal to 12
12th Feb 2012
Pharaoh_:
It leaks a lot. Use an in-game screenshot. Use variables and avoid repeating the same functions over and over again.
Fix these and I will review it further.
Pharaoh_:
It leaks a lot. Use an in-game screenshot. Use variables and avoid repeating the same functions over and over again.
Instead of manually registering the events, you may want to use Trigger - Add to trigger within a loop (from 1 to 12) and by checking if Player(IntegerA) is a player and in-game, so as to educate people who are using your resource and teach them how to do things faster.
PlayerGroup(Triggering player) leaks.
Use a variable to store repeated function calls, such as (Picked player), (Triggering player) and (Player number of (Triggering player)).
PlayerGroup(Triggering player) leaks.
Use a variable to store repeated function calls, such as (Picked player), (Triggering player) and (Player number of (Triggering player)).
Fix these and I will review it further.
