Advanced Chat System GUI v1.7

[Moderator]

19:44, 2nd Mar 2014
Magtheridon96: I'm only putting this in the Needs Fix state so it goes back to Pending after an update. It's just too much of a disaster to be reviewed because any review I give at this point will not be helpful since the whole thing requires re-engineering. Try reducing the size of the code by postponing the logical branches you're doing. It'll help. Try splitting the thing into multiple triggers and see if you can split up functionality. That way, you might be able to see the whole system from a better perspective and that could help you reduce the whole thing. Currently, this is a leviathan of a system and it's both hard to review and terrible to have due to its size.

 

[Malhorne]

Don't use run trigger checking condition where there is no condition.
Use ignoring condition it is more efficient.

 

[gorillabull]

nice but i think its kind of annoying to have to write /all and /team each time you want to write something. i think it would be better if the player could write /all once and from then be able to chat with everyone and if they write /team then be able to chat only with team until they write something else

 

[IcemanBo]

Commands which start with '/' won't work on battle net.

 

[Kazeon]

Don't use run trigger checking condition where there is no condition.
Use ignoring condition it is more efficient.

which condition do you mean? there are a lot of conditions there..

nice but i think its kind of annoying to have to write /all and /team each time you want to write something. i think it would be better if the player could write /all once and from then be able to chat with everyone and if they write /team then be able to chat only with team until they write something else

Yeah, I will make it easier next time

Commands which start with '/' won't work on battle net.

I dont know about that.. Anyway, user can change it anytime

Is there easier way to get the elapsed game time?

 

[Rheiko]

which condition do you mean? there are a lot of conditions there..

Chat Update's condition

 

[Kazeon]

it's updated.. now you dont have to write /all etc all time

 

[Malhorne]

You didn't change what I said

 

[Rheiko]

as Malhorne said before, Change this

Trigger - Run Chat Update <gen> (checking conditions)

to this

Trigger - Run Chat Update <gen> (ignoring conditions)

 

[Kazeon]

I obviously have changed it.. the trigger I posted above is version 1.0

 

[Rheiko]

change that description then..

 

[Kazeon]

updated with a lot of improvements and whole known bugs fixed
let me know what do you want to add in this system

 

[Kazeon]

updated..
now you can colorize your message, and a lot of improvements and fixes

 

[Kazeon]

updated.
now you can scroll up/down (defaultly by pressing up/down arrow) to view previous messages. you may change the scroll up/down event as you like it. a lot of improvements and fixed bugs on general group. this is a big update, I'm affraid there are a lot of new bugs, just report it if you find one thnks..

 

[Kazeon]

final update. since there is no report / suggestion
- small improvements on chat event

 

[Daffa]

If I get this correctly, if one installed the system, one needs to modify WC III Chat System so it doesn't look weird. Is that correct?

 

[Kazeon]

let me get this straight, I don't mean that the original one is bad, I see some people tried to create AI chat in their game but it looks weird because the AI chat is different from the player's. this system will make them similiar from each other. also I want to add an aditional touch where player can gives color to their chats. plus there is time tag on each sent message. actually I was fully inspired from HoN, if you have played it before you will know what I mean..

 

[Binsu]

This is really a much more improvement to the other approved Chat System by Belgarath with a time shown in the chat as well. The triggers looks neat and great judging from what I know but there might be still some leaks and such for the others.

Certainly useful and +rep.

 

[Kazeon]

hey, thnks a lot for the yummy rep

are you sure there are leaks inside the triggers?
may I ask you something?

which is faster?
Set CS_Player = Player(CS_Integer)
Do action 1 with CS_Player
...
Do action 5 with CS_Player

or just

Do action 1 with Player(CS_Integer)
...
Do action 5 with Player(CS_Integer)

will that storing Player(CS_Integer) into variable affects the efficiency?

 

[Binsu]

If it is used many times in a trigger, it would be wise to store it in a variable for efficiency, yes as far as I know. Anything that is used twice should be stored in a variable.

 

[Kazeon]

maybe I'm asking to a wrong moderator, you are not a spell moderator right?
my bad XD

but, hey, you are completely right I will update it then..


updated

 

[Binsu]

Not a spell moderator but I do know some little knowledge into triggering.

 

[Kazeon]

yes, of course
I'm sorry I didn't mean to humble you

 

[Kazeon]

seriously, GUI is so abandoned here.. I don't know why..

 

[Malhorne]

I truly don't understand the purpose of this post....
Nearly 75% of resources are GUI in the spell section ...
And btw it is not a threat since JASS is more efficient.
And at last I don't think this is really on-topic

 

[Kazeon]

hmm.. I see.. then why this system never gets any review? maybe because the triggers look like a killer?

 

[Malhorne]

Ahah I dunno xD
Maybe there isn't visible flaw to it

 

[Kazeon]

updated once more!
thnks to malhorne who found the tiny useless code with his eagle eye!

 

[Malhorne]

Ahah thanks

 

[Wrda]

Can you tell me what map this can be useful in? If you intend to use /all and etc commands you better change the "/" thing, like icemanbo said, or the user will think it is a bugged system when he finds out that in battle.net it doesn't work.

 

[Kazeon]

every map the only weird thing is user should configure gameplay constant using notepad then...

personaly, what I want from the first time is colorized chats. using normal chat, whatever you do, you can't colorize them. about "/", you can change it to anything you want, I don't know about bnet because I never played there. and debug message, sometimes system maker clear the screen first then shows yellow text at bottom and it's weird if there is currently an important message at the screen and then it's cleared, if you use "system" chat feature, you don't need to clear the screen. then AI chats, isn't that looks bad if the player's chat shows at the left-bottom of the screen but the AI's chat displayed differently? isn't that prettier if we and AI has a same chat? you can send personal chat easier than using normal chat in multiplayer game, you can enter any game commands without displayed at the screen or you want to display it, it's optional, so... why no use?

 

[Kazeon]

pretty sad

 

[Malhorne]

Why are you saying this ?

 

[Kazeon]

pending forever D:

EDIT:
next time I will never submit GUI resource anymore, I must understand that reviewing GUI is so damned hard..

 

[Magtheridon96]

Clearly, the system code can be smaller :V
Rethink the whole thing. Re-engineer it and question yourself at every point until it's a lot smaller, because I'm positive it can be.

 

[Kazeon]

it's positive after I learn jass :v
but please, if it's good enough for GUI just approve..

 

[Magtheridon96]

It's a useful system.

Tell you what: Make it smaller. Try that, and whether you fail or succeed at that, I'll approve it.

We need to stress on quality and I can't have a system that's not top-notch in all ways be approved, which is why I'm asking you to try shrinking it.
I mean, the last time I reviewed something this big, I spent the whole day staring at my monitor finding inadequacies and writing them down. About 5 hours of work. And what pissed me off was the fact that the system was deleted in the end and the user didn't even try listening to me.

 

[Kazeon]

lol.
but I fail hard D:

 

[Magtheridon96]

It's okay, I fail harder~

 

[Kazeon]

hey, don't worry, will delete this and make the jass version, with some APIs is cool (because I need this system)