Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
07:04, 17th Aug 2012
Magtheridon96:
Well, this is a lot better than the previous version.
Otherwise, good job.
If you don't want to use hashtables, it's not a major problem, but it would increase performance, and shorten your code just a bit.
IcemanBo: Too long as NeedsFix. Rejected.
07:04, 17th Aug 2012
Magtheridon96:
Well, this is a lot better than the previous version.
- If this were completely JASS, it would've been nicer to have a Conversation struct that has a list of Answer/Option groups, and you could register answer/option pairs to those groups, but this is a GUI system, and thus needs to be easy for beginners to use, and yours is, so my current rant is pointless
- You should store things like (Triggering unit), (Owner of (Triggering unit)) or whatever into variables instead of repeating them over and over again. (JASS is a slow interpreted language)
Otherwise, good job.
If you don't want to use hashtables, it's not a major problem, but it would increase performance, and shorten your code just a bit.