Wait in triggers

[haxel96]

I thought if u use wait in a trigger it will be interrupted if the trigger runs again, Example:

• Hero
  • Events
    • Unit - A unit enters Hero selection area <gen>
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
  • Actions
    • Set Temppoint = (Random point in Spawn area <gen>)
    • Unit - Move (Triggering unit) instantly to Temppoint
    • Custom script: call RemoveLocation (udg_Temppoint)
    • Unit - Add Invulnerable (Neutral) to (Triggering unit)
    • Wait 30.00 game-time seconds
    • Unit - Remove Invulnerable (Neutral) from (Triggering unit)

Does it?

 

[baassee]

if two units walk into that region one after an other it will be like this , X = first one Y = second one

X will be invulnerable for all time, Y will be vulnerable after 30 secs

 

[haxel96]

NO! thats didnt happen... i tested it, both lost invulnerability -.- has it something to do with "

• Wait 30.00 game-time seconds

it is game time seconds, i think if i use seconds it will get interrupted

 

[baassee]

shouldnt be like that ...

 

[DarkAngelAzazel]

Never ever use wait in triggers...

It's just baaad. similar to the goto in earlier programming languags :/

It just tends to cause problems.

 

[Maker]

You can use wait in triggers, if you use triggering unit after the wait just like in that trigger. Triggering unit is a local variable, it will work correctly.

 

[Damage]

Local variables will work fine with waits, as Maker says.

However, if you used something like:

• Set Unit = (Triggering Unit)
• Unit - Add Invulnerable (Neutral) to Unit
• Wait 30.00 game-time seconds
• Unit - Remove Invulnerable (Neutral) from Unit

Then it will definitely bug out when more than one unit triggers it in a 30 second interval, as it will edit a global variable part way into the actions of the other.

 

[haxel96]

yes i know, thanks for the help

 

[DarkAngelAzazel]

Oooooooh now I got this

I never took my time to learn how WE manages the gui variables :/

 

[baassee]

You can use wait in triggers, if you use triggering unit after the wait just like in that trigger. Triggering unit is a local variable, it will work correctly.

Say what?! Isn't Triggering unit in GUI just GetTriggeringUnit() in jass?

 

[Maker]

Yes it is. Maybe I worded that badly.

Triggering unit works like a local variable, it doesn't get overwritten when the trigger fires again.

 

[baassee]

right, now I get it ... damn seems that you learn something everyday

 

[Antares]

is that also true for any other references such as Ordered unit etc?

 

[Frunck]

Why would you want to use others, they all point to triggering unit anyway..

 

[DarkAngelAzazel]

Why would you want to use others, they all point to triggering unit anyway..

Not necasserily.

Imagine a trigger is based on the event: Unit dies

and you want to use the killing unit. That unit would NOT be the triggering unit. It would only be the killing unit.

 

[PurgeandFire]

is that also true for any other references such as Ordered unit etc?

Yep, they are all treated locally. Unless they use a bj_ global but I don't think any of them do.

 

[Maker]

Many of the Unit - Event Responses are not treated locally, like target unit of ability being cast. I only trust triggering unit

 

[Damage]

Target Unit of Ability Being Cast, Attacking Unit, Killing Unit, Trained Unit etc. Do not work locally.

Essentially, only variations of the Triggering Unit will work locally, where acquiring units other than the triggering will not work.

Eg.

• Events
  • Unit - A unit dies
• Conditions
• Actions
  • Wait 5.00 seconds
  • Unit - Explode (Killing Unit)

Doesn't work if retriggered within 5 seconds, as for this particular trigger, the killing unit is not the triggering unit - and hence the whole local/global thing goes crazy. It often results in the killing unit returning a NULL, and hence no action is taken.

Also, don't use things like Dying Unit, Entering Unit, Training Unit or whatever when Triggering Unit would do just fine.

So yeah, basically I said what Maker said - just trust Triggering Unit, otherwise keep on guard with your waits.

 

[baassee]

In the Essentials tut there is a list of which Event respones BJ's which refers to GetTriggeringUnit()

 

[Dr Super Good]

It's just baaad. similar to the goto in earlier programming languags :/

Well someone obviously is not a computer programmer.

Goto is still heavilly used as how else does your processor execute code like loops. It is still used in assembly and stuff for micro controlers so do not dis the goto instruction.

Wait (TriggerSleepAction) on the other hand is bad due to its poor ability to keep time. It not only is a lot slower than the specified wait but it gets worse in multiplayer. On top of that if there is any lag or pause in multiplayer the wait delay continues to expire but the game is physically paused.

In the end, use it only when you need some delay but how much does not mater. It is far better and more reliable to use timer objects as their delay is syncronized and accurate.

 

[Frunck]

Yes but mostly.. For example you should never use Ordered unit like he asked.