Voodoo Puppet Remake v1.0

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Voodoo Puppet Remake v1.0 | Reviewed by Maker | 28th Apr 2013

NEEDS FIX

The looping trigger should be initially off and turned off when the group becomes empty Voodoo Puppet Remove should be initially off and turned off when there are no units of that type in the map Add importing instructions. People might have to configure the ability condition and the current order line You have extra RemoveLocation calls in the looping trigger, you only need them at the end of the trigger The Puppets should have can't raise, does not decay death type Spell Submission Rules

[tr]

 

[Adiktuz]

first, use an in-game screenshot... 2nd, do you have permission to upload this?

 

[daRk_sParroW]

first, use an in-game screenshot... 2nd, do you have permission to upload this?

I don't have a screenshot yet.. and I'm the creator of this spell.. the username of my Hiveworkshop is dArK_sParroW...

------------------

rYan_xX as dArk_sParroW

 

[Adiktuz]

okay... please fix the screenshot ASAP... and also put the triggers/code on the description and tell us about the spell...

 

[Orcnet]

what's with the picture? that's so wrong, please use the image of the spell rather than using picture examples from windows xp

 

[Drunken_Jackal]

Dont use that sunset. No relation to voodoos.

 

[xorkatoss]

wow this spell is awesome!! 5/5

 

[Maker]

Improve the tooltip - what does the puppet do?
You leak a lot.
Don't use waits.
The spell is not MUI.
0.01 is too low of an interval.
You could use AddLightningEx() and MoveLightningEx() to gain some z-offset for the lightning.
Replace the three if/then/else thingies for unit ability level check with this:

• Unit - Create 1 Voodoo Puppet for (Owner of Casting_Unit) at ((Position of Casting_Unit) offset by 200.00 towards 0.00 degrees) facing (Facing of Casting_Unit) degrees
• Set VP_Puppet = (Last created unit)
• Unit - Add a (20.00 + (10.00 x (Real((Level of Voodoo Puppet for (Triggering unit)))))) second Generic expiration timer to VP_Puppet

but fix the leaks.

 

[f0rsAk3n]

wow this spell is awesome!! 5/5

You shouldn't just randomly hand out 5/5's.

ONTOPIC:

Don't use (Casting Unit). Use (Triggering Unit).

Your indexing is completely wrong and your code is a mess\not efficient at all.
I'm not trying to discourage you, but you should read This tutorial before submitting another spell.

You also need a spell pic and post the triggers in the description.

Anyway, this will be rejected.

 

[daRk_sParroW]

what's with the picture? that's so wrong, please use the image of the spell rather than using picture examples from windows xp

That Picture is nothing yet i WilL put a screenshot soon.

 

[Orcnet]

oh sure! go ahead

 

[daRk_sParroW]

Any comments?? Suggestions??

 

[Drunken_Jackal]

What does it do? Can you post the triggers?

 

[daRk_sParroW]

A New update

 

[maddeem]

Now thats some funky indexing... I'll look more into this
Oh this

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• Then - Actions
• Unit - Create 1 Voodoo Puppet for (Owner of VP_Caster[VP_Index[1]]) at ((Position of VP_Caster[VP_Index[1]]) offset by 200.00 towards (Facing of VP_Caster[VP_Index[1]]) degrees) facing (Facing of VP_Caster[VP_Index[1]]) degrees
• Set VP_Puppet[VP_Index[1]] = (Last created unit)
• Unit - Add a (20.00 + (10.00 x (Real((Level of Voodoo Puppet (Channeling) for VP_Caster[VP_Index[1]]))))) second Generic expiration timer to VP_Puppet[VP_Index[1]]
• Else - Actions

the if/then/else is useless here, remove it.
For lightning effects

• Events
• Time - Every 0.01 seconds of game time

is much too fast of a periodic now something <.02 would be much better.
this

• Lightning - Move VP_String[(Integer A)] to source (Position of VP_Caster[(Integer A)]) and target (Position of VP_Puppet[(Integer A)])

leaks every 0.01 seconds 2 times

• Unit - Create 1 Voodoo Puppet for (Owner of VP_Caster[VP_Index[1]]) at ((Position of VP_Caster[VP_Index[1]]) offset by 200.00 towards (Facing of VP_Caster[VP_Index[1]]) degrees) facing (Facing of VP_Caster[VP_Index[1]]) degrees

this leaks too.
and this

• Special Effect - Create a special effect at (Position of VP_Puppet[(Integer A)]) using Abilities\Spells\Items\AIso\AIsoTarget.mdl

• Unit - Move VP_Puppet[(Integer A)] instantly to ((Position of VP_Puppet[(Integer A)]) offset by -10.00 towards (Angle from (Position of VP_Caster[(Integer A)]) to (Position of VP_Puppet[(Integer A)])) degrees)

ok enough said this has too many leaks and like shit, if this were used in a rpg the game would last less than 30 mins. everyone would crash and no one would play that game again. LEAKS ARE BAD. FIX IT >.<

 

[daRk_sParroW]

New UpdateREMAKE

I hope this will get any better.