• Check out the results of the Techtree Contest #19!
  • Listen to a special audio message from Bill Roper to the Hive Workshop community (Bill is a former Vice President of Blizzard Entertainment, Producer, Designer, Musician, Voice Actor) 🔗Click here to hear his message!
  • Read Evilhog's interview with Gregory Alper, the original composer of the music for WarCraft: Orcs & Humans 🔗Click here to read the full interview.
  • Create a void inspired texture for Warcraft 3 and enter Hive's 34th Texturing Contest: Void! Click here to enter!
  • The Hive's 22nd Icon Contest: Creep Abilities is now concluded, time to vote for your favourite set of icons! Click here to vote!

Variable "Overlapping Issue" Testmap Included

Status
Not open for further replies.

DoomBlade

DoomBlade

DoomBlade

Level 14
Joined
Feb 5, 2018
Messages
581
So im making achievements for my map and the issue is that if more than one player is killing units at the same time, the _Integer Variable_ runs more than once. So I tried with player 1 and player 2 killing units at the same time. And the achievements procced more than one time. Player 1 got rank 1 achievement 3 times. EDIT: Added test map to advert the issue more clearly.
  • Gnoll Killer
    • Events
      • Unit - A unit owned by Player 12 (Brown) Dies
    • Conditions
      • Or - Any (Conditions) are true
        • Conditions
          • (Unit-type of (Triggering unit)) Equal to Gnoll
          • (Unit-type of (Triggering unit)) Equal to Gnoll Poacher
          • (Unit-type of (Triggering unit)) Equal to Gnoll Mage
          • (Unit-type of (Triggering unit)) Equal to Gnoll Assassin
          • (Unit-type of (Triggering unit)) Equal to Gnoll Brute
          • (Unit-type of (Triggering unit)) Equal to Gnoll Lord
          • (Owner of (Killing unit)) Not equal to Player 9 (Gray)
    • Actions
      • If ((Owner of (Killing unit)) Equal to Player 1 (Red)) then do (Set GnollKiller_Ach[1] = (GnollKiller_Ach[1] + 1)) else do (Do nothing)
      • If ((Owner of (Killing unit)) Equal to Player 2 (Blue)) then do (Set GnollKiller_Ach[2] = (GnollKiller_Ach[2] + 1)) else do (Do nothing)
      • If ((Owner of (Killing unit)) Equal to Player 3 (Teal)) then do (Set GnollKiller_Ach[3] = (GnollKiller_Ach[3] + 1)) else do (Do nothing)
      • If ((Owner of (Killing unit)) Equal to Player 4 (Purple)) then do (Set GnollKiller_Ach[4] = (GnollKiller_Ach[4] + 1)) else do (Do nothing)
      • If ((Owner of (Killing unit)) Equal to Player 5 (Yellow)) then do (Set GnollKiller_Ach[5] = (GnollKiller_Ach[5] + 1)) else do (Do nothing)
      • If ((Owner of (Killing unit)) Equal to Player 6 (Orange)) then do (Set GnollKiller_Ach[6] = (GnollKiller_Ach[6] + 1)) else do (Do nothing)
      • If ((Owner of (Killing unit)) Equal to Player 7 (Green)) then do (Set GnollKiller_Ach[7] = (GnollKiller_Ach[7] + 1)) else do (Do nothing)
      • If ((Owner of (Killing unit)) Equal to Player 8 (Pink)) then do (Set GnollKiller_Ach[8] = (GnollKiller_Ach[8] + 1)) else do (Do nothing)
      • Trigger - Run Gnoll Killer Check <gen> (checking conditions)
  • Gnoll Killer Check
    • Events
    • Conditions
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • GnollKiller_Ach[1] Equal to 10
        • Then - Actions
          • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 1 for player + (Name of Player 1 (Red)))
          • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+150 Gold...
          • Player - Add 1 to Player 1 (Red) Current lumber
          • Player - Add 150 to Player 1 (Red) Current gold
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • GnollKiller_Ach[1] Equal to 25
            • Then - Actions
              • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 2 for player + (Name of Player 1 (Red)))
              • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+200 Gold...
              • Player - Add 1 to Player 1 (Red) Current lumber
              • Player - Add 200 to Player 1 (Red) Current gold
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • GnollKiller_Ach[1] Equal to 50
                • Then - Actions
                  • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 3 for player + (Name of Player 1 (Red)))
                  • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+300 Gold...
                  • Player - Add 1 to Player 1 (Red) Current lumber
                  • Player - Add 300 to Player 1 (Red) Current gold
                • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • GnollKiller_Ach[2] Equal to 10
        • Then - Actions
          • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 1 for player + (Name of Player 2 (Blue)))
          • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+150 Gold...
          • Player - Add 1 to Player 2 (Blue) Current lumber
          • Player - Add 150 to Player 2 (Blue) Current gold
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • GnollKiller_Ach[2] Equal to 25
            • Then - Actions
              • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 2 for player + (Name of Player 2 (Blue)))
              • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+200 Gold...
              • Player - Add 1 to Player 2 (Blue) Current lumber
              • Player - Add 200 to Player 2 (Blue) Current gold
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • GnollKiller_Ach[2] Equal to 50
                • Then - Actions
                  • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 3 for player + (Name of Player 2 (Blue)))
                  • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+300 Gold...
                  • Player - Add 1 to Player 2 (Blue) Current lumber
                  • Player - Add 300 to Player 2 (Blue) Current gold
                • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • GnollKiller_Ach[3] Equal to 10
        • Then - Actions
          • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 1 for player + (Name of Player 3 (Teal)))
          • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+150 Gold...
          • Player - Add 1 to Player 3 (Teal) Current lumber
          • Player - Add 150 to Player 3 (Teal) Current gold
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • GnollKiller_Ach[3] Equal to 25
            • Then - Actions
              • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 2 for player + (Name of Player 3 (Teal)))
              • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+200 Gold...
              • Player - Add 1 to Player 3 (Teal) Current lumber
              • Player - Add 200 to Player 3 (Teal) Current gold
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • GnollKiller_Ach[3] Equal to 50
                • Then - Actions
                  • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 3 for player + (Name of Player 3 (Teal)))
                  • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+300 Gold...
                  • Player - Add 1 to Player 3 (Teal) Current lumber
                  • Player - Add 300 to Player 3 (Teal) Current gold
                • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • GnollKiller_Ach[4] Equal to 10
        • Then - Actions
          • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 1 for player + (Name of Player 4 (Purple)))
          • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+150 Gold...
          • Player - Add 1 to Player 4 (Purple) Current lumber
          • Player - Add 150 to Player 4 (Purple) Current gold
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • GnollKiller_Ach[4] Equal to 25
            • Then - Actions
              • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 2 for player + (Name of Player 4 (Purple)))
              • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+200 Gold...
              • Player - Add 1 to Player 4 (Purple) Current lumber
              • Player - Add 200 to Player 4 (Purple) Current gold
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • GnollKiller_Ach[4] Equal to 50
                • Then - Actions
                  • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 3 for player + (Name of Player 4 (Purple)))
                  • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+300 Gold...
                  • Player - Add 1 to Player 4 (Purple) Current lumber
                  • Player - Add 300 to Player 4 (Purple) Current gold
                • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • GnollKiller_Ach[5] Equal to 10
        • Then - Actions
          • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 1 for player + (Name of Player 5 (Yellow)))
          • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+150 Gold...
          • Player - Add 1 to Player 5 (Yellow) Current lumber
          • Player - Add 150 to Player 5 (Yellow) Current gold
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • GnollKiller_Ach[5] Equal to 25
            • Then - Actions
              • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 2 for player + (Name of Player 5 (Yellow)))
              • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+200 Gold...
              • Player - Add 1 to Player 5 (Yellow) Current lumber
              • Player - Add 200 to Player 5 (Yellow) Current gold
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • GnollKiller_Ach[5] Equal to 50
                • Then - Actions
                  • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 3 for player + (Name of Player 5 (Yellow)))
                  • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+300 Gold...
                  • Player - Add 1 to Player 5 (Yellow) Current lumber
                  • Player - Add 300 to Player 5 (Yellow) Current gold
                • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • GnollKiller_Ach[6] Equal to 10
        • Then - Actions
          • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 1 for player + (Name of Player 6 (Orange)))
          • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+150 Gold...
          • Player - Add 1 to Player 6 (Orange) Current lumber
          • Player - Add 150 to Player 6 (Orange) Current gold
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • GnollKiller_Ach[6] Equal to 25
            • Then - Actions
              • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 2 for player + (Name of Player 6 (Orange)))
              • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+200 Gold...
              • Player - Add 1 to Player 6 (Orange) Current lumber
              • Player - Add 200 to Player 6 (Orange) Current gold
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • GnollKiller_Ach[6] Equal to 50
                • Then - Actions
                  • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 3 for player + (Name of Player 6 (Orange)))
                  • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+300 Gold...
                  • Player - Add 1 to Player 6 (Orange) Current lumber
                  • Player - Add 300 to Player 6 (Orange) Current gold
                • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • GnollKiller_Ach[7] Equal to 10
        • Then - Actions
          • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 1 for player + (Name of Player 7 (Green)))
          • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+150 Gold...
          • Player - Add 1 to Player 7 (Green) Current lumber
          • Player - Add 150 to Player 7 (Green) Current gold
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • GnollKiller_Ach[7] Equal to 25
            • Then - Actions
              • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 2 for player + (Name of Player 7 (Green)))
              • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+200 Gold...
              • Player - Add 1 to Player 7 (Green) Current lumber
              • Player - Add 200 to Player 7 (Green) Current gold
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • GnollKiller_Ach[7] Equal to 50
                • Then - Actions
                  • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 3 for player + (Name of Player 7 (Green)))
                  • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+300 Gold...
                  • Player - Add 1 to Player 7 (Green) Current lumber
                  • Player - Add 300 to Player 7 (Green) Current gold
                • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • GnollKiller_Ach[8] Equal to 10
        • Then - Actions
          • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 1 for player + (Name of Player 8 (Pink)))
          • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+150 Gold...
          • Player - Add 1 to Player 8 (Pink) Current lumber
          • Player - Add 150 to Player 8 (Pink) Current gold
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • GnollKiller_Ach[8] Equal to 25
            • Then - Actions
              • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 2 for player + (Name of Player 8 (Pink)))
              • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+200 Gold...
              • Player - Add 1 to Player 8 (Pink) Current lumber
              • Player - Add 200 to Player 8 (Pink) Current gold
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • GnollKiller_Ach[8] Equal to 50
                • Then - Actions
                  • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 3 for player + (Name of Player 8 (Pink)))
                  • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+300 Gold...
                  • Player - Add 1 to Player 8 (Pink) Current lumber
                  • Player - Add 300 to Player 8 (Pink) Current gold
                • Else - Actions
 

Attachments

Last edited:
Yeah, that's because the second trigger is a bit generic and isn't distinguishing which player has just killed any of those units. So, if player 1 achieves "Gnoll Killer Rank 1", and then player 2 kills multiple units, player 1 will be stuck in that situation until another unit be killed by them (player 1).

Well, I suggest that you merge both triggers into one, and use a few extra functions in your favor so that you get rid of that bloated code, and fix the issue at once. There's a function which retrieves/returns which player triggered the event and another one which gets the player number. Combining both functions will get rid of the need of checking all players' individual score in order to reward them.

  • Gnoll Killer
    • Events
      • Unit - A unit owned by Player 12 (Brown) Dies
    • Conditions
      • Or - Any (Conditions) are true
        • Conditions
          • (Unit-type of (Triggering unit)) Equal to Gnoll Poacher
          • (Unit-type of (Triggering unit)) Equal to Gnoll Assassin
          • (Unit-type of (Triggering unit)) Equal to Gnoll
          • (Unit-type of (Triggering unit)) Equal to Gnoll Brute
          • (Unit-type of (Triggering unit)) Equal to Gnoll Warden
          • (Unit-type of (Triggering unit)) Equal to Gnoll Overseer
          • (Owner of (Killing unit)) Not equal to Player 9 (Gray)
    • Actions
      • -------- Identify which player killed the gnoll, and store their number into a temporary variable --------
      • Set Killer = (Owner of (Killing unit))
      • Set PNumber = (Player number of Killer)
      • -------- Increase their score --------
      • Set GnollKiller_Ach[PNumber] = (GnollKiller_Ach[PNumber] + 1)
      • -------- Unlock achievements --------
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • GnollKiller_Ach[PNumber] Equal to 10
        • Then - Actions
          • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 1 for player + (Name of Killer))
          • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+150 Gold...
          • Player - Add 1 to Killer Current lumber
          • Player - Add 150 to Killer Current gold
        • Else - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • GnollKiller_Ach[PNumber] Equal to 25
            • Then - Actions
              • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 2 for player + (Name of Killer))
              • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+200 Gold...
              • Player - Add 1 to Killer Current lumber
              • Player - Add 200 to Killer Current gold
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • GnollKiller_Ach[PNumber] Equal to 50
                • Then - Actions
                  • Game - Display to (All players) for 10.00 seconds the text: (|c0020C000Achievement Unlocked:|r Gnoll Killer Rank 3 for player + (Name of Killer))
                  • Game - Display to (All players) for 10.00 seconds the text: |c00FFFC01+300 Gold...
                  • Player - Add 1 to Killer Current lumber
                  • Player - Add 300 to Killer Current gold
                • Else - Actions
By doing this, there won't be a player's score interfering with one another. Also, the trigger will look way simpler/easier to read.
 

Attachments

Thank you very much :) I will try this asap. Also if I use another achievement for a different unit type, like trolls for example. Will I just do the same trigger and they can run without bugging one another?
 
Status
Not open for further replies.

Similar threads

IGrimReaperI
  • Locked
Bugged Trigger
Replies
4
Views
1K
venger07
venger07
Ironside
  • Locked
[Solved] Drop Item
Replies
0
Views
1K
Ironside
Ironside
subressor
  • Locked
Variable array trigger bugging up
Replies
12
Views
2K
GhostWolf
GhostWolf
AlwaysAndForever
  • Locked
[Solved] Why does this trigger work only once?!
Replies
10
Views
2K
AlwaysAndForever
AlwaysAndForever
Airandius
  • Locked
Income trigger not working.
Replies
2
Views
1K
Airandius
Airandius
Back
Top