unit spawn optimizing

[duthorian10]

attack humans

• Attack humans
  • Events
    • Time - Every 200.00 seconds of game time
  • Conditions
  • Actions
    • Game - Display to (All players) the text: ...
    • Trigger - Turn on attack H spawns <gen>
    • Trigger - Turn on attack H spawns2 <gen>
    • Wait 1.50 seconds
    • Trigger - Turn off attack H spawns <gen>
    • Trigger - Turn off attack H spawns2 <gen>
    • AI - Ignore the guard positions of all Player 12 (Brown) units

attack humans spawns

• attack H spawns
  • Events
    • Time - Every 0.50 seconds of game time
  • Conditions
  • Actions
    • Unit - Create 1 Skeletal Mage for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))
    • Unit - Create 1 Ghoul for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))
    • Unit - Create 1 Skeleton Warrior for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))
    • Unit - Create 1 Zombie for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))
    • Unit - Create 1 Zergling for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))

My question is what can I do to optimize it? 1) Are the triggers leeking in someway? 2) Is there a problem that I use ''waits'', and if so, what can I replace them with?

 

[Maker]

You can do this to get rid of the wait:

attack humans

• Attack humans
  • Events
    • Time - Every 200.00 seconds of game time
  • Conditions
  • Actions
    • Game - Display to (All players) the text: ...
    • Trigger - Turn on attack H spawns <gen>
    • Trigger - Turn on attack H spawns2 <gen>

attack humans spawns

• attack H spawns
  • Events
    • Time - Every 0.50 seconds of game time
  • Conditions
  • Actions
    • Unit - Create 1 Skeletal Mage for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))
    • Unit - Create 1 Ghoul for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))
    • Unit - Create 1 Skeleton Warrior for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))
    • Unit - Create 1 Zombie for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))
    • Unit - Create 1 Zergling for Player 12 (Brown) at (Random point in gv3 <gen>) facing Default building facing degrees
    • Unit - Order (Last created unit) to Attack-Move To (Position of (Random unit from (Units owned by Player 3 (Teal))))
    • If count equal to 2 then
      • Turn off this trigger
      • Set count = 0
      • AI - Ignore the guard positions of all Player 12 (Brown) units
    • else
      • Set count = count + 1
    • endif

And read this: https://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

 

[IcemanBo]

You can do it like Maker said, but you can still remove some lines in unit creation.

Init

• Init
  • Ereignisse
    • Map initialization
  • Bedingungen
  • Aktionen
    • Set UnitType[1] = Mage
    • Set UnitType[2] = Ghoul
    • Set UnitType[3] = Warriror
    • Set UnitType[4] = Zombie
    • Set UnitType[5] = Zergling

And when create units then use a loop.

Loop

• For each (Integer A) from 1 to 5, do (Actions)
  • Loop - Actions
    • Unit - Create 1 UnitType[(Integer A)] for Player 12 at Point facing Point
    • Unit - Order (Last created unit) to Attack/Move to Point

If you would change number of unit types, also change the second integer value in top of loop.
And I would replace the Integer A by my own variable.

And as Maker has posted link, don't forget about memory leaks.