[JASS] unit group

[deathismyfriend]

umm is there a better pick random units than the get random sub group option in jass ? thx

 

[Nestharus]

array and GetRandomInt?

ForGroup/first of group loop with GetRandomInt rolls?

 

[deathismyfriend]

not sure tht would work i need it to pick every unit in unit group but after it picks tht unit it needs to be removed if tht would work for it cool could u show me how to set it up tho im not really sure how to and thx

 

[Starquizer]

umm is there a better pick random units than the get random sub group option in jass ? thx

not sure tht would work i need it to pick every unit in unit group but after it picks tht unit it needs to be removed if tht would work for it cool could u show me how to set it up tho im not really sure how to and thx

I don't understand, do you want to pick random unit from a unit group or do you want to remove a unit from a group.

More details please ?

 

[Maker]

set unit = FirstOfGroup(group)
call GroupRemoveUnit(group, unit)

 

[deathismyfriend]

Ok sry if I confused anyone lol I want it to pick all units in group but I want it to pick each unit randomly ex units 1,5,10,8 and so on then after it picks them I'm gonna do some actions and remove ik how to remove units I'm just stuck on the random unit portion

 

[Starquizer]

Then post #2 above.

Pick them using First of Group and add an integer counter then add each one to a unit array variable, like u = FirstOfGroup(g). Once you have constructed a list of unit array use random integer between 1 and i.

 

[deathismyfriend]

only problem is tht doesnt seem to let me select each unit from the group randomly ? i could select a unit randomly from the array but i need to select one randomly from the group to be able to use it then discard it basically

 

[defskull]

Guys, using FirstOfGroup is not a "true" random, see this test map for yourselves.
It ALWAYS starts with the left ones first, and goes to the right, like there is some pattern, a direct pattern perhaps.

It is always better to use this method;

• Actions
  • Set TempGroup = (Random 1 units from UnitGroup)
  • Unit Group - Pick every unit in TempGroup and do (Actions)
    • Loop - Actions
      • Unit Group - Remove (Picked unit) from UnitGroup
  • Custom script: call DestroyGroup(udg_TempGroup)

As I have ran several tests, it always has a random target in 5 sets of experiments I did - compared to using FirstOfGroup, always return the same set, following the same direct pattern which is not truly random at all.

 

[Nestharus]

array and GetRandomInt?

ForGroup/first of group loop with GetRandomInt rolls?

GetRandomInt(1, groupCount)

ForGroup, when count == int, return that unit and remove it from group

 

[deathismyfriend]

solved it lol i just did set unit = pick random unit from group lol

 

[defskull]

Remember you have to use 2 Group for this case, to clean the leak, else it would leak.
Using a direct reference of (Random N Units From Unit Group) will make it both leak (leak from the Unit Group itself, Leak from the Unit Group) if you don't set it to variables.

And if I'm not mistaken, using set bj_wantDestroyGroup = true in this case doesn't work as it will destroy the Unit Group first before it is used, therefore no actual Unit Group is used.

 

[deathismyfriend]

im reusing the unit group and i dont add the unit to another group either so im not sure how tht creates a leak ?

 

[defskull]

Oh and I thought you were using a temporary-generated Unit Group.

 

[deathismyfriend]

nope lol thx for the warning tho lol i didnt know about the bj_wantdestroygroup not working w tht lol