Tutorial: Easy income system

[Hordeon]

Hello today this tutorial (THIS IS MINI-TUTORIAL!) will show you how to do basicly correct income (Without Leaks).

My own income sysyem (I use this in my maps):

• Non-Leaking Income
  • Events
    • Time - Every X seconds of the game time
  • Conditions
  • Actions
    • Set tempGroup = (Units of type X Building)
    • Unit Group - Pick every unit in tempGroup and do (Actions)
      • Loop - Actions
        • Set tempForce = (Player group((Owner of (Picked unit))))
        • Player Group - Pick every player in tempForce
          • Loop - Actions
            • Player - Add 1 to (Owner of (Picked unit)))) Current gold
    • Custom script: call DestroyGroup(udg_tempGroup)
    • Custom script: call DestroyForce(udg_tempForce)

FAQ
Question 1: Is this income system gives gold for each player who have income building?
Answer: Yes.

Question 2: Why you subbmited this tutorial?
Answer: Becouse there are some newbies who must know that.

Question 3: How i could improve this income trigger?
Answer: Thats need to be maked by your own if you wanna better trigger.

Question 4: Is this trigger leaks?
Answer: This trigger isn't leaks.

 

[M4stah]

The trigger given DOES leak an unit group and this is just to simple to be a tutorial.

 

[Hordeon]

This is a mini-tutorial!
Em... Im so silly

I fix it

 

[KingB00ker]

This is a mini-tutorial!

It leaks, read here

 

[Hordeon]

It works! This trigger isn't leaking anymore! Hooray!

 

[intake360]

Double post much? . Remember the "Edit" button... bur I think your just trying to bump your post up. Anyways... this is way to simple. If this is acceptable then Hive will be swarming with short tutorials.

For future reference, fixing leaks is time consuming buisness. But can make your map much better.

You know whats a map with a bullshit load of memory leaks? Hungry Hungry Felhounds. Try goremode...

 

[Hordeon]

Deleted!

 

[Linaze]

This is just too simple and covers something most people probably could figure out on their own.

 

[Septimus]

Definitely agree with Linaze, way too simple and your tutorial doesn't follow the rules.

 

[Hordeon]

then i should delete this tutorial?

 

[Linaze]

Pyritie will graveyard it for you in time.

 

[Hordeon]

O.k. But if i improve this tutorial, maybe my tutorial will stay here?

 

[Linaze]

It's not that it isn't "good", the problem is that it covers something too too simple.

 

[Hordeon]

Hm... Im trying to improve it.

 

[Eleandor]

Question 4: Is this trigger leaks?

Answer: this trigger *is* leaks.

For each unit in the group you create a new TempForce. You only remove the TempForce once, at the end of the trigger. So you leak n-1 forces, n being the amount of buildings.
Also note that "Convert player to player group" GUI action leaks anyway, you need to jass the whole thing.

Just the fact alone that you create a force consisting of 1 player and then pick every player in that force (being that one player) and then doing absolutely nothing with the picked player is stupid. Get rid of the force alltogether.

There's also a bug: you're also counting destroyed buildings that haven't decayed yet. Set TempGroup = units of type "building" matching (matching unit is alive equal to true)

 

[intake360]

Answer: this trigger *is* leaks.

Rofl I just noticed that

 

[SlayerII]

You are just give us a trigger without any eyplanation. But thats exactly what a tutorial should make

If you explain it people may understand all parts of it and create their own systems of income. If you give some alternate ways for the income(like using a upgrade for income or hero lvl or whatever).THEn it would be a tutorial.

 

[Pyritie]

Not a tutorial.

Graveyarded.