Tsukuyomi v1.2

[Daffa]

Due to how the spell is technically is similar to an aura once activated, I used Passive/Aura tag along with No Target.

 

[TheCarnerox]

The biggest problem I see, is how the SFX is an eye sore, especially when changing directions. You could possibly lock the effect into facing a single direction by using a dummy unit and periodically update its location to the caster or rotate its direction smoothly in a 360 degree, while using the method above. On mobile, so I can't view the code over. But it seems to work like you have written.

 

[MyPad]

MyPad's Review:

Notes:

• [Potential Bug] When setting the time interval for the enumeration to a value lower than 0.05 in the Config Trigger, the probability of the spell failing to work as intended is very likely. A warning could be released, advising users not to set the time interval to such a low value.

Suggestions:

• The rotation of the aura effect could be addressed, since it seems very odd to see it rotate by itself, and on such disparate angles (erratic turning).
• Similarly, a fade-in mechanism could be introduced to the special effect, which would increase aesthetic appeal.

 

[Daffa]

Thank you for the review. Will be addressed soon. @MyPad

EDIT :
Addressed the bug issue with warning. As for the erratic turning, can't do much without making additional dummy. 2nd suggestion will cause a lost in backward compatibility.

 

[MyPad]

Very well. I might add some more suggestions here.

Suggestion/s:

• A certain effect should be created when the Aura ends, since its' sudden disappearance makes it appear plain.

However, if it turns out that my suggestions run contrary to what you envision as Tsukuyomi in Warcraft 3, you may disregard it.

 

[Daffa]

Odd I can't see the most recent post of @TheCarnerox unless it's the post above @MyPad's
I can make it have some sort of quick mark of dissipation, if there's something to pick out. I'll think of it. The original one is just 'pop out' when it dies, and the aura wasn't suppose to even pop while channel originally.

The first seconds reflect how this Tsukuyomi based on.

Since the problem with the aura is the rotation, I will need a secondary dummy to handle the spell, as the aura erratic turn comes from the slow ability used to make enemies slowed down.

 

[Pyrogasm]

Or use the new SFX move natives.

 

[Daffa]

Or use the new SFX move natives.

That kills the backward compat. As much as I don't want to support earlier patches, pretty much it'll lower the usability of this spell.

 

[MyPad]

There is an alternative. You can try using the dummy unit already provided by the Spell System, based on the code that I read.

 

[Daffa]

The dummy is used for SFX, though I can allocate my resources with a second dummy.

 

[Daffa]

Updated Tsukuyomi with 1.1. It now has a dissipate effect on caster (want to put it to dummy but it's sort of messy and will add complication due to removed unit erase effect) and has MUCH LESS erratic turns. Only when caster change facing direction it will turn now.

 

[MyPad]

After further tests, I figured out why the bug occurs in the first place for such low values.

If we take a look at this:

• Tsukuyomi Config
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- --------
    • -------- Do not put values below 0.20, there's a high chance of bug out on extremely low values like 0.05 --------
    • Set Spell__Time = 0.20
    • -------- Spell Duration is for channeling time --------
    • Set Spell__Duration = 4.00

We can see that Spell__Duration is divisible by Spell__Time, thus enabling this trigger's after-effects. However, if we set Spell__Time to anything that, when used as the divisor, and Spell__Duration as the dividend, will leave a visible remainder (e.g. not result in a whole number)

• Tsukuyomi Loop
  • Events
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Spell__Channeling Equal to False
      • Then - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Spell__Completed Equal to True
          • Then - Actions
            • --- --- --- --- --- --- --- ---
            • --- More actions here ---
            • --- --- --- --- --- --- --- ---
          • Else - Actions
            • --- --- --- --- --- --- --- ---
            • --- More actions here ---
            • --- --- --- --- --- --- --- ---
      • Else - Actions

So, going by these tests, we can conclude that the Spell__Duration, when negative, will never execute the inner portion of the trigger above (when Spell__Channeling is false).

In a nutshell, 4.00/0.05 is OK, but 4.00/0.045 isn't (remainder).

 

[Daffa]

Interesting, so I now need to scan for duration bound too eh? Guess I got some more work here

 

[Cherrymage]

Oh wow, tis' some really awesome master-tier spell, with so many effects at once!

Gonna make good use of it

 

[Daffa]

Oh wow, tis' some really awesome master-tier spell, with so many effects at once!

Gonna make good use of it

Thanks! Really appreciate it!

 

[Daffa]

Added some debugging helper for users to circumvent this issue with 1.1.2 @MyPad

 

[MyPad]

Re-examined the triggers and the same issue persists. However, I think that can be circumvented by having another variable determine the stage at which the spell is at, thereby making the test a lot easier, or doing something like this:

• Tsukuyomi Loop
  • Events
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Spell__Channeling Equal to False
      • Then - Actions
        • …
      • Else - Actions
        • ...
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Spell__Duration Less than or equal to 0.00
          • Then - Actions
            • Set Spell__Duration = (Spell__Duration mod Spell__Interval)
          • Else - Actions

The important part of the second conditional statement within the else statement of the first conditional statement is that you ensure that no overflow occurs, (e.g.: Spell__Duration less than 0, which causes the spell to fail at that point, since a negative duration tells the system that the looped part of the spell is done)

 

[Daffa]

I see, so I need to circumvent that way eh? I was thinking of having user doing the fix with a debug message for spotting the issue.

Sure, I'll arrange a fix.

 

[KILLCIDE]

Good use of Bribe's Spell System. The spell has a lot of configurables and given the number of Anime style maps in WC3, this can prove to be useful.

Needs Fixed

• Nothing

Suggestions

• Preload ability / effects used in the spell
• I would add attachment point configurables for the SFX. Different effects may look good or bad depending on the attachment point.
• Adjusting the facing angle of DummyUnitSFX gives me a huge headache. I'm not even sure why you would need to do that given the mechanics of the spell.

Status

Approved​

 

[Daffa]

Patched issue mentioned by @MyPad

Anyway, thanks for approval @KILLCIDE