Tree Revival 1.2.3.2

[Moderator]

19th Oct 2011
Bribe: Thanks for making the changes - good system.

 

[Magtheridon96]

Nice.
I like how this was made specifically for GUIers

 

[Bannar]

Heh, thanks.
Hope this simple system fixs the problem what many hive users are trying to solve and answer the frequently asked question on Help Zone section: 'how to revive a tree?'

 

[Deuterium]

Nice

 

[Bannar]

Just to inform: version 1.0.0.0 was created sometime ago for myself (or meaby request) - whatever - but last thread created due to this issue motivated me to improve the system.

 

[Bribe]

The harvest ability and its order ID should be configurable as constant
functions as well, in case the user changed the order ID of harvest for
example.

 

[Magtheridon96]

if udg_TRindexD == 0 then
->
if 0 == udg_TRindexD then

Also, in this function:

function InitTrig_TreeRevive takes nothing returns nothing
    set udg_TreeReviveTrig = CreateTrigger()
    set udg_TRhash = InitHashtable() 

  //* Actions required for IsDestructibleTree function
    set udg_dummyh = CreateUnit(Player(15), 'uloc', 0., 0., 0.)
    call ShowUnit(udg_dummyh, false)
    call UnitAddAbility(udg_dummyh, 'Ahrl')
    call UnitRemoveAbility(udg_dummyh, 'Amov')

  //* Revival setup
    call EnumDestructablesInRect(bj_mapInitialPlayableArea, null, function CallAddTree)
    call TriggerAddCondition(udg_TreeReviveTrig, Condition(function CallTreeRevive))
endfunction

When you enumerate the destructables, why don't you pass a the function CallAddTree as a boolexpr and just return false at the end.
You can pass null to the code parameter.

One thing:

function TRrecycleTimer takes timer t returns nothing
    debug if t == null then
        debug call BJDebugMsg("Attempt to release a null timer")
    else
        call PauseTimer(t)
        set udg_TRtimers[udg_TRindexN] = t
        set udg_TRindexN = udg_TRindexN + 1
    endif
endfunction

>_>
debug keyword?
This is Jass right?

Plus, even if it did exist in Jass, this wouldnt compile.
It's supposed to look like this:

function TRrecycleTimer takes timer t returns nothing
    debug if t == null then
        debug call BJDebugMsg("Attempt to release a null timer")
    debug else
        call PauseTimer(t)
        set udg_TRtimers[udg_TRindexN] = t
        set udg_TRindexN = udg_TRindexN + 1
    debug endif
endfunction

 

[Bannar]

@Bribe: functions added,

@Maggy: Yeah I forgot than 0 == X is faster then actually X == 0
About boolexpr - Thats no problem. I was thinking about that idea for quite long but at the end I realised that it's a tttttttttiny difference in efficiency.

~Updated.

 

[Magtheridon96]

But you still have the buggy debug statements :c

 

[Bannar]

Okey Maggy: quick review:

- debug works fine for GUI
- now, I remember why I haven't used boolexpr in EnumDestructablesInRect().. - it's fucked bugged and always returns null (no tree revives)

 

[Magtheridon96]

I'm not sure about that but.. whatever you say

They still have to be changed though:

function TRrecycleTimer takes timer t returns nothing
    debug if t == null then
        debug call BJDebugMsg("Attempt to release a null timer")
    else
        call PauseTimer(t)
        set udg_TRtimers[udg_TRindexN] = t
        set udg_TRindexN = udg_TRindexN + 1
    endif
endfunction

->

function TRrecycleTimer takes timer t returns nothing
    debug if t == null then
        debug call BJDebugMsg("Attempt to release a null timer")
    debug else
        call PauseTimer(t)
        set udg_TRtimers[udg_TRindexN] = t
        set udg_TRindexN = udg_TRindexN + 1
    debug endif
endfunction

 

[Bannar]

I won't =p

 

[Magtheridon96]

-_-'
It's a compile error.

 

[Bribe]

"When you enumerate the destructables, why don't you pass a the function CallAddTree as a boolexpr and just return false at the end."

I think it's faster to use the code argument to be honest. Plus it doesn't create a boolexpr handle.

 

[Bannar]

Bribe, I stayed with my enumerate function as it was, in case boolexpr in EnumDestructablesInRect() doesn't seem to work (or meaby it just can't revieve null code). You can test it though, since I was doing that long time ago.

EDIT: I just tried and my system registers totaly of 0 trees if I use boolexpr trick.

 

[Bribe]

You have to use GetFilterDestructable in such case.

 

[Magtheridon96]

I just tried and my system register totaly of 0 trees if I use boolexpr trick

Which is to be expected since we're returning false xD
You know what, just use the code instead : p

edit
Or do what Bribe said

 

[Bannar]

No, Bribe was right. I haven't changed the GetFilterDestructable.
And I was doing that mistake for months? LOL?

Anyways, I stay with my code.

 

[xorkatoss]

i don't get it...is your system better than this?

Tree Resurrection System

• Tree Setup
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Destructible - Pick every destructible in (Playable map area) and do (Actions)
      • Loop - Actions
        • Trigger - Add to TreeRevive Setup <gen> the event (Destructible - (Picked destructible) dies)

• Tree Resurrection
  • Events
  • Conditions
  • Actions
    • Wait 6.00 seconds
    • Destructible - Resurrect (Dying destructible) with (Max life of (Dying destructible)) life and Show birth animation

it does pretty much the same thing...

 

[Magtheridon96]

"Pick every destructable in.." is limited

This system's purpose is to do what those above triggers do in a leakless and efficient way.

 

[Adiktuz]

@ xorkatoss: that would revive every destructable not just trees... and also buggy...

btw, nice trick to use harvest to check if its a tree... ^_^

just a question, can't we just change this:

function CallAddTree takes nothing returns nothing
    if IsDestructableTree(GetEnumDestructable()) then
        call TriggerRegisterDeathEvent(udg_TreeReviveTrig, GetEnumDestructable())
    endif
endfunction

into

function CallAddTree takes nothing returns nothing
    if IssueTargetOrderById(udg_dummyh, TRorderId(), GetEnumDestructable()) then
        call TriggerRegisterDeathEvent(udg_TreeReviveTrig, GetEnumDestructable())
    endif
endfunction

 

[Bannar]

@xorkatoss Have you read explanation in first post? No.
Waits are inaccurate (if someone wants for example 60 sec delay before actually resurrecting a tree waits can take values ~55-72 if I'm not mistaken)

Your script doesn't contain option to check if destructable is tree and isn't user-friednly (doesn't have any options to choose from, user has to enter the script to change anything).

Plus it's much slower and much less efficient; since I've created GUI-friednly version there shouldn't be a problem for them (GUI-community) to implement the system. If they want to configure anything, there are multiple constant functions for that at the top (so user can omit the core).


@Adiktuz: The only reason why I haven't done such thing is because I want user be free to check if given destructible is a tree with just calling function (mentioned in first post) - I didn't want to force anyone (GUI-users especialy) to write:

• Custom script: if IssueTargetOrderById(udg_dummyh, TRorderId(), <destructible here>) then
• // stuff
• Custom script: endif

I'm pretty sure there is nothing wrong with leaving that function alone, enabling anyone to just write:

• Custom script: if IsDestructableTree(<destuctable here>) then
• // stuff
• Custom script: endif

I think it's much more handy and helps for further purposes, egzample: knockback which destroys only trees (not walls etc.).

~Version 1.2.3.0 released.

- You can now disable/enable tree reviving via global TRisEnabled.
Anytime you want tree not to be resurrected just use:

• Set TRisEnabled = False
• Destructable - Kill <tree here>
• Set TRisEnabled = True

By defaul system has 'TRisEnabled' set to 'True', so trees are being revived anytime they die.

 

[Adiktuz]

I didn't say that you should remove the function totally... ^.^

 

[Magtheridon96]

@Adiktuz
It gets inlined anyways

 

[xorkatoss]

@ xorkatoss: that would revive every destructable not just trees... and also buggy...

how about this one?

Regrow Trees System

• Regrow Trees Setup
  • Events
    • Time - Elapsed game time is 0.00 seconds
  • Conditions
  • Actions
    • Destructible - Pick every destructible in (Entire map) and do (Actions)
      • Loop - Actions
        • Trigger - Add to RegrowTrees <gen> the event (Destructible - (Picked destructible) dies)

• RegrowTrees
  • Events
  • Conditions
  • Actions
    • Custom script: local destructable BADTREE = GetDyingDestructable()
    • Wait 7.00 seconds
    • Custom script: call DestructableRestoreLife( BADTREE, GetDestructableMaxLife(BADTREE), true )

is his system better than this?
pls explain me what's the difference because i don't really understand it *_*

 

[Bannar]

Read this before actually posting nothing, yes nothing since you have just repeated your previous post.

After reading both (mine and Adiktuz) posts and accumulating that knowledge come back here with constructive criticism. It's simple system just to omit the limitation brought by TriggerRegisterDestDeathInRegionEvent(trig, r), and thats why systems are usually made for - to make life easier.

Just additional issue about your script (to those mentioned already above): GetDyingDestructible() is slower than GetTriggerDestructible().
Don't fail so much next tim dude. Good luck.

 

[Darkfang]

Why dont just make it a simple system of GUI periodic event each 5 mins or 8 mins or wharever.

Event:
each 10 mins of the game
Conditions:
Null
Action
IfThenElse:
Pick every destructible in entire map
-Or Multiple conditions
-If Picked destructible (all types of tree)
-If life of picked desructible is equal to 0
--Action:
Resurrect picked destructible and show birth anims
Else: Remove not matching destructibles.. etc

Else you can do a pick destructible group and try saving it on a hashtable by the use of another trigger (with custom script). Anyways its a good system.

Else you should remember that if there is a unit near a dead tree (100 units near) i recommend you to remove the tree or to avoid the resurrection of it.

 

[xorkatoss]

Just additional issue about your script (to those mentioned already above): GetDyingDestructible() is slower than GetTriggerDestructible().

ive already readed the one above, i just didn't understand anything xD
i really couldn't care less about the GetTriggerDestructible() thingy...
only useful scripts to me are "RemoveLocation" and "call want_DestroyGroup = true" since im a GUIer...

EDIT:
i forgot to tell you, that tree revival system is not mine, it was in this spell...so it wasn't me who actually failed lol

 

[baassee]

@Adiktuz
It gets inlined anyways

With Vex's Optmizer yes? Else no.

Why dont just make it a simple system of GUI periodic event each 5 mins or 8 mins or wharever.

Event:
each 10 mins of the game
Conditions:
Null
Action
IfThenElse:
Pick every destructible in entire map
-Or Multiple conditions
-If Picked destructible (all types of tree)
-If life of picked desructible is equal to 0
--Action:
Resurrect picked destructible and show birth anims
Else: Remove not matching destructibles.. etc

Else you can do a pick destructible group and try saving it on a hashtable by the use of another trigger (with custom script). Anyways its a good system.

Else you should remember that if there is a unit near a dead tree (100 units near) i recommend you to remove the tree or to avoid the resurrection of it.

1. If a tree dies 1 second before the 8 min mark, it will be revived.

2. He is already saving into a hashtable?

3. I don't see the need for this. It does what it's supposed to do. Reviving trees.

ive already readed the one above, i just didn't understand anything xD
i really couldn't care less about the GetTriggerDestructible() thingy...
only useful scripts to me are "RemoveLocation" and "call want_DestroyGroup = true" since im a GUIer...

EDIT:
i forgot to tell you, that tree revival system is not mine, it was in this spell...so it wasn't me who actually failed lol

Knowing a bit JASS could be good for a GUIer, especially when it comes to mapmaking (when you learn vJASS like me you'll find out how shit the map was before you fixed it).

That local tree system is a basic system made by someone at TH I think (maybe even Ryoko) or made by Niddhog-kunn back in the old days of THW (I don't remember which one who was the one who made it).

Waits depends on the latency of the player. And lower periods.

 

[Magtheridon96]

function TRrecycleTimer takes timer t returns nothing
    debug if t == null then
        debug call BJDebugMsg("Attempt to release a null timer")
    else
        call PauseTimer(t)
        set udg_TRtimers[udg_TRindexN] = t
        set udg_TRindexN = udg_TRindexN + 1
    endif
endfunction

Spinnaker, this wouldn't even compile outside debug mode

It would compile to this:

function TRrecycleTimer takes timer t returns nothing
    else
        call PauseTimer(t)
        set udg_TRtimers[udg_TRindexN] = t
        set udg_TRindexN = udg_TRindexN + 1
    endif
endfunction

This would be a compile error.
It causes the map to be unplayable.

That's why you should do this:

function TRrecycleTimer takes timer t returns nothing
    debug if t == null then
        debug call BJDebugMsg("Attempt to release a null timer")
    debug else
        call PauseTimer(t)
        set udg_TRtimers[udg_TRindexN] = t
        set udg_TRindexN = udg_TRindexN + 1
    debug endif
endfunction

 

[baassee]

Doesn't the whole if go debugmode if you put it infront of the if?

 

[Magtheridon96]

I don't think it does..

To find out for sure, we should test this system in-game.

If the map doesn't exit before the loading screen, then it works.

 

[baassee]

LOL we dont even need to test the system. Just use normal WE and type like 5 lines at maximum in GUI. Although I don't have the time to do even that studies...

 

[Map Designer]

WOW. Just what I was thinking of. Now how can I make an ability or condition or whatever to using this?

 

[Bannar]

What'd happen if tree's coords are 0,0? It will be attacked - tested and even if it's rare - that sucks. Will soon check if this occurs while using this snippet and correct if needed.

Edit: Adding IssueImmediateOrderById(udg_dummyh, 851972) will fix the issue.

 

[Almia]

Why not update this and include your Tree Revival vJASS?

 

[fang24]

Well I did what you said but it does not work when i try to copy past the tree revival into my map.

 

[fang24]

i don't get it...is your system better than this?

Tree Resurrection System

• Tree Setup
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Destructible - Pick every destructible in (Playable map area) and do (Actions)
      • Loop - Actions
        • Trigger - Add to TreeRevive Setup <gen> the event (Destructible - (Picked destructible) dies)

• Tree Resurrection
  • Events
  • Conditions
  • Actions
    • Wait 6.00 seconds
    • Destructible - Resurrect (Dying destructible) with (Max life of (Dying destructible)) life and Show birth animation

it does pretty much the same thing...

ok do any of these even work any more? Half of those things are just not possible to do because the command does not exist. And any time I ask someone to prove it by giving me a map download i eather get "I don't have to prove it it is easy to do." or I put it in move it to another map and it does not work. So what can I possable be doing wrong that this stuff just can't happen?

 

[Dr Super Good]

07/Mar/2019
Moved to awaiting updated: The map fails to save on 1.30.4 editor due to bad debug tag usage. It can only be saved with JASSHelper set to debug build mode.

The error is in the TR_recycleTimer function. One has to debug tag the else and endif blocks so they are ignored when not built in debug mode.

 

[Bannar]

07/Mar/2019
Moved to awaiting updated: The map fails to save on 1.30.4 editor due to bad debug tag usage. It can only be saved with JASSHelper set to debug build mode.

The error is in the TR_recycleTimer function. One has to debug tag the else and endif blocks so they are ignored when not built in debug mode.

Thank you for reporting this.

Updated the resource as per moderator request.

 

[Dr Super Good]

Confirmed to save without modification using 1.30.4. Sending back to approved.

 

[severed]

Amazing! I was thinking about adding this into a map I am working on but, I have some questions:

1- what happens if a player constructs buildings where the trees were cutdown? will trees regrow all around the building and block/trap units?

2- say if a player uses siege/aoe to cut a path through the trees, will the whole area regrow all at nearly the same time?

3- is it possible to set it so only 20% of trees will regrow? or maybe have some trees will regrow faster than others, and some will take a very long time (randomly)? that way I dont have to worry about buildings getting blocked because the entire area filled back in all at once

Maybe you could set it up like this:

10% of trees regrow in 10-20mins
15% of trees regrow in 25-35mins
20% of trees regrow in 40-50mins
25% of trees regrow in 60+ mins
30% of trees never regrow
and trees shouldnt regrow directly around buildings

or something like that, I think it would be nicer than having them all regrow at the same time, if you could update your triggers for me I would really appreciate this so then I can use it in my map without worrying that a players base might get blocked thanks!


Off-topic:
Another idea that could be included with this is: maybe possibly creating some kind of spell/item that allows players to raise/grow trees? maybe allowing players to grow trees in new places and create new walls to possibly trap enemies with? lol thats just a silly idea, its not necessary though actually... that might already exist so nvm