Treasure Hunter System! v1.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

23:23, 7th Feb 2014
BPower:
This will be an awesome resource, but for now the code is not good enough.
https://www.hiveworkshop.com/threads/treasure-hunter-system-v1-1-a.247264/post-2483488

 

[nhocklanhox6]

Do not use Integer A/B/C/D/E =.=!...do not use Wait.

• Set digsys_CastingUnit = (Casting unit)

=>

• Set digsys_CastingUnit = Set digsys_CastingUnit = (Triggering unit)

• Set digsys_DiggingPlayer = (Owner of (Casting unit))

=>

• Set digsys_DiggingPlayer = (Triggering player)

• Set digsys_WinChance[((Player number of (Triggering player)) - 1)] = (digsys_WinChanceDefault + (((Level of digsys_DummyAbility for (Learning Hero)) - 1) x digsys_WinChnceBonusONLevelUp))

=>

• Set digsys_WinChance[((Player number of (Triggering player)) - 1)] = (digsys_WinChanceDefault + (((Level of digsys_DummyAbility for (Triggering unit)) - 1) x digsys_WinChnceBonusONLevelUp))

You using random number to digging an item, i think it's not a good idea to do it.

Your floating text on the trigger: DigAbility can be optimize like this:

Example:

• Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • digsys_OnGoodTerrain Equal to True
    • Then - Actions
      • -------- Prints Nothing Found --------
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • digsys_DisplayMessages Equal to True
        • Then - Actions
          • Set SomeText = digsys_FoundNothingString
          • Floating Text - Create floating text that reads digsys_FoundNothingString at digsys_Point with Z offset 0.00, using font size 7.00, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
          • Floating Text - Change (Last created floating text): Disable permanence
          • Floating Text - Change the fading age of (Last created floating text) to digsys_MessageLength seconds
          • Floating Text - Change the lifespan of (Last created floating text) to (digsys_MessageLength + 1.00) seconds
        • Else - Actions
    • Else - Actions
      • -------- Prints bad terrain type --------
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • digsys_DisplayMessages Equal to True
        • Then - Actions
          • Floating Text - Create floating text that reads digsys_BadTerrainTypeString at digsys_Point with Z offset 0.00, using font size 7.00, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
          • Floating Text - Change (Last created floating text): Disable permanence
          • Floating Text - Change the fading age of (Last created floating text) to digsys_MessageLength seconds
          • Floating Text - Change the lifespan of (Last created floating text) to (digsys_MessageLength + 1.00) seconds
        • Else - Actions

=>

• Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • digsys_OnGoodTerrain Equal to True
    • Then - Actions
      • -------- Prints Nothing Found --------
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • digsys_DisplayMessages Equal to True
        • Then - Actions
          • Set SomeText = digsys_FoundNothingString
        • Else - Actions
    • Else - Actions
      • -------- Prints bad terrain type --------
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • digsys_DisplayMessages Equal to True
        • Then - Actions
          • Set SomeText = digsys_BadTerrainTypeString
        • Else - Actions
  • Floating Text - Create floating text that reads SomeText at digsys_Point with Z offset 0.00, using font size 7.00, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
  • Floating Text - Change (Last created floating text): Disable permanence
  • Floating Text - Change the fading age of (Last created floating text) to digsys_MessageLength seconds
  • Floating Text - Change the lifespan of (Last created floating text) to (digsys_MessageLength + 1.00) seconds

 

[Chaosy]

1. use map init as event
2. use the starts effect event
3, remove those 50000 comment lines the ruin the code -.-

 

[Megamax]

@nhocklanhox6
a)No I'm not missing the import instruction; did you dl the map? Its in the map in a comment trigger.
b) Why can't I use integer A?
c) Why Set digsys_CastingUnit=digsysCastingUnit=triggeringunit? Why not just suggest digsys_CastingUnit=triggeringunit?
d) Why shouldn't I use a random number? Thats the whole point of this system
e) Good point, I should optimize the code for floating text

@Chaosy
1) Why? Some triggers don't even work at map init I have read
2) What is the advantage to starts effect event. I've had experience with some abilities where that func didn't work, but starts casting ability always works
3) Why? The comments tell the user important information. If you dislike the comments so much you are more than welcome to remove them yourself if/when you plan to implement my system

 

[nhocklanhox6]

@Megamax.

a: Oh sorry ^^
b: Because it's unsafe and slower than integer variables
c: It's a good habit
d: For example, at that point, you digging an items but you found nothing, and you continue to dig and "surprise", you have digged an items, so it strange, doesn't it?

 

[zv27]

Try this

function CreateText takes unit u, string s, real size, real offset, real speed, real angle, integer red, integer blu, integer gre, integer trans, real life, real fade, boolean show, boolean permanent, boolean suspend returns texttag
    local texttag tt = CreateTextTag()
    local real vel=(speed*.071)/128
    local real xvel=vel*Cos( angle * bj_DEGTORAD )
    local real yvel=vel*Sin( angle * bj_DEGTORAD )

    call SetTextTagText(tt,s,(size*0.023)/10)
    call SetTextTagPos(tt,GetUnitX(u),GetUnitY(u),offset)
    call SetTextTagColor(tt,red,blu,gre,255-trans)
    call SetTextTagVisibility(tt,show)
    call SetTextTagPermanent(tt,permanent)
    call SetTextTagSuspended(tt,suspend)
    call SetTextTagVelocity(tt,xvel,yvel)
    if permanent!=true then
        call SetTextTagLifespan(tt,life)
        call SetTextTagFadepoint(tt,fade)
    endif
    return tt
endfunction

 

[Megamax]

@Megamax.

a: Oh sorry ^^
b: Because it's unsafe and slower than integer variables
c: It's a good habit
d: For example, at that point, you digging an items but you found nothing, and you continue to dig and "surprise", you have digged an items, so it strange, doesn't it?

@nhocklanhox6
b: I can understand maybe slow but why unsafe? Its only unsafe if youre using two (for loop int(a))s at same time
c: You said:

Do not use Integer

• Set digsys_CastingUnit = (Casting unit)

=>

• Set digsys_CastingUnit = Set digsys_CastingUnit = (Triggering unit)

Now I ask again, why is it a good habbit to set digsys_CastingUnit = digsys_CastingUnit? I get sortof where you're coming from with (Triggering Unit) but not self assignment.

d: well it could be possible to make a system where the items are stored at loc(x,y) then if you are within say 100 of loc(x,y) then you have found item.
My dig system is more meant for lets say idk you you have terrain A: Sand. Now you dig in Terrain A. You have a 1/4 chance to dig up something besides just sand. And you may ask why would you find something different next time? Here's why, with each dig its only 1 shovel full of sand. So, it could be viewed as you're digging deeper and deeper into the Earth. Of course I should probably add terrain deformation then, but there's no reason you cannot easily do that yourself. System's are meant to modded afteral.

@zv27
Are you suggesting I make a function for floating text, then call that function when I want to create floating text, rather than putting it at the end of my trigger?

 

[Tank-Commander]

I apologise if anybody else has pointed any of these things out before, just been reading the code and skimming over comments

Remove that game message in the intialisation trigger - it belongs in map specific triggers, not the system triggers itself.

You could also scrap a lot of those IF blocks if you put it into a loop, running the condition each time (Given how GUI handles IF blocks anyway, even if it runs the code a few more times, it'd still be roughly the same efficiency and just a lot more readable, you could also use custom script lines to put in your own loop/exitwhen lines if you wanted to make it particularly efficient) This applies specifically to the IF blocks after this line:

• -------- The following branched if/else statements create the item accourding to terrain type --------

The floating text at the end is displayed even if messages are disabled

 

[BPower]

Take care of everything the Tank-Comamander said. Also don't use IntegerA.

Refreshing concept, I've created a few item drop systems by myself but in jass (thank god)
ItemDrop systems of any kind are fascinating tools. You should consider that items could have different drop chances. First of all you have an absolute drop chance for an item drop i.e 15%.
Then you access the drop pool, where items have a relative chance towards each other.
(uniques, magical, trash, ... shouldn't have the same drop chance value).
Even if they all have the same drop chance it should be configurable (i.e drop weight of 1)
It's not critical for approval, but the system will get a far better rating assumed the code is fine.

 

[Andser]

Nice idea, digging a town hall :3 5/5 and +rep