11:15, 7th Oct 2009
TriggerHappy187:

I'm rejecting this until you update it, since you said you might not even do it.

Why does the GUI version have a point cast while the vJass version has an AOE cast?

• In your init function

  local filterfunc FF = Filter(function DummyFilter)

  is completely useless. Filterfuncs don't leak inside events.
• Your use of locations is useless as well, I mean you could just do

  local real FP2 = RBL(ux, uy,lx,ly)

  directly.
• Also your actions function leaks, you never null berg or tit.
• There is no need to use

  GetSpellTargetLoc()

  since you can just use GetSpellTargetLocX/Y.
• You should make the flying height of the titanic configurable.
• Also in your inject method, you never null your location so it leaks.
• Your timer interval should be configurable (and 0.02 is too small).
• You seem to not be nulling a lot of handles. Basically anything that gets destroyed you need to null, please fix all of these I don't want to point them out individually.

• ATTACK_TYPE_NORMAL,DAMAGE_TYPE_NORMAL

  should be configurable.

• GetUnitState(kb.t,UNIT_STATE_LIFE)

  should be replaced with

  GetWidgetLife(kb.t)

  . Same with any other UnitState calls that refer to life (including SetUnitState).

The_Reborn_Devil:
In "Titanic Loop" you forgot to remove the group "T_Group[T]" in the "Then - Actions" after the "Else - Actions" after the "Then - Actions" at the top

The vJASS version looks good as far as I can see.

Status: Approved
Rating: Recommended

The vJASS version of the spell is approved, but please fix the GUI version
Have a nice day!

 

The spells was remove from hiveworkshop because I forgot to click Saves Spells during the removal of all spells for the compatability of 1.24 patch.

All documentation and faq was inside the map, please read before asking question that are deem to be dumb.

 

who helped you with this btw? cause it's some good coding...

but i actually prefer the timer method which i explained to you, easier to use and understand imo, or hashtables...

great job there =)

 

if you read the faq, i actually haven't done the jass version. what you teach me seems to be vjass.

 

Um, i guess those vjass mistakes are mine, i can explain some of them:

1. Somebody once said i should use filterfunctions and null them acordingly to prevent some leaks, this may be false but i have been told so and i only knew so much at that time.

2.GetSpellTargetLoc() i didn't know about the GetSpellTargetLocX/Y and whether using them is more efficent, so again it could be it was my mistake when i was helping Septimus.

3.GetUnitState(kb.t,UNIT_STATE_LIFE), if you would care to explain why using this is worse than widget life? I see no point currently and if there is a point i think you should say why.

4.Your timer interval should be configurable (and 0.02 is too small). Don't really think 0.02 is small, this is a fast spell, and i doubt running 10 of these will cause any probs but i may be wrong

5.You seem to not be nulling a lot of handles. Basically anything that gets destroyed you need to null, please fix all of these I don't want to point them out individually. Major overlook should be fixed asap :3

6.You should make the flying height of the titanic configurable. It IS check the script a bit better(StartHeight is present, as well as HeightChange factor).

7.ATTACK_TYPE_NORMAL,DAMAGE_TYPE_NORMAL should be configurable. Don't see why but it is really optional, the spell was designed as a physical spell damage :3

8.Why does the GUI version have a point cast while the vJass version has an AOE cast? They both got Point Cast, the only difrence is that you can actualy see the aoe of the damage in the jass version, i think it is a better feature overall

If you could adress these comments of mine also and prove some more feedback cause i helped Septimus a lot on this spell and most of those errors are bound to be mine

 

Submission rules doesn't indicate that it was necessary for us to make the attack type configurable.

I don't think it was essential to have this as a main requirement.

 

@TriggerHappy187

Thanks for the feedback and the constructive critizism ^^

Those mistakes are mostly just overlooks of simple things so i guess Septimus won't have a hard time fixing them


[offtopic]

I love the bioshock avatar man
/want

 

I would try to fix it, but don't give a high hope over me yet./

 

Good job!

Thanks!

 

I disagree with the need for destroying the filter being removed. It saves space as the filter does nothing and is only needed on map initialization, so it is pointless keeping the object alive. Also setting it to a local may be faster due to less native calls.

Anyway, at Septimus's request, I have fixed up most of the problems mentioned as well as done some minor optimizations here and there.
The spell is still a mess really but it should be ok now.

 

thx, i would have it updated as soon as possible.

 

finally able to find a spare time to upload it.

thx dsg.

 

how did you get this number oO?

Code (vJASS):

local real ia = 6.2831853/im

 

pi = 3.1415926535897932384626433832795 (aprox)
2pi = 6.283185307179586476925286766559 (aprox)

Logically 2 pi as a constant should be faster than 2 * the costant for pi.

I guess you can work the rest out.

 

oh thanks for explaining me that..

 

Lol! this is one awesum spell idea gj

 

ouch!! I am absent minded about the GUI version!! Would have it fix soon.