[System] [vJass] Anachron's CustomAura 1.0.0

[Wrda]

You should make more descriptive names rather than thistype.a and thistype.i in CustomAura.

public stub method aliveCond takes nothing returns boolean
    return GetUnitAbilityLevel(.theUnit, .spellId) > 0
endmethod

Use UnitAlive, declare it above globals (where you set PERIOD) with:

native UnitAlive takes unit id returns boolean

Should also comment that users must delete this line if they already have declared it somewhere else, or if they get an error stating duplicated function names.

//: Replaces call GroupAddGroup(.affect, .last)
set bj_groupAddGroupDest = .last
call ForGroup(.affect, function GroupAddGroupEnum)

You can use BlzGroupAddGroupFast instead.

call GroupClear(.affect)
call GroupEnumUnitsInRange(.affect, GetUnitX(.theUnit), GetUnitY(.theUnit), .getRadius(), Condition(function thistype.tryRegister))
call ForGroup(.last, function thistype.tryUnregister)

Condition(function thistype.tryRegister) is a leak, must be cleaned up afterwards.
In CABonus, you should use "elseif" in addBonus method instead of seperate ifs statements.

Auras are stacking by default, perhaps you could add an option for non-stacking, that the highest level takes precedence.
Aura systems are quite hard to do performance wise, so far 4 heroes with devotion aura and holy devotion both with 1500 radius against 40 enemy units hit the fps a bit. Not bad for maps where there's not a lot of units.

 

[Bribe]

Actually JassHelper will automatically nuke duplicate declarations of the same native, so you do not need to worry about that one.

 

[Wrda]

Actually JassHelper will automatically nuke duplicate declarations of the same native, so you do not need to worry about that one.

Hm, is that somewhat recent? I always remember the need to remove it myself before.