Synergy - Fireshield & Sunburst

[Moderator]

18:24, 14th Jun 2009
hvo-busterkomo:

Review

Decent effects (although I'm not sure about the synergy). It's worthy of approval as it is now, but I'd like you to make some improvements.
1. Don't use the gg_trg prefix for local triggers.
2. You should indent your code. It significantly improves readability.
3. You could easily use coordinates instead of locations. In fact, it would improve your OffSetLocation() a lot.
4. There's a lot of BJs you can easilly replace with natives.

 

[Thanathos]

The spells are not really creative but they seem to work, another thing is the fireshield is useless in this map, because the workers won´t attack so you may add some units who will attack.
I diden´t find any leak in the code for now (remarkabel if this is your first spell), but you use some BJ´s so remove them. I also recommend to use gloabals for the rawcode, so the user of your spell dont need to go trough the whole code and check every rawcode is correct. The commets are ok so over all i would say 3.5/5.

 

[Reaper2008]

Alright, did as you said(as much i could) haven't done that rawcode thing yet. Also removed the Reset Cooldowns thingy cause it ruins fireshield somewhy.

 

[Thanathos]

Ok so it might be the easiest way for you to get JNGP it will turn the fontcolor of the BJ`s red so (by the default configuration) you can better find them. Well what i meant by using gloabals for the rawcodes is this:

Example

globals // Using the gloabals block in this way is only possible with JNGP
integer SPELL_ID_A = '1234'
endglobals

function some_func takes nothing returns boolean
return GetSpellAbilityId() == SPELL_ID_A 
endfunction

globals // Using the gloabals block in this way is only possible with JNGP
integer SPELL_ID_B = '4321'
endglobals

If you have questions about JNGP please read the site from the link.

 

[baassee]

lol does JNGP just mean that you can add more stuff and such or isnt it called "vJass"? ^^

sry but I'm not a jasser

 

[Thanathos]

Features of JassNewGenPack:
- Grimoire (1.5)
- JassHelper (0.9.G.1) (This makes you able to use [v]JASS)
- Grim Extension Pack (1.0b)
- PJass (1.0k)
- TESH 0.7.0.3 (Unofficial update by Van Damm and Zoxc)
- Risc's Colorizer FINAL
- UMSWE (5.0)
- Reinventing the Craft (0.20)

I dont really know but PJass could be the compiler/parser for [v]Jass.
So this is what i think, but it also could be wrong

 

[baassee]

wtf is PJass? never heard of it before, usally you use JNGP to make vJass spells

 

[Aspard]

If I'm not mistaken, vJass stands for Vexorian Jass, isn't it? It's kinda a standard. JNPG - just a module for WE to work with jass more easily. JASS spells can be any kinds anyway. (So, it doesn't mean that spells created in JNPG are vJass)

pJass... dunno... pGUI - Paladon's GUI, pJass - ? ;D

 

[Thanathos]

Well as far as i know PJASS is some kind of syntax checker ( or parser or a compiler for vjass… these things are of course very different but for me they are the same^^). Dont kill me if im wrong but i think pjass converts vjass into normal jass so for example it adds all variable in a globals block somwhere in the code to the one on top of the script and creates the struct and so on… But hey wait i think our nice talk is gettin off topic. We should help Reaper with his spell.

 

[baassee]

sry but I never heard about pjass until now

 

[Deuterium]

PJASS? haha that's new to me...

However, about Fire Shiel:
Since when does fire "block" damage?

Well, ideas aren't much of creative ideas... but if altered i guess they would end up real nice

EDIT:

i cant differ on whether how the spells work together work together or not

however, it once bugged and shield stayed on for minutes...

 

[-JonNny]

Hmm long ago that ive seen a Jass spell since i learned vJass
good old times... nah ... if i look at the code they seem not to be that great

your coding is not that bad its mui and leakless
but its quite ugly, not easy to read and not that efficient
e.g. i do not know why you check every half second if the unit got the shield buff to add an ability
also the 13 k location variables you use in your SunBurst can be replaced by a loop

to make things easier to read build in some spaces and some descriptions of important variables (which spell code is needed here ect

heres one example of your code

Hard 2 read

loop
call TriggerSleepAction(0.50)
if UnitHasBuffBJ(j,'B000') == false then
call UnitAddAbility(j,'A001')
endif
set i =  (i + 1)  // Checking every half second, stops when the duration has expired, or unit no longer has the ability.
exitwhen i ==  8 + (8 * GetUnitAbilityLevelSwapped('A003',GetSpellAbilityUnit())) or UnitHasBuffBJ(j,'B002') == true  // To change duration change the integers.
endloop

Easier 2 read

loop
    call TriggerSleepAction(0.50)
    if UnitHasBuffBJ(j,'B000') == false then
        call UnitAddAbility(j,'A001')
    endif
    set i =  (i + 1)  // Checking every half second, stops when the duration has expired, or unit no longer has the ability.
    exitwhen i ==  8 + (8 * GetUnitAbilityLevelSwapped('A003',GetSpellAbilityUnit())) or UnitHasBuffBJ(j,'B002') == true  // To change duration change the integers.
endloop

all in all i must say that they seem to work properly but these arent great idead and it could be done better [3/5]

 

[Reaper2008]

Alright, I'll get to fixing it somewhen this week, or maybe the next, I'm very busy with exams.

EDIT: Found time to do it, updated.

 

[Anachron]

Can you please Post the systems code?

 

[Reaper2008]

It's 3 triggers.

 

[Anachron]

So post them here?^^

 

[Synthax Kisuke]

Good Job! And my name is ther(Synergy)