Strange unit group desync?!

[CoLd Bon3]

Sup, guys! I have a really small problem here. I have a desync in a trigger that doesn't even use local player... It's related to my shop category system (for my map).
Here is the trigger :

Desync trigger

• Shop Cancel
  • Events
    • Unit - A unit Sells a unit
  • Conditions
    • (Unit-type of (Sold unit)) Equal to Cancel
  • Actions
    • Unit - Remove (Sold unit) from the game
    • Set Location = (Position of (Selling unit))
    • Set UnitGroup = (Units within 50.00 of Location matching ((Level of Select Hero [Arrow] for (Matching unit)) Not equal to 0))
    • Custom script: call RemoveLocation(udg_Location)
    • Selection - Select UnitGroup for (Owner of (Buying unit))
    • Custom script: call DestroyGroup(udg_UnitGroup)

The funny thing is that this trigger does not desync :

DesyncLESS trigger

• Shop Cancel
  • Events
    • Unit - A unit Sells a unit
  • Conditions
    • (Unit-type of (Sold unit)) Equal to Cancel
  • Actions
    • Unit - Remove (Sold unit) from the game
    • Set Location = (Position of (Selling unit))
    • Set UnitGroup = (Units within 50.00 of Location matching ((Level of Select Hero [Arrow] for (Matching unit)) Not equal to 0))
    • Custom script: call RemoveLocation(udg_Location)
    • Unit Group - Pick every unit in UnitGroup and do (Actions)
      • Loop - Actions
        • Selection - Select (Picked unit) for (Owner of (Buying unit))
    • Custom script: call DestroyGroup(udg_UnitGroup)

Can someone explain or anything?

 

[EmoBrother]

Try to Select UnitGroup for (owner of (Buying unit)) before you destroy the point variable --- Location and then c it still desync or not o.0

 

[Doomlord]

https://www.hiveworkshop.com/forums.../unit-selection-group-gui-glitch-help-168477/

Seems like a problem with the GUI func for the Select unit group.

 

[Chaosy]

I don't think a unit a building can be selected at the same time?


In this case the unit group contains the selling unit and the buying unit

 

[Dr Super Good]

Are there any triggers that run on unit selection (unit is selected event)?

 

[CoLd Bon3]

@Dr Super Good - nope.

 

[EmoBrother]

@ CoLD Bon3, did you tried my way ?
If it works that way then that means UnitGroup stored the details of Location. If you destroy Location before you select UnitGroup then Location's details break and UnitGroup can't get any detail of Location so it desync.
IF IT WORKS THAT WAY

 

[Doomlord]

@ CoLD Bon3, did you tried my way ?
If it works that way then that means UnitGroup stored the details of Location. If you destroy Location before you select UnitGroup then Location's details break and UnitGroup can't get any detail of Location so it desync.
IF IT WORKS THAT WAY

If the Location is destroyed beforehand, it will simply return the default one (i.e Center of map).

 

[EmoBrother]

If the Location is destroyed beforehand, it will simply return the default one (i.e Center of map).

Oh yeah ? -.- But it hasn't ne nulled.

 

[Doomlord]

Oh yeah ? -.- But it hasn't ne nulled.

What do you mean? If you don't buy it, test it out and see for yourself.

Btw I find your emo and Oh yeah strangely disturbing. Guess it is just me.

 

[CoLd Bon3]

Uhm, guys. I don't think the location is the problem. I mean, the script works perfectly for the player running it. Just.. the others get disconnected. Nevermind, though. I am using the working script anyways.
Thanks a lot with the help!

 

[EmoBrother]

Btw I find your emo and Oh yeah strangely disturbing. Guess it is just me.

The strange person is you, man. You say everything yourself, I didn't said that you're suspicious.
"Oh yeah ?" is my emo when I'm surprised. Everyone can put the icon they desired to let people know their emo. Somebody is crying and he/she put a . What do you think about this ?
I can put "" or "arghhhhh" if you don't like a "Oh yeah ?"
I'm sorry about this if I have let you felt that you're suspected by someone.

 

[Doomlord]

Yeah well. It is alright. I did say that maybe it is just me after all

 

[Dr Super Good]

function SelectGroupForPlayerBJ takes group g,player whichPlayer returns nothing
    if (GetLocalPlayer() == whichPlayer) then
        call ClearSelection()
        call ForGroup( g, function SelectGroupBJEnum )
    endif
endfunction

You lied about the no "GetLocalPlayer" part... Shame on you.

It executes entire series of code for a specific player, no wonder it desyncs. The entire for group is done locally (and is the cause of the problem).

The other does not desynchronize because you execute the for group synchronously for all players.

 

[Doomlord]

Aha. I was correct =))

Btw Doc, can you show me how to see the code for the natives and the BJs like that? Thanks in advance

 

[Imp Midna]

function SelectGroupBJEnum takes nothing returns nothing
    call SelectUnit( GetEnumUnit(), true )
endfunction

So, all it does is clearing the selection and then adding the units to the players selection. Selections are not synced unless you manually sinc them, aren't they? So, how come it desyncs at all? More over, how come a BJ that is not commented to desync anything can do that? The only thing i could imagine is a trigger with a selection event suddenly fireing locally only. I really don't get that desync. Somebody mind explaining?

 

[Dr Super Good]

So, how come it desyncs at all?

Probably something to do with how the game engine processes ForGroup loops which results in game states deviating. A simple explanation could be persistent internal JASS structures that are used during a ForGroup loop which have results that influence the execution of other JASS code. An example could be a change of order in how units are processed by the game so everyone should be A->B->C but someone goes C->A->B which produces different results.

 

[CoLd Bon3]

Thanks, Doc! I am using the other script now and everything is smooth.
Thanks to all of you!
PROBLEM SOLVED!

 

[Zwiebelchen]

I think the problem with the script is that "picked unit" retrieves a different value on different machines after this enumeration locally.

You just need to use "Picked unit" at the wrong place and you will have a desync.