Spell pack version 2.20

[Moderator]

11:50, 24th Jan 2011
The_Reborn_Devil:

My review.


Status: Approved
Rating: Useful

 

[Adiktuz]

just took a quick look at the trigs...
oh, you might want to change those keywords, add more fitting ones, like spellpack etc...

suggestions for now:

-do not use arrays if you'll only use few of the indexes, just use different variables...
-change the timer of the living bomb to at least .03, .01 is too fast...
-and please use self-describing variables names... (don't use something like ilikeanime, etc...)

I haven't looked at all of the codes, or try the spells but basing from those I looked, the triggers seem fine... ^_^

 

[Aradar]

Sorry few of them are... Well I were bored/angry sometimes ill go fix it and the timer I did it to be presice Ill just remove a 0 and make it to 0.10. Also thanks for informing me about that array's fills more than different variables.

 

[Adiktuz]

Sorry few of them are... Well I were bored/angry sometimes ill go fix it and the timer I did it to be presice Ill just remove a 0 and make it to 0.10. Also thanks for informing me about that array's fills more than different variables.

I prefer just .03, its best performance and efficiency-wise, though you might need to be changing the formula for the time reduction... ^_^


anyway, I hope to see more good spells from you. ^_^

 

[matej]

i agree whit all what Adiktuz said.
and about spell pack, its contain a lot of spells and that's nice and trigers locks ok.

 

[Aradar]

Ok and thanks both of you.

 

[Maker]

Some notes

Elden Aura

• Untitled Trigger 001
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
  • Actions
    • -------- We check if the unit casts a ability --------
    • -------- NEEDED STUFF! --------
    • -------- a buff for every level of the spell --------
    • -------- a if then else for every level of the spell --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) has buff Elder Aura ) Equal to True
      • Then - Actions
        • -------- We check if the unit has buff 1 --------
        • Unit - Set mana of (Triggering unit) to ((Percentage mana of (Triggering unit)) + 2.00)%
        • -------- then we set the mana of the unit + 2/3/4% --------
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Triggering unit) has buff Elder Aura ) Equal to True
          • Then - Actions
            • -------- We check if the unit has buff 2 --------
            • Unit - Set mana of (Triggering unit) to ((Percentage mana of (Triggering unit)) + 3.00)%
            • -------- then we set the mana of the unit + 2/3/4% --------
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Triggering unit) has buff Elder Aura ) Equal to True
              • Then - Actions
                • Game - Display to Player Group - Player 1 (Red) the text: 3
                • -------- We check if the unit has buff 3 --------
                • Unit - Set mana of (Triggering unit) to ((Percentage mana of (Triggering unit)) + 4.00)%
                • -------- then we set the mana of the unit + 2/3/4% --------
              • Else - Actions

In Untitled Trigger 003 Copy, you don't remove this:

• Set EW_point = (Position of (Target unit of ability being cast))

Improve the tooltips on Spirit Warden's abilities. Try to make them look more like standard Blizzard abilities.

Rasen Shuiken dummy has food cost.

In trigger copy trigger, you should calculate this outside the loop:

• (75.00 x (Real((Level of (Ability being cast) for (Triggering unit)))))

Dark Portal learn tooltip is missing.

Dark Blast could maybe do with lesser amount of effects.

In Hex Chain, this is comment, not custom scriot:

• -------- call DestroyGroup(udg_hexgroup) --------

Hashy trigger is running all the time. Turn it off when not needed. And there's a leak in there:

• Set Lighning_Unit = (Random unit from (Random 1 units from hexgroup))

Enlarge is also running all the time.

In test trigger, leak:

• Unit - Order (Last created unit) to Neutral - Firebolt (Random unit from (Units within 600.00 of TempLoc matching...

Cookie trigger is running all the time and has unit group leak.

Hits running all the time.

TimeWarp loop trigger is running all the time and causes leaks since the RemoveLocations are at wrong place.

Many other looping triggers are not turned off when the group is empty.

Untitled Trigger 014 has location leak.

Some water elemental triggers are using specific unit, they won't work on other units.

IceExplosion = Effect spam?

In IceExplosion some trigger you change flying height at 1000000. Change it at 0, it's instant.

Sanistraofknees triggers use specific unit.

Battle Charged = Leaks

IceExplosion copy copy -> leaks

I didn't check the rest.

There's some good triggering, but mind the leaks and triggers not being turned off. Improve tooltips.

 

[Aradar]

I've edited a couple of the things, but I cannot seem to find the thing with elder Aura, I also fixed a lot but Sanistraofknees and the water elemental was meant as boss requests that's why I made it like that.

 

[fladdermasken]

Nicely done pal, hoping for approval.

 

[NoMoreChallenge]

Interesting! One of the largest spell packs I ever seen. Testing..........

 

[Maker]

I've edited a couple of the things, but I cannot seem to find the thing with elder Aura, I also fixed a lot but Sanistraofknees and the water elemental was meant as boss requests that's why I made it like that.

You should have the IF/THEN/ELSES inside each other.

Either fix or remove the boss triggers, they are not MUI and therefore the pack can't be approved.

 

[Aradar]

Okay ill remove them, and okay about that if then else.
New version check top for changelog.

 

[Aradar]

Bumpy please comment the new version.

 

[Aradar]

Bump please comment also I added yet another spell.

 

[Adiktuz]

please don't bump every day... +bumping won't move your spell to the top of the default list... just wait for people to comment, a lot of people here don't go online everyday, and its the holiday season so maybe they're out on vacation...

 

[Aradar]

I know that and thanks for telling be about the fact that some people might be on vacation... stupid brain.

 

[Aradar]

Added a new hero to my spell pack hope you enjoy it.

 

[.VTZ.]

N.I.C.E
+Rep
i have a question.
Can i use your hero Magmus into my arena map? (with all spell / name / etc)
with a little modification, the passive spell lauch missiles on cast!
i will give +credits and hero name creator to you.

Let it burn.!!!

 

[Aradar]

Of course you can why should I upload it here if you shouldent be allowed to use you and thanks for credits, and rep.

 

[Devalut]

oooo, a new spellpack, and a youtube video!

sadly Devalut could not be here to relay the rest of the message due to ripping his ears out from the music.

 

[The Reborn Devil]

Moderator review:

An in-game screenshot which displays at least some of the spells would be appreciated. Anyway, you might want to give your triggers proper names and not just variations "Untitled Trigger 001" and "Iceexplosion Copy Copy Copy 3". The triggers themselves look fine though.

 

[Allen Walker 22]

can i request a copy of the models used in the game (if the models are in map pm me) pm me tnx

 

[Aradar]

Sure just rember to credit the maker's as it's not my own models only the spells are my own.

 

[Allen Walker 22]

Thanks

 

[Mallaboro]

Kinda creative, some less than others. I doubt I'll use these in a map, but I can learn from them, and that deserves reputation. Thank you.

 

[reisbro]

just a suggestion, but in the mana bomb spell, you could increase the effect size with time, I mean, it would sound like the mana ball is overcharging, and then it explodes

 

[Ricola3D]

Amazing variety of spells. Some ideas roxx !!
However a few bug (no effect, or cursor invisible when picking targets)