Spin version 1.1

[Moderator]

07:53, 22nd Jul 2012
Magtheridon96: Approved.

THIS IS YOUR REVIEW
http://www.hiveworkshop.com/forums/2187672-post3.html

This spell is very well-written and readable :>
It just needs a few minor enhancements.

 

[-Derp-]

Spell idea inspired by Taking Back Sunday's song 'Spin'.

 

[Magtheridon96]

In JASS, == true is the most useless thing ever because you could remove it and be unaffected ^_^

edit
So much win xD

Tips:

Trigger

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • SPI3 Equal to 1
  • Then - Actions
    • Custom script: call SetLightningColor(udg_SL, 1, 1, 1, 1)
  • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • SPI3 Equal to 2
      • Then - Actions
        • Custom script: call SetLightningColor(udg_SL, 0, 1, 1, 1)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • SPI3 Equal to 3
          • Then - Actions
            • Custom script: call SetLightningColor(udg_SL, 1, 0, 1, 1)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • SPI3 Equal to 4
              • Then - Actions
                • Custom script: call SetLightningColor(udg_SL, 1, 1, 0, 1)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • SPI3 Equal to 5
                  • Then - Actions
                    • Custom script: call SetLightningColor(udg_SL, .75, .75, .75, 1)
                  • Else - Actions

What if I told you,

Spoiler

this could all be optimized to ONE line O: :O O:

(You need 3 arrays to set on map init)

edit
Since I know you're an exceptional GUIer and decent JASS-scripter, I'm going to be a bit stricter here ;D

Since you're using custom scripts, you might as well use coordinates instead of locations
Instead of the target point, use GetSpellTargetX() and GetSpellTargetY().

edit
This also means that CreateUnitAtLoc has got to go. Use CreateUnit.

edit
A better screenshot would be nice :C

 

[Tank-Commander]

Ow, blinding screenshot you have there

 

[-Derp-]

Thanks Magtheridon!

I've updated the screenshot, I'll update the code soon.



Updated, fixed stuff.

 

[iceteaftw]

Can i ask that why everybody always use "channel" ability to make a new ability?

 

[-Derp-]

It's used as the ability doesn't cause any side effects like damage and you can set the ability's stats. i.e. target type