- Joined
- Jul 10, 2007
- Messages
- 6,306
By the way, something that has always annoyed me... you have your arguments backwards.....
vs
Code first, then event >.>.
Because of this, your thing is extremely difficult to work with. Every time I need to change an event from a native or one of mine, I have to flip everything around just for your script... changing back means I have to flip back around. Furthermore, everything (from natives to my stuff) takes bool expressions. Just for your special thing, I have to remove the Condition around it. To go back, I have to add it back in. You have no idea how frustrating it is to work with a script that does not follow the standards set out by JASS natives... I'm thinking about not using your script anymore and just making my own that does follow standards because I am really getting tired of it.
Furthermore, I have to continue to keep reminding myself that your script does not follow the standards and is backwards + takes arguments that are not the norm. A script should make life easier, not give the user headaches like yours does >.>.
In fact, in my maps, I am now making yours a wrapper for my own standard version >.>.
This here makes infinitely more sense
#1, it is in the correct order, so if someone needs to go between natives and yours, they don't have to rewrite everything.
#2, it takes the correct argument types, so if someone needs to go between natives and yours, they don't have to redo the code argument.
Why this was approved in its current state I have no idea, but the API is written poorly.
function RegisterPlayerUnitEvent takes playerunitevent p, code c returns nothing
vs
native TriggerRegisterPlayerUnitEvent takes trigger whichTrigger, player whichPlayer, playerunitevent whichPlayerUnitEvent, boolexpr filter returns event
Code first, then event >.>.
Because of this, your thing is extremely difficult to work with. Every time I need to change an event from a native or one of mine, I have to flip everything around just for your script... changing back means I have to flip back around. Furthermore, everything (from natives to my stuff) takes bool expressions. Just for your special thing, I have to remove the Condition around it. To go back, I have to add it back in. You have no idea how frustrating it is to work with a script that does not follow the standards set out by JASS natives... I'm thinking about not using your script anymore and just making my own that does follow standards because I am really getting tired of it.
Furthermore, I have to continue to keep reminding myself that your script does not follow the standards and is backwards + takes arguments that are not the norm. A script should make life easier, not give the user headaches like yours does >.>.
In fact, in my maps, I am now making yours a wrapper for my own standard version >.>.
This here makes infinitely more sense
function RegisterPlayerUnitEvent takes boolexpr c, playerunitevent p returns nothing
#1, it is in the correct order, so if someone needs to go between natives and yours, they don't have to rewrite everything.
#2, it takes the correct argument types, so if someone needs to go between natives and yours, they don't have to redo the code argument.
Why this was approved in its current state I have no idea, but the API is written poorly.