[Trigger] Simple Efficiency Question About UnitGroups

[BlueBerryWizard]

Is it better to add/remove units to a unitgroup then to create and clear a unitgroup over and over?
Which is more efficient / less laggy?

• Hunger
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Set HungerGroup = (Units in (Playable map area) matching ((((Matching unit) is A Hero) Equal to True) and (((Picked unit) has buff Sound asleep ) Equal to False)))
    • Unit Group - Pick every unit in HungerGroup and do (Actions)
      • Loop - Actions
        • Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 1.00)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Mana of (Picked unit)) Less than or equal to 0.00
          • Then - Actions
            • Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 5.00)
            • If ((Life of (Picked unit)) Less than or equal to 15.00) then do (Cinematic - Ping minimap for (All players matching ((Matching player) Equal to (Owner of (Picked unit)))) at (Position of (Picked unit)) for 1.50 seconds, using a Warning ping of color (100.00%, 30.00%, 20.00%)) else do (Do nothing)
          • Else - Actions
            • Do nothing
    • Custom script: call DestroyGroup(udg_HungerGroup)

Would it be better to just add the units to the "HungerGroup" when they're made (and remove them from the group when they die or are removed by trigger) then to keep making the group and removing it over and over? Also, when you replace a unit would it have to be removed from the unitgroup before it is replaced and re-added after being replaced?

EDIT: I have another question I thought I might as well ask... what function do you use to get the nearest unit within a certain range of a unit? If someone could make an example trigger that would help .

 

[-Berz-]

Your Group variable is seted wrong, its matching unit have a buff
And i don't totally understand your questions, its something if unit dies within that 2 seconds? if so just add when you set the group matching unit is alive equal to false.

 

[Eleandor]

Just create/destroy the group. In GUI, you usually create a group anyway using "units within range".

To check the nearest unit to a point, do:

Set Range(real) = 512 <-- 512 is the distance
Set TempUnits = Units within 512 of a Point
Pick every unit in TempUnits and do actions:
--- Set TempLoc = location of picked unit
--- If Distance between TempLoc and Point < Range then
------- Set NearestUnit = Picked Unit
--- Custom script: call RemoveLocation(udg_TempLoc)
Custom script: call RemoveLocation(udg_Point)
Custom script: call DestroyGroup(udg_TempUnits)
Nearest unit is now the nearest unit.

 

[GhostWolf]

Talking about efficiency when you are using GUI AND using a Do Nothing action is just ironic.

 

[BlueBerryWizard]

Not what I asked .

Your Group variable is seted wrong, its matching unit have a buff
And i don't totally understand your questions, its something if unit dies within that 2 seconds? if so just add when you set the group matching unit is alive equal to false.

No, that's completely off the point. I'm wondering if it would create less lag if you used stuff like

• Woodle
  • Events
  • Conditions
  • Actions
    • Unit Group - Add (Triggering unit) to HungerGroup
    • Unit Group - Remove (Triggering unit) from HungerGroup

instead of

• Woodle
  • Events
  • Conditions
  • Actions
    • Set HungerGroup = (Units in (Playable map area))
    • Custom script: call DestroyGroup(udg_HungerGroup)
• where you set and clear it over and over.

Just create/destroy the group. In GUI, you usually create a group anyway using "units within range".

To check the nearest unit to a point, do:

Set Range(real) = 512 <-- 512 is the distance
Set TempUnits = Units within 512 of a Point
Pick every unit in TempUnits and do actions:
--- Set TempLoc = location of picked unit
--- If Distance between TempLoc and Point < Range then
------- Set NearestUnit = Picked Unit
--- Custom script: call RemoveLocation(udg_TempLoc)
Custom script: call RemoveLocation(udg_Point)
Custom script: call DestroyGroup(udg_TempUnits)
Nearest unit is now the nearest unit.

Also not what I asked, I know how to do that... I was wondering is there was a Jass function that does it simpler? Like you know how when peasents are cutting down trees they always find the nearest trees, I wanted that for a different custom spell that targets the closest unit with a certain custom value and gets the nearest one (and finds another one after that unit is dead)?

 

[neavea]

use add/remove unit.

When you clear an entire group and say this group has 10+ units in it then what it does it manually does the "remove unit action" just repeats it for every unit in the group. So hence its easier to do the add/remove because your doing the same thing xept just once.

 

[spiwn]

Using one unit group without destroying it and just adding the units to it via another trigger(and when necessary removing them) is far more efficient than picking units in playable map area(matching condition .. blah blah).
So this trigger would be just:
Pick all units in temp_unit_group and do actions:
...

Without destroying the group.

 

[Eleandor]

No, that's completely off the point. I'm wondering if it would create less lag if you used stuff like

• Woodle
  • Events
  • Conditions
  • Actions
    • Unit Group - Add (Triggering unit) to HungerGroup
    • Unit Group - Remove (Triggering unit) from HungerGroup

instead of

• Woodle
  • Events
  • Conditions
  • Actions
    • Set HungerGroup = (Units in (Playable map area))
    • Custom script: call DestroyGroup(udg_HungerGroup)
• where you set and clear it over and over.

Also not what I asked, I know how to do that... I was wondering is there was a Jass function that does it simpler? Like you know how when peasents are cutting down trees they always find the nearest trees, I wanted that for a different custom spell that targets the closest unit with a certain custom value and gets the nearest one (and finds another one after that unit is dead)?

Nope. You can write it in jass so it's more efficient, but as you don't seem to know jass, you'll have to go for this trigger. By the way, you asked for a trigger, not a jass script

 

[BlueBerryWizard]

Nope. You can write it in jass so it's more efficient, but as you don't seem to know jass, you'll have to go for this trigger. By the way, you asked for a trigger, not a jass script

Oh... yeah... I meant a jass script. Also, I know enough Jass that I can understand what to do with jass scripts although not write them.

 

[Eleandor]

All right then... Don't know if this works, but here goes nothing:

function GetNearestUnitToLoc takes group g, location l, real dist returns unit
    local group tmp = CreateGroup()
    local real x = GetLocationX(l)
    local real y = GetLocationY(l)
    local real dx
    local real dy
    local unit u
    local unit nearest = null
    local real u_dist
    call GroupAddGroup(g, tmp)
    set dist = dist * dist
    loop
        set u = FirstOfGroup(tmp)
        exitwhen u == null
        call GroupRemoveUnit(tmp, u)
        set dx = GetUnitX(u) - x
        set dy = GetUnitY(u) - y
        set u_dist = (dx * dx + dy * dy)
        if u_dist < dist then
            set nearest = u
            set dist = u_dist
        endif
    endloop
    call DestroyGroup(tmp)
    set tmp = null
    set u = null
    return nearest
endfunction

 

[BlueBerryWizard]

Found a Get Closest Unit Thing

All right then... Don't know if this works, but here goes nothing:

function GetNearestUnitToLoc takes group g, location l, real dist returns unit
    local group tmp = CreateGroup()
    local real x = GetLocationX(l)
    local real y = GetLocationY(l)
    local real dx
    local real dy
    local unit u
    local unit nearest = null
    local real u_dist
    call GroupAddGroup(g, tmp)
    set dist = dist * dist
    loop
        set u = FirstOfGroup(tmp)
        exitwhen u == null
        call GroupRemoveUnit(tmp, u)
        set dx = GetUnitX(u) - x
        set dy = GetUnitY(u) - y
        set u_dist = (dx * dx + dy * dy)
        if u_dist < dist then
            set nearest = u
            set dist = u_dist
        endif
    endloop
    call DestroyGroup(tmp)
    set tmp = null
    set u = null
    return nearest
endfunction

I was searching through the forums when I found this http://www.hiveworkshop.com/forums/f413/getclosestunit-s-59254/ it seems someone else has already made a get closest unit...
Thanks for helping anyways +rep