show Floating text only to players which can view the unit.

[Gekigengar]

i am using a normal usual damage detection floating text.

i want the floating text to be shown only to players which has a view of the units.

such as, player 1 has unit A in view, so he can see floating text when unit A gets damaged,

PLayer 2 has no view, since it is in the fog of war, so he can't see the floating text on the unit. even if he gets damaged.

 

[Dr Super Good]

Use conditional tests on GetLocalPlayer to help filter when the text should be made.

 

[Garfield1337]

• Player Group - Pick every player in (All players) and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Or - Any (Conditions) are true
          • Conditions
            • ((Triggering unit) is fogged to (Picked player)) Equal to True
            • ((Triggering unit) is invisible to (Picked player)) Equal to True
            • ((Triggering unit) is masked to (Picked player)) Equal to True
      • Then - Actions
        • Floating Text - Hide (Last created floating text) for (Player group((Picked player)))
      • Else - Actions

Add this to Damage Detection trigger,after the floating text is created.

 

[Gekigengar]

do player group leak?

i will try make it in loop if it do thx garf. i can't rep you yet, i got to spread more.

EDIT : I made it in loop, and it works perfectly, Thx

 

[Garfield1337]

Player groups/forces do leak as far as i know,but the All Players force/group doesn't.

 

[WaterKnight]

I think he/she meant the force in there:

• Floating Text - Hide (Last created floating text) for (Player group((Picked player)))

And yes, this one creates a fresh force.

• ((Triggering unit) is fogged to (Picked player)) Equal to True
• ((Triggering unit) is invisible to (Picked player)) Equal to True
• ((Triggering unit) is masked to (Picked player)) Equal to True

Doesn't invisible already unite fogged and masked?

 

[Garfield1337]

To prevent leak,use

• Custom script: if GetLocalPlayer() == GetEnumPlayer() then
• Custom script: call SetTextTagVisibility(bj_lastCreatedTextTag,false)
• Custom script: endif

instead of

• Floating Text - Hide (Last created floating text) for (Player group((Picked player)))

And for invisibility,WaterKnight - i wasn't sure so i put all 3 conditions,it won't have any negative effect.

 

[Gekigengar]

thx guys, so, converting player group from index is leaking? allright, i will use that. thx garf.

 

[Dr Super Good]

No, you make a new force and you do not remove it and throw all references away to it. In proper games (SC2) a garbage collector would catch it and remove it for you but in WC3 it will just stick in memory, slowing the game down for certain opperations.

All players returns a constant force (the same force object) and thus it can not leak. Remvoing it will even cause bugs cause all future references to it will return null.

 

[defskull]

You always differentiate between SC and WC >.>

 

[phuc1570]

Take it easy, Simply use this, don't make it complex:

• Floating Text - Hide (Last created floating text) for (All enemies of (Owner of (Triggering unit)))

 

[defskull]

Take it easy, Simply use this, don't make it complex:

• Floating Text - Hide (Last created floating text) for (All enemies of (Owner of (Triggering unit)))

Well, because of your "take it easy, make it simple", congratulations, you have misunderstood the thread
He wanted to make Floating Text ONLY appear to a unit when in vision OR in Sight Radius
He don't want if that the unit is in fogged, the floating text can still be seen
If the unit is in radius sight of the player unit, floating text will be shown
IF you use that condition of yours...
Even if the unit is in sight radius, the floating text won't appear because that unit is your enemy

 

[phuc1570]

Well, it appears to the allies of me & me of course who obviously have the view of the unit. all of my enermies will not have that unit in sight radius because they are my ENERMIES. My condition prevents them to see the floating text even when the enermies get the unit in their sight radius.

If the unit is in fogged, u couldn't see neither the unit nor the floating text. It is reasonable. It is weird if you wanna see the floating text when you cannot view it.

Yaa, but you r right, if using my one, in the solo mode, ur enermy couldn't see it aswell.

 

[Garfield1337]

Also that function leaks a force - (All enemies of (Owner of (Triggering unit)))

 

[defskull]

Player Group, leaks ?
I thought they didn't ?

 

[Gekigengar]

sadly they do...

Player Group
Note: (All Players) does not leak, and destroying it can result in problems
Player Groups leak also, but those are really rare. The fix:

• Player Group
  • Events
  • Unit - A unit Starts the effect of an ability
  • Conditions
  • (Ability being cast) Equal to Some Spell
  • Actions
  • Set PlayerGroup = (All enemies of Player 1 (Red))
  • Player Group - Pick every player in PlayerGroup and do (Do nothing)
  • Custom script: call DestroyForce(udg_PlayerGroup)

anyways no, they haven't misunderstood, it works perfectly just like what i wanted

 

[Dr Super Good]

How could they not leak... Try learning what a leak actually is and all will become clear.

forces, groups, effects, timers, triggers all can leak if you do not use them properly.