Seal of Blessed Light v1.0.2

[Daffa]

I know the map utilized an outdated Damage Engine version (5.4.2.3 iirc) since this is the one with 1.31 patch saved in my disk and I am lazy to follow the guide for adding Damage Engine 5.A for 1.31. As always, the reason is always me and being lazy. I recommend people grabbing from Damage Engine 5.A.0.0 official thread instead of using the one provided from the map, especially for Reforged users.

 

[Pyrogasm]

As always, the reason is always me and being lazy.

Ultimately any resource is going to end up featuring out-of-date code but this is a terrible attitude and reason for it. You have decided to submit it officially, so... polish it and do it right.

 

[Daffa]

Ultimately any resource is going to end up featuring out-of-date code but this is a terrible attitude and reason for it. You have decided to submit it officially, so... polish it and do it right.

Alright alright, I'll do it later

 

[Daffa]

v1.0.1:
- Upgraded Damage Engine in test map from 5.4.2.3 to 5.A.0.0

 

[Wrda]

A simple, yet effective spell to help allies in need.

Approved

 

[Wrda]

I don't know how I missed this, but there's a supposed duplication on Damage Engine:

 

[Daffa]

I don't know how I missed this, but there's a supposed duplication on Damage Engine:
View attachment 456179

Is this tested on Reforged? 1.31 does not have the native so it has to be declared manually. This is why despite providing Damage Engine I still recommend people use the link since the one included in the map had Bribe's recommended modification to allow it running in v1.31 of Warcraft III.

Damage Engine 5.A.0.0 documentation:

Alternatively, adding the below JASS script to the top of the DamageEngine library SHOULD enable it to work too:

function BlzGetEventIsAttack takes nothing returns boolean
     return BlzGetEventDamageType() == DAMAGE_TYPE_NORMAL
endfunction

 

[Wrda]

Is this tested on Reforged? 1.31 does not have the native so it has to be declared manually. This is why despite providing Damage Engine I still recommend people use the link since the one included in the map had Bribe's recommended modification to allow it running in v1.31 of Warcraft III.

Damage Engine 5.A.0.0 documentation:

Tested on latest patch, 1.36. Yeah I missed the part where you specifically said to download from the link.

 

[KaiZen7th]

Hah! Found it. Was looking for it by "Fatal" keyword.

 

[Dinodin]

Cool spell! I'm using it in my map but it seems to be bugged because I changed it's duration of the shield but it seems like it only lasts for 3 seconds for all levels for some reason. Please fix!

 

[Daffa]

Cool spell! I'm using it in my map but it seems to be bugged because I changed it's duration of the shield but it seems like it only lasts for 3 seconds for all levels for some reason. Please fix!
View attachment 470286

I'll investigate the issue first and see what I can do to help fixing it.

 

[Daffa]

I have checked the test map for this spell and this spell works properly on multiple levels. The duration you proposed is very similar in all levels that it is hard to distinguish with naked eyes and requires proper code detection to handle.

 

[Pyrogasm]

I also checked the code and couldn’t find anything wrong with the duration arithmetic, so I concur.

 

[Wrda]

Moved to Awating update as requested by the resource owner.
Short explanation: Clash of a dependency's different versions when imported with other resources of the same owner.