this is my favourite concept of yours that i use for my main in the projects im doing, campaign, melees, moba styles lol so anyways
i need to report some stuff here, me and friend went through some extensive testing on the versus with your concepts
Also Only if anybody is fighting each other (other players) with these concepts.
The Fear System, when fearing a players Hero, still causes player desync or player crashes of either the fearer or the feared.
Samuros' Illusions here also cause the game to crash when they are feared under a player control. To Solve this Issue this needs to put in the fear system ->
if IsUnitType(target, UNIT_TYPE_HERO) and IsIllusion[GetUnitUserData(target)] == false then
Now this however would still cause a problem, cause now its brings the illusions down to the unit fear, which also crashes the game so to fix that i have this after ->
else
if IsIllusion[GetUnitUserData(target)] == true then
call KillUnit(target)
else
call UnitAddAbility(target, FEAR)
call IssueImmediateOrder(target, "bearform")
call UnitRemoveAbility(target, FEAR)
endif
Now fearing the illusions wont crash the game anymore and it is fixed, i have set it to kill, maybe you want Remove instead if you find it giving exp or whatever.
Now the back to main problem of the hero fear, i have removed it from heros currently, as i havent been able to find a way to fix it yet, trying other skills almost works, but the units become targetable after the fear ends, they can only be selected by a drawing a box. it is the the alternate form skills causing the main problem, as it is using metamorphosis, if you fear the demon hunter, the demon hunter will try to transform, he will stay in normal form but get everything the demon form has, ranged attack and everything.
i have tried using avatar instead and thats worse, the hero will end up disappearing, robogoblin is also desync or crash, tried defend, it crashed, berserk they became unselectable/not targetable, various other non alternate form skills, causing unselectable hero after the fear duration ends. so i have a simple deselect replacing the fear hero part of the code until something is figured out lol by one or another.
So aslong as your not fighting any other players (not computers) you will have no issues runs great, but if your gonna battle your friends with these concepts, some changes need to take place and some things need to be looked into.
There is small problem with the Illusions also being counted as hero so in melee versus, getting him first and using illusions, causes your altar to blank out the heros thinking you already have all your heros, as the 'Illusions' are really another of the hero by the DataCode. just a little heads up in a melee versus match with them.
But yea anyways thats all i got to report lol for anybody using in player(s) vs player(s)
I will also continue to look for some way to fix the fear hero, i am sure there is a solution somewhere and yea great concepts love the skills and everything, fairly balanced fighting each other too although i have mixed some up to be related to the heros we are using but yea its great, love them, lets hope somebody can figure out some solution to the fear hero too lol, ill keep trying.
And again only fighting other players does these things matter, you can play with your friend on your team, as long you fight computers there will be no issues.