Question: is this leaked?

[kruzerg]

is this leaked? if leaked, teach me the right things to do

• shd blink
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Treant Hide
  • Actions
    • Unit - Create 1 Dummy for (Owner of (Casting unit)) at (Position of (Casting unit)) facing Default building facing degrees
    • Unit - Add Shadow invi to (Last created unit)
    • Unit - Set level of Shadow invi for (Last created unit) to (Level of Treant Hide for (Casting unit))
    • Unit - Order (Last created unit) to Human Sorceress - Invisibility (Casting unit)
    • Wait 2.00 seconds
    • Unit - Kill (Last created unit)

 

[Wasabee]

You should create a variable for the position of casting units since location leaks
after than you destroy the variable.

• Custom script: call RemoveLocation(udg_loc)

You shouldn't use wait and then kill the dummy unit. You can generate an expiration timer for your dummy unit.

• Unit - Add a 2.00 second Generic expiration timer to (Last created unit)

 

[kruzerg]

if im not use variable, instead i just use:
Unit - Add a 2.00 second Generic expiration timer to (Last created unit)

its already good for my trigger?

and i dont need trigger: Unit - Kill (Last created unit)
anymore?

 

[Wasabee]

if im not use variable, instead i just use:
Unit - Add a 2.00 second Generic expiration timer to (Last created unit)

You should use the variable for the location. Locations leak.

Unit - Add a 2.00 second Generic expiration timer to (Last created unit)

its already good for my trigger?

and i dont need trigger: Unit - Kill (Last created unit)
anymore?

Yes you don't need to use it. The expiration timer removes the dummy unit.

 

[kruzerg]

thanks =) and so here we are

• treanthide
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Treant Hide
  • Actions
    • Set TreantHidePoint = (Position of (Casting unit))
    • Unit - Create 1 Dummy for (Owner of (Casting unit)) at TreantHidePoint facing Default building facing degrees
    • Unit - Add Shadow invi to (Last created unit)
    • Unit - Set level of Shadow invi for (Last created unit) to (Level of Treant Hide for (Casting unit))
    • Unit - Order (Last created unit) to Human Sorceress - Invisibility (Casting unit)
    • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
    • Custom script: call RemoveLocation(udg_TreantHidePoint)

good?

 

[Maker]

That does not leak, but you should use Starts the effect of an ability event. With the current event, you can give Stop order right after casting the ability, the trigger will run but mana cost and coodown will not apply.

 

[kruzerg]

thank you, you good on this thing

 

[Flux]

Btw, for good practice since you're still learning, it is preferable to store Last Created Unit to some variable. Makes the spell runs faster.

• Set dummy = Last Created Unit
• Unit - Add ShadowInvi to dummy
• ...

 

[Wasabee]

Btw, for good practice since you're still learning, it is preferable to store Last Created Unit to some variable. Makes the spell runs faster.

• Set dummy = Last Created Unit
• Unit - Add ShadowInvi to dummy
• ...

I didn't know that you can make your trigger faster with this.

 

[Arad MNK]

I didn't know that you can make your trigger faster with this.

It doesn't matter if you only use (Last created unit/Triggering unit/etc) once, But it matters when Using Multiple Actions with a Unit. (such as here)

So do What Shadow Flux said, kruzerg.

 

[Flux]

I didn't know that you can make your trigger faster with this.

Yes, by a very little amount. It helps controlling OCD.

 

[kruzerg]

okay thanks guys, but i have new trigger
is this right? i want this trigger leakless and remove any units in "any condition"
i worried if the dummy stuck on map, and more stuck can caused fatal error (too many units)

or i must making variable region and making :
Set flaregroup = (Units in (Playable map area))
and the customscript: Custom script: call DestroyGroup( udg_flaregroup )


this is my current trigger:

• wrathdummy1
  • Events
    • Time - Every 61.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Unit-type of (Picked unit)) Equal to Central explosion
            • (Unit-type of (Picked unit)) Equal to Flare Star Segment.
            • (Unit-type of (Picked unit)) Equal to Flare Summoner
            • (Unit-type of (Picked unit)) Equal to Flare.
            • (Unit-type of (Picked unit)) Equal to invisible Flare.
          • Then - Actions
            • Unit - Remove (Picked unit) from the game
          • Else - Actions

 

[Maker]

You need to destroy the group:
http://www.hiveworkshop.com/forums/general-mapping-tutorials-278/complete-list-things-leak-126761/

Use Or - multiple conditions. Now you are requiring a unit to be five different unit types at the same time.

 

[Flux]

^What exactly will that trigger achieve?
And there is a leak,

• (Units in (Playable Map Area))

creates a group but it is not destroyed.
And as Maker pointed, use OR.

http://www.hiveworkshop.com/forums/...quick-tutorial-common-triggering-tips-190802/
http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

 

[kruzerg]

this?

• wrathdummy1
  • Events
    • Time - Every 61.00 seconds of game time
  • Conditions
  • Actions
    • Set flaregroup = (Units in (Playable map area))
    • Unit Group - Pick every unit in flaregroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Unit-type of (Picked unit)) Equal to Central explosion
                • (Unit-type of (Picked unit)) Equal to Flare Star Segment.
                • (Unit-type of (Picked unit)) Equal to Flare Summoner
                • (Unit-type of (Picked unit)) Equal to Flare.
                • (Unit-type of (Picked unit)) Equal to invisible Flare.
          • Then - Actions
            • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup( udg_flaregroup )
          • Else - Actions

 

[Flux]

Almost, put the custom script outside if condition.

 

[kruzerg]

• wrathdummy1
  • Events
    • Time - Every 61.00 seconds of game time
  • Conditions
  • Actions
    • Set flaregroup = (Units in (Playable map area))
    • Unit Group - Pick every unit in flaregroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Unit-type of (Picked unit)) Equal to Central explosion
                • (Unit-type of (Picked unit)) Equal to Flare Star Segment.
                • (Unit-type of (Picked unit)) Equal to Flare Summoner
                • (Unit-type of (Picked unit)) Equal to Flare.
                • (Unit-type of (Picked unit)) Equal to invisible Flare.
          • Then - Actions
            • Unit - Remove (Picked unit) from the game
          • Else - Actions
    • Custom script: call DestroyGroup( udg_flaregroup )

 

[Wasabee]

The units in playable map area still leak because of the location.

 

[kruzerg]

• wrathdummy1
  • Events
    • Time - Every 61.00 seconds of game time
  • Conditions
  • Actions
    • Set flarepoint = (Playable map area)
    • Set flaregroup = (Units in flarepoint)
    • Unit Group - Pick every unit in flaregroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Unit-type of (Picked unit)) Equal to Central explosion
                • (Unit-type of (Picked unit)) Equal to Flare Star Segment.
                • (Unit-type of (Picked unit)) Equal to Flare Summoner
                • (Unit-type of (Picked unit)) Equal to Flare.
                • (Unit-type of (Picked unit)) Equal to invisible Flare.
          • Then - Actions
            • Unit - Remove (Picked unit) from the game
          • Else - Actions
    • Custom script: call DestroyGroup( udg_flaregroup )

and this is my trigger of my pick hero after i learn few things about leak here it is

• hero pick
  • Events
    • Unit - A unit Sells a unit
  • Conditions
    • ((Sold unit) is A Hero) Equal to True
  • Actions
    • Set Wisp = Nephalem Soul
    • Set wisp1 = (Buying unit)
    • Set WispGroup = (Units owned by (Owner of (Sold unit)))
    • Set REGION1 = (Center of Region 001 <gen>)
    • Unit Group - Pick every unit in WispGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Unit-type of (Sold unit)) Equal to Paladin
                • (Unit-type of (Sold unit)) Equal to Cleric
                • (Unit-type of (Sold unit)) Equal to Berserker
                • (Unit-type of (Sold unit)) Equal to Void Lord
                • (Unit-type of (Sold unit)) Equal to Necromancer
                • (Unit-type of (Sold unit)) Equal to Faceless King
                • (Unit-type of (Sold unit)) Equal to Magic Walker
                • (Unit-type of (Sold unit)) Equal to Sky Magician
                • (Unit-type of (Sold unit)) Equal to Scar Ancient
                • (Unit-type of (Sold unit)) Equal to Agile Assassin
                • (Unit-type of (Sold unit)) Equal to Crypt Guardian
          • Then - Actions
            • Unit - Add a 1.00 second Generic expiration timer to wisp1
            • Unit - Move (Sold unit) instantly to REGION1
            • Camera - Pan camera for (Owner of (Sold unit)) to REGION1 over 0.40 seconds
            • Special Effect - Create a special effect at REGION1 using Abilities\Spells\Other\Awaken\Awaken.mdl
            • Special Effect - Destroy (Last created special effect)
          • Else - Actions
    • Custom script: call RemoveLocation (udg_REGION1)
    • Custom script: call DestroyGroup(udg_WispGroup)

 

[Flux]

No no, the Playable Map Area is a constant, it doesn't leak. Your previous trigger is already leakless.

 

[kruzerg]

ohh thanks shadow =)
btw my hero pick trigger already ok?

 

[Flux]

I'm not sure.
Why use unit groups? And why do you have those long list of condition?

In terms of leak, there is none.

 

[kruzerg]

thanks, the unit group for add hero to the group for condition

i read sound have leak too
and my trigger:
play - sound
set volume last played sound to 100%
destroy last played sound
then after that my sound doesnt play
so i cant do without being leak?

 

[Flux]

You don't need the Unit Group since you didn't use Picked Unit
Don't destroy Sounds created at Sound Editor

 

[kruzerg]

then my sound leak?

the unit group not affected or making lag my game right sir?

 

[Flux]

If you created Sound via Trigger and don't need that Sound anymore, then yes your Sound leaks. If you detroyed a sound, you can't play it anymore so don't destroy it, especially Sound Created at Sound Editor. Bottomline is, destroy sounds that you will no longer play.

I said you don't need the unit group because you directly refer to the Sold Unit and not the Picked Unit.
After defining REGION1, your next code should be the If-Condition. Unit group was unnecessary.

 

[kruzerg]

thank you very much sir for the lesson