Problem with Script: Get Killing Unit

[Marshmalo]

Hi, I'm trying to get the game to play a sound specificaly for a player, I need it to play for the owner of the killing unit, im using costum script as directed but its not working.
The map tells me ive made an error and turns the trigger off :/
Here is my Trigger:

Gileneas is Conquered

• Events
  • Unit - King of Gilneas 0256 <gen> Dies
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Owner of (Killing unit)) Equal to Player 1 (Red)
        • (Owner of (Killing unit)) Equal to Player 4 (Purple)
        • (Owner of (Killing unit)) Equal to Player 5 (Yellow)
        • (Owner of (Killing unit)) Equal to Player 10 (Light Blue)
  • Actions
    • Trigger - Turn off (This trigger)
    • Wait 5.00 seconds
    • Custom script: if GetLocalPlayer() == GetOwningPlayer(GetKilling()) then
    • Sound - Play QuestCompleted <gen>
    • Custom script: endif
    • Unit - Remove (Triggering unit) from the game

pls help

 

[Bannar]

Use GetKillingUnit() instead of GetKilling().

 

[Pharaoh_]

GetKilling() ----> GetKillingUnit().
If you want to use wait, you had better store the Killing unit into a variable and refer to it as:

• Set Unit = (Killing unit)
• Custom script: if GetLocalPlayer() == GetOwningPlayer(udg_Unit) then
• Custom script: endif

Edit: Erm, late. :]

 

[Dr Super Good]

The reason for the error is because you have a JASS syntax error (the script makes no sense to the interpreter).

The native you want...

constant native GetKillingUnit takes nothing returns unit

Correct line of script...

if GetLocalPlayer() == GetOwningPlayer(GetKillingUnit()) then

 

[Marshmalo]

Thank you for the quick replies, I can't say I'm having any more luck with this, I tried your trigger Pharoh but I'm still getting an error, is there anyone wrong with this still?

• Gileneas is Conquered
• Gileneas is Conquered
  • Events
    • Unit - King of Gilneas 0256 <gen> Dies
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Owner of (Killing unit)) Equal to Player 1 (Red)
        • (Owner of (Killing unit)) Equal to Player 4 (Purple)
        • (Owner of (Killing unit)) Equal to Player 5 (Yellow)
        • (Owner of (Killing unit)) Equal to Player 10 (Light Blue)
  • Actions
    • Trigger - Turn off (This trigger)
    • Set killingunit = (Killing unit)
    • Wait 5.00 seconds
    • Custom script: if GetLocalPlayer() == GetOwningPlayer(udg_Killingunit) then
    • Sound - Play QuestCompleted <gen>
    • Custom script: endif
    • Unit - Remove (Triggering unit) from the game

 

[Bannar]

• Gileneas is Conquered
  • Events
    • Unit - King of Gilneas 0256 <gen> Dies
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Owner of (Killing unit)) Equal to Player 1 (Red)
        • (Owner of (Killing unit)) Equal to Player 4 (Purple)
        • (Owner of (Killing unit)) Equal to Player 5 (Yellow)
        • (Owner of (Killing unit)) Equal to Player 10 (Light Blue)
  • Actions
    • Trigger - Turn off (This trigger)
    • Set killingunit = (Killing unit)
    • Wait 5.00 seconds
    • Custom script: if GetLocalPlayer() == GetOwningPlayer(udg_killingunit) then
    • Sound - Play QuestCompleted <gen>
    • Custom script: endif
    • Unit - Remove (Triggering unit) from the game

Jass is key-sensitive, so if your variable is named 'killingunit' you have to consider writing it's exact name: 'udg_killingunit', not 'udg_Killingunit'.

 

[Marshmalo]

Awsome thanks guys its working now!