Pristimatic Shift v1.4

[Moderator]

Pristimatic Shift v1.3 | Reviewed by Maker | 28th May 2013

APPROVED

The ability is MUI and leakless with good tooltip The dummy has build ability, uses upgrades and gives vision Use a knockback system or improve your knockback for smoother effect Add importing instructions into the map You spam special effects

[tr]

 

[deathismyfriend]

can u plz show the triggers.

Edit: just looked at the triggers. this is not MUI. You dont de-index anything.
In my tutorial there is a chapter on indexing u should take a look at it. http://www.hiveworkshop.com/forums/tutorial-submission-283/things-gui-user-should-know-233242/

 

[Maker]

Set the dummy to Can't raise, does not decay
Remove the And from the main condition

 

[Adiktuz]

is this TLII inspired? I believe there's a spell for the embermage that does this exactly and has the same name if I remember correctly...

 

[Pr0blemBro]

is this TLII inspired? I believe there's a spell for the embermage that does this exactly and has the same name if I remember correctly...

Ahaha yes lol :3

You dont de-index anything.

Done

 

[UndeadImmortal]

Attacked Unit --> Triggering Unit.

 

[xorkatoss]

Attacked Unit --> Triggering Unit.

It's "Attacking Unit" not Attacked Unit, therefore Triggering Unit won't work.

 

[Adiktuz]

@xorkatoss: actually, he have some attacked unit used

• ((Attacked unit) has buff Prismatic Rift ) Equal to True
• ((Attacked unit) is an illusion) Equal to False

triggering unit is better, its faster and safer...

your deindexing isn't good yet... you need to learn how to do dynamic index recycling... because right now you would still loop thru the unused indexes (at least up to the boolean check at top)... with dynamic index recycling, you won't do that...

Also, three different variables are better than the array for MUI[1,2,3]... arrays take more memory and is slower than variables... since you only used three indexes for the MUI array, its better to just use three different variables...

 

[deathismyfriend]

Again check out my indexing chapter in my tutorial. It will show u how to properly index / de_index. http://www.hiveworkshop.com/forums/tutorial-submission-283/things-gui-user-should-know-233242/

u can also get rid of this

• Set Knockback_MUI[1] = (Knockback_MUI[1] + 1)

and this

• Set Knockback_MUI[1] = (Knockback_MUI[1] - 1)

u never use it

 

[xorkatoss]

u can also get rid of this

• Set Knockback_MUI[1] = (Knockback_MUI[1] + 1)

and this

• Set Knockback_MUI[1] = (Knockback_MUI[1] - 1)

u never use it

what are you talking about? the Knockback_MUI[1] variable is used for the de-index...

 

[deathismyfriend]

its not used for anything atm look at how he does it. yes it reduces but he never de-indexes anything until all instances are over. He doesnt need it if he de-indexes the proper way. Also looping through all of the unused indexing is a waste of processing, and very inefficient. You should only need one integer to do ur indexing. The one u use in the loop should be a tempInt rather than making another unneeded variable.

 

[Pr0blemBro]

A Wise man once told me,

In theory
MUI2 = 0 is faster
cause if you do MUI2 = MUI1
first it looks for MUI1
finds that it's 0 and then does the MUI2 = 0
so MUI 2 = 0 is instant
MUI 2 = MUI 1 = Get MUI 1 Integer then MUI 2 = 0
probably not even 0.01 seconds faster
but it's faster!

So I believe him

 

[Adiktuz]

Read deathismyfriends tutorial or try to find Hanky's Recycling Index template...

Using the Dynamic recycling indexing method makes your system more efficient because it avoids your system to loop thru already unused indexes, and allows already unused indexes to be reused right away...

Your current method still loops thru all indexes, checks if its used then performs actions. Then you only free up the indexes once the count reaches 0... These two makes the system not good...

Also, as I said, multiple variables are better to use than an array with just 2 or 3 used indexes because arrays are slower than single variables.

 

[deathismyfriend]

as Adiktuz said the way u do it is really inefficient. The way ur doing it now also has a higher chance at hitting the op-limit and breaking the trigger. You should learn how to index properly. My tutorial can help with that a lot as it shows u exactly how to index / de-index and what each line of code is used for.

 

[deathismyfriend]

i fixed this one for ya its in my pastebin just click the link in the message i sent u.

 

[Pr0blemBro]

^yea thnx

 

[deathismyfriend]

np lol

 

[Losam]

Good afternoon,

Your triggers should not employ a system of identification of damage?

 

[FUJI]

Pristimatic Shift v1.3
This spell had been reviewed by jakeZinchttp://www.hiveworkshop.com/forums/members/jakezinc/#visitor_messaging

The triggering looks good and short.

• Set tempPoint1 = (Position of (Triggering unit))
• Set tempPoint2 = (Position of (Attacking unit))

Store triggering unit and attacking unit to a unit variable. Use TriggeringPlayer instead of GetOwningPlayer() in here:

• Unit - Create 1 Dummy for (Owner of (Triggering unit)) at tempPoint1 facing Default building facing degrees

.

• Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
• Unit - Order (Last created unit) to Human Mountain King - Storm Bolt (Attacking unit)

store the last created unit in the variable because you use it many times. Other than that none.

There's no any documentation in the trigger :////

There's no configuration, the user can harm the code, put the values in the another trigger "configuration".

It is MUI and leakless.

None.

There's no importing instruction

The special effects are spammed and it is lacking.

Useful knockbacking the attacking enemies.

The dummy unit must have 0.00 collision size and has a flying movement type. The dummy must have a low sight of radius because it gives high sight. The dummy unit must not have a locust ability and can't attack enemy units. Don't give ability to the dummy units, add it on the trigger. The dummy must not have a build ability.

Tooltip is very good!.

Rejected: 1-10
Unacceptable : 11-30
Lacking : 31-49
Useful : 50-69
Recommended : 70-90
Highly Recommended : 91-100
Director Cut : 101-105

1) Triggering - 17/20
2) Documentation - 0/10
3) Importing Instruction - 0/10
4) Special Effects - 6/15
5) Usefulness - 16/20
6) Tooltip - 9/10
7) Configuration - 0/10

Total Score - 48/105
jakeZinc Rating - 2.1/5
Status - Lacking

 

[GywGod133]

ahaha UPDATED