[GUI] Essence Shift / Revivable Hero

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

11:18, 14th Jun 2014
BPower:
Please use one of the existing damage detection systems from our database. Like Timer systems DDSs are complex and require a decent knowledge. Please also don't feel encouraged to design your own, we have enough of them.

 

[gorillabull]

very nice and useful resource

 

[LordDz]

Triggers have leaks, you should fix those.

 

[Daffa]

• Trigger - Add to Essence Shift Take Damage <gen> the event (Unit - (Entering unit) Takes damage)

This causes event leak.
Unit doesn't get deindexed from triggers when they dies.
Use DDS instead (preferably Bribe's)

 

[deathismyfriend]

Your triggers are also inefficient.
Anything used twice or more should be stored into a variable and the variable should be used.
Also never use entering unit or attacked unit. Use triggering unit instead.
In your ITEs don't use (Do nothing). Use a comment if you have to. Do nothing slows down the trigger. It is inefficient.

This is a good system but I think it needs added functionality.

*It should have the ability to revive hero units at a different interval.
**The interval should be able to include unit type / based on stats / based on level.

*It would be nice if it could revive units also.

*You need to have a lot more configurables.

*Almost all configurables should be in map init trigger.

*The periodic trigger should run every 0.03 seconds not every 0.1
**The time should be able to be changed easily since you use it in the ITEs below think about making it into a configurable variable.

*As said above a DDS would be very good with this. (Although it should be noted that any can be used. Daffa was just recommending one he likes.)
**I prefer the one made by looking for help. It is called Physical damage detection. It detects damage based on code / physical / spell.

 

[enterprise]

How to make the DDS?please give me the example for it.

 

[gorillabull]

you dont make a dds silly you simply use one of the existing dds http://www.hiveworkshop.com/forums/...e-v2-2-1-0-a-201016/?prev=d=list&r=20&u=bribe

 

[enterprise]

you dont make a dds silly you simply use one of the existing dds http://www.hiveworkshop.com/forums/...e-v2-2-1-0-a-201016/?prev=d=list&r=20&u=bribe

I dont know how to make dds in this example, but I see that it may be made by these actions. it's true or not?

DDS?

• Custom script: function CreateDmgEv takes nothing returns nothing
• Custom script: set udg_DamageEventTrigger = CreateTrigger()
• Custom script: call TriggerAddCondition(udg_DamageEventTrigger, Filter(function OnDmgEv))
• Custom script: endfunction
• Custom script:
• Custom script: function SetupDmgEv takes nothing returns boolean
• Custom script: local integer pdex = udg_UDex
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • UnitIndexEvent Equal to 1.00
  • Then - Actions
    • Set TempUnit = UDexUnits[UDex]
    • Custom script: if GetUnitAbilityLevel(udg_TempUnit, 'Aloc') == 0 and DmgEvFilter() then
    • Set UnitDamageRegistered[UDex] = True
    • Trigger - Add to DamageEventTrigger the event (Unit - TempUnit Takes damage)
    • Custom script: endif
  • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • UnitDamageRegistered[UDex] Equal to True
      • Then - Actions
        • Set UnitDamageRegistered[UDex] = False
        • Set DamageEventsWasted = (DamageEventsWasted + 1)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DamageEventsWasted Equal to 15
          • Then - Actions
            • Set DamageEventsWasted = 0
            • Custom script: call DestroyTrigger(udg_DamageEventTrigger)
            • Custom script: call CreateDmgEv()
            • Set UDex = UDexNext[0]
            • Custom script: loop
            • Custom script: exitwhen udg_UDex == 0
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • UnitDamageRegistered[UDex] Equal to True
              • Then - Actions
                • Trigger - Add to DamageEventTrigger the event (Unit - UDexUnits[UDex] Takes damage)
              • Else - Actions
            • Set UDex = UDexNext[UDex]
            • Custom script: endloop
            • Custom script: set udg_UDex = pdex
          • Else - Actions
      • Else - Actions
• Custom script: return false
• Custom script: endfunction
• Custom script:
• Custom script: function InitDamageEvent takes nothing returns nothing
• Custom script: call CreateDmgEv()
• Custom script: call TriggerAddCondition(GetTriggeringTrigger(), Filter(function SetupDmgEv))
• Set UnitIndexerEnabled = False
• Custom script: set udg_TempUnit = CreateUnit(Player(15), 'uloc', 0, 0, 0)
• Set UnitIndexerEnabled = True
• Unit - Add DamageBlockingAbility to TempUnit
• Unit - Remove TempUnit from the game
• Countdown Timer - Start DmgEvTimer as a One-shot timer that will expire in 0.00 seconds
• Trigger - Run (This trigger) (checking conditions)

 

[deathismyfriend]

Use this when posting triggers. http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/
The way you have the above is very hard to read.
Also as said above you do not making a new DDS.
Look for one of the DDSs in the spell section and use the one you want.
They have documentation on how to use them.

 

[Daffa]

What DIMF said.
You use an existing DDS, either Bribe's or Looking for help's DDS.
Then you only need to follow the document and implement it properly.

There's no need to make a new DDS.