Pet/Companion system 1.4

[Moderator]

Pet/Companion system 1.4 | Reviewed by Maker | 01.01.14 [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] Pets are a cool addition and are fittinng in a lot of maps Triggers[/COLOR]] The system has required options like insta teleport. It is also MUI There is a Issued order if/then/else in the AI loop. There is no Issued order Same thing in AI Attack back The looping trigger could be initially off and turned off when the group is empty You could load pets for each master in the looping trigger. Not master for each pet Rating[/COLOR]] CONCEPT TRIGGERS RATING STATUS APPROVED

Old reviews Pet/Companion system 1.4 | Reviewed by Maker | 15th Feb 2013 NEEDS FIX You leak in AI loop, if the order is null. Don't overwrite hashtable data If taking friendly fire, the pets are ordered to attack the source I think you should only order the pets of the damaged unit to attack, and not attack friendlies The pets move around too much It would be nice to be able to order the pets to hold position [tr] Pet/Companion system 1.3 | Reviewed by Maker | 1st Jun 2013 NEEDS FIX You leak a unit group when you order a unit to attack random unit The random unit can be null and the attack order still given from group You overwrite locations in the hashtable and thus leak in AI loop In Functions you store a loc into the hashtable but remove it right away Take actions that you are going to do anyway out of if/then/else AI Attack back doesn't need to use an array for the locations [tr] Pet/Companion system 1.2 | Reviewed by Maker | 28th May 2013 NEEDS FIX In Functions, remove locations if they are stored in the hashtable before flushing the table In Functions you store a loc into the hashtable but remove it right away If the pet dies, data related to it stays in the hashtable -> leaks You are overwriting locations in the hashtable in the looping trigger Your trigger names are too generic You order the pet to attack targets it might not be able to attack Take actions that you are going to do anyway out of if/then/else [tr]

 

[Pr0blemBro]

 

[Maker]

• You have <enemy of Player 1> in there -> the system is not MUI
• Don't order the unit to attack each unit in the group, only one unit

 

[Chaosy]

@maker
my bad got it requested for single player.
will fix it tomarrow

 

[Almia]

Non-constant global variables shouldn't be lower-cased,ItShouldBeLikeThis.
Group filters shall be done inside the group enumeration,for readabilty increase.
The "Functions" Trigger should be written in the map header. Not in GUI,it doesn't look good.
Use a Unit Indexer to get rid of hashtable limits.
GetEnumUnit() > cache this.
in the AI group, integer h should be done after setting the PickedUnit var.

 

[Chaosy]

@almia
did not know that
It reduces readability in my opinion that is why I used it.
so I should convert the trigger to jass?
I can not use unit indexers, then I can not read my own code
will do
ok

 

[Maker]

The "Functions" Trigger should be written in the map header. Not in GUI,it doesn't look good.

I prefer not using the map header, the current way is better. In no way "should" the trigger be written in map header

Use a Unit Indexer to get rid of hashtable limits.

Hashtable is ok here.

 

[Almia]

^ You are right.

I suggested it because the trigger is some how not initialized and trigger has snippets.

 

[Chaosy]

updated.
1. The code will not order the unit to attack if he allready is issued to attack something
2. The unitgroup no longer checks for enemy of player red

 

[Maker]

You could still terminate the loop if the unit is ordered to attack. You can try Custom script : return or pick a single random unit from the fltered group.

 

[Chaosy]

updated!
1. location stored in hashtable is now removed before flushing
2. the location is no longer removed in the function trigger
3. the AI now check if the ordered target is alive before attacking
4. changed trigger names

 

[deathismyfriend]

can u plz post the triggers ?

 

[Chaosy]

I have?

 

[Xonok]

So basically this system is a framework to make units have basic AI? As I get it they aren't really told to use abilities, but just follow and attack.

 

[deathismyfriend]

I have?

i meant on here u posted the map. i cant dl the map atm. plus its easier to look at the triggers rather than dl a map.

 

[Chaosy]

Xonok the point is to make multi controlling easier. This is better if you got one hero and a few normal units. If you want it to work.with many heroes then just switch the pet owner when you select a unit

Death they are posted

 

[Maker]

Why are the footmen running around like headless chicken all the time in the map? It does not help to test the system. I'll have to edit the test setup myself.

 

[Chaosy]

Now that is odd will look into that.
Also how do I check if unit isnt equal no null? Dont you need a jass ife block for that?

 

[Doomlord]

Now that is odd will look into that.
Also how do I check if unit isnt equal no null? Dont you need a jass ife block for that?

Actually you can check if the unit is not equal to No unit

 

[Chaosy]

LOL how stupid of me thanks doom

 

[Doomlord]

No problem. You are welcome

 

[Chaosy]

"
-You leak a unit group when you order a unit to attack random unit
The random unit can be null and the attack order still given
from group
-You overwrite locations in the hashtable and thus leak in AI loop
-In Functions you store a loc into the hashtable but remove it right away"

1. fixed
2. I think I fixed it
3. fixed

will try to fix the footman issue before updating tho

EDIT: I found nothing wrong with the movement of the footmans

 

[Maker]

You still have the unit group leak when ordering to attack random unit.

Don't do this

If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions Then - Actions Custom script: call RemoveLocation(udg_t_loc) Custom script: call RemoveLocation(udg_t_loc_3) Else - Actions If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions Then - Actions Custom script: call RemoveLocation(udg_t_loc) Custom script: call RemoveLocation(udg_t_loc_3) Else - Actions Custom script: call RemoveLocation(udg_t_loc) Custom script: call RemoveLocation(udg_t_loc_3)

Do this

If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions Then - Actions Else - Actions If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions Then - Actions Else - Actions Custom script: call RemoveLocation(udg_t_loc) Custom script: call RemoveLocation(udg_t_loc_3)

In my opinion the footmen don't have to move around that often, they block my way all the time.

 

[Chaosy]

@stuff needed to be fixed
I will do that.

@movement
then you just slow down the loop trigger?

 

[Chaosy]

call Thread.Revive(GetBestThread);

 

[Malhorne]

You revived To The Bitter End thread.
Srsly why bump?

 

[IcemanBo]

Hello I really think this is a cool idea for a system. Havent seen it before... but now, so I ve tested it.
________________

When my soldier attacked my hero(on purpose), it ended in chaos and all tryed to kill each other
Same if one of them attacks another one.. maybe you could do they all only attack the attacking unit, but that they all kill each other is strange.

Then I attacked an enemy.. I aimed the closest enemy there was, my soliders were following me.
Then they recognized a new enemy and so they all decided to leave my hero alone and attacked the new enemy (which was a bit far away :s)

This one ...

Hidden

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Distance between t_loc and t_loc_2) <= 50.00
  • Then - Actions
    • Set t_loc_2 = (t_loc_3 offset by (Random real number between 1.00 and AI_move[AI_mode]) towards (Random real number between 1.00 and 360.00) degrees)
    • Custom script: call RemoveLocation(LoadLocationHandle(udg_AI_hash, h, 1))
    • Custom script: call SaveLocationHandle(udg_AI_hash, h, 1, udg_t_loc_2)
    • Unit - Order t_unit to Bewegen nach t_loc_2
    • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Current order of t_unit) == (Order(<Empty String>))
        • Then - Actions
          • Set t_loc_2 = (t_loc_3 offset by (Random real number between 1.00 and AI_move[AI_mode]) towards (Random real number between 1.00 and 360.00) degrees)
          • Custom script: call RemoveLocation(LoadLocationHandle(udg_AI_hash, h, 1))
          • Custom script: call SaveLocationHandle(udg_AI_hash, h, 1, udg_t_loc_2)
          • Unit - Order t_unit to Bewegen nach t_loc_2
        • Else - Actions

Could be shorted to this, or I'm wrong?

Hidden

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Or - Conditions
      • (Distance between t_loc and t_loc_2) <= 50.00
      • (Current order of t_unit) == (Order(<Empty String>))
  • Then - Actions
    • Set t_loc_2 = (t_loc_3 offset by (Random real number between 1.00 and AI_move[AI_mode]) towards (Random real number between 1.00 and 360.00) degrees)
    • Custom script: call RemoveLocation(LoadLocationHandle(udg_AI_hash, h, 1))
    • Custom script: call SaveLocationHandle(udg_AI_hash, h, 1, udg_t_loc_2)
    • Unit - Order t_unit to Bewegen nach t_loc_2
    • Else - Actions

Also in your "Companion Enable AI Target" trigger you make a same line in Then and in Else actions, you can set the...

• Custom script: call SaveBoolean(udg_AI_hash, h, 6, udg_AI_check_target)

behind the ITE block.
________________

Greetings... I defintly think this can be very useful.

 

[Chaosy]

You revived To The Bitter End thread.
Srsly why bump?

because I updated it.

@ice
I will look into this in a second

and I think youre right. I will do that.

edit:
I thought I had fixed that issue before but now it's fixed. I actually made a pretty big mistake in the attack back trigger.

 

[Malhorne]

Ah sorry I didn't understand sorry :'(

I'm leaving the thread for the moment and I'll try to review to apologize

 

[Maker]

-AI Clear hash leak could call AiRemove
-To me it would make more sence to loop through every master and then for each master, loop through pets

 

[Chaosy]

1. will do
2. I don't see the benefit out of that. it will not shorten the code/use less actions. I dont see how it could give the system benefits either.

 

[Maker]

If the master has six pets, you load the same master unit six times from the hashtable, and get the location six times during every loop.

 

[Chaosy]

sorry for a very late reply. Then I would need to re-work almost the whole system :-/ I don't think I want to do that.
oh well I fixed a few minior flaws, updated.

 

[IcemanBo]

good you made minor fixes, but you really also should should change the other part, by time

quote by confucius:

If you make a mistake and do not correct it, this is called a mistake.

 

[Chaosy]

that might indeed be true.

The thing is maker have done like 6 reviews on this system and now he wants me to remake the whole shit that will make 6 more reviews after I have remaked it.

not makers fault but it's not really a big inspiration

 

[TheRazul]

Is this system MPI as well?