-
Are you planning to upload your awesome spell or system to Hive? Please review the rules here.
-
🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!
-
It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!
New Bonus [vJASS][LUA]
- Author(s)
- chopinski
- Size
- 539.97 KB
- Rating
- Downloads
- 823
- Created
- Apr 15, 2020
- Updated
- Jan 1, 2023
- Resources
- 2
- State
Approved
This bundle is marked as recommended. It works and satisfies the submission rules.
Intro
How to Import?
(v2.2)
For a quick import of the abilities use the editor Object Data.
For those with problems to open the map because of Reforged 1.32 patch, please see this
Hello, this is my first submission in the spell section, so apologies in advance for any mistake. I present to you the New Bonus System. Since Object Merger stopped working and we still have no ways to edit the bonus values of a unit natively, I decided to create this light weight system to manage that and give everyone a simpler way to work with bonus values than the Bonus Mod.
How it works?By using the new Object API introduced to Warcraft, we can now modify an unit ability field value, so when giving an unit a bonus, we add a specific ability to that unit that gives such bonus, if it do not have it already, and change that ability field bonus value to the desired value. Retrieving the amount is also trivial, by just reading that field value.
How to Import?
Importing New Bonus is really simple. Just copy the 9 abilities with the prefix "NewBonus" from the Object Editor into your map [Raw Codes Z001 to Z009 in demo map] and match their new raw code to the bonus types in the global block of the library. You can also define their raw code when pasting to be Z001 to Z009, that's why I created them with this raw codes. Then create a trigger called NewBonus, convert it to custom text, delete all text in it and paste the Library code there. That's it, you are done!
RequirementsNewBonus requires patch 1.31+ and RegisterPlayerUnitEvent Library. NewBonus Extended also Requires DamageInterface, CooldownReduction and Tenacity libraries.
vJASS:
function GetUnitBonus takes unit u, integer bonus_type returns real
-> Returns the specified bonus amount for the unit
-> Example: set amount = GetUnitBonus(GetTriggerUnit(), BONUS_AGILITY)
function SetUnitBonus takes unit u, integer bonus_type, real amount returns real
-> Set the specified bonus type to amount for the unit
-> Example: call SetUnitBonus(GetTriggerUnit(), BONUS_DAMAGE, 100)
function RemoveUnitBonus takes unit u, integer bonus_type returns nothing
-> Removes the Specified bonus type from unit
-> Example: call RemoveUnitBonus(GetTriggerUnit(), BONUS_AGILITY)
function AddUnitBonus takes unit u, integer bonus_type, real amount returns real
-> Add the specified amount for the specified bonus tyte for unit
-> Example: call AddUnitBonus(GetTriggerUnit(), BONUS_DAMAGE, 100)
function AddUnitBonusTimed takes unit u, integer bonus_type, real amount, real duration returns nothing
-> Add the specified amount for the specified bonus type for unit for a duration
-> Example: call AddUnitBonusTimed(GetTriggerUnit(), BONUS_ARMOR, 13, 10.5)
function LinkBonusToBuff takes unit u, integer bonus_type, real amount, integer buffId returns nothing
-> Links the bonus amount specified to a buff or ability. As long as the unit has the buff or
-> the ability represented by the parameter buffId the bonus is not removed.
-> Example: call LinkBonusToBuff(GetTriggerUnit(), BONUS_ARMOR, 10, 'B000')
function LinkBonusToItem takes unit u, integer bonus_type, real amount, item i returns nothing
-> Links the bonus amount specified to an item. As long as the unit has that item the bonus is not removed.
-> Note that it will work for items with the same id, because it takes as parameter the item object.
-> Example: call LinkBonusToItem(GetManipulatingUnit(), BONUS_ARMOR, 10, GetManipulatedItem())
function UnitCopyBonuses takes unit source, unit target returns nothing
-> Copy the source unit bonuses using the Add functionality to the target unit
-> Example: call UnitCopyBonuses(GetTriggerUnit(), GetSummonedUnit())
function UnitMirrorBonuses takes unit source, unit target returns nothing
-> Copy the source unit bonuses using the Set functionality to the target unit
-> Example: call UnitMirrorBonuses(GetTriggerUnit(), GetSummonedUnit())
function RegisterBonusEvent takes code c returns nothing
-> Register code to run when any unit bonus is modified
-> Example: RegisterBonusEvent(function YourFunction)
function RegisterBonusTypeEvent takes integer bonus, code c returns nothing
-> Register code to run when a specific unit bonus is modified
-> Example: RegisterBonusTypeEvent(BONUS_DAMAGE, function YourFunction)
function GetBonusUnit takes nothing returns unit
-> Call this function to get the bonus event unit
function GetBonusType takes nothing returns integer
-> Call this function to get the bonus event type
function SetBonusType takes integer bonus returns nothing
-> Call this function to set the bonus event type
function GetBonusAmount takes nothing returns real
-> Call this function to get the bonus event amount
function SetBonusAmount takes real amount returns nothing
-> Call this function to set the bonus event amount
Lua:
function GetUnitBonus(unit, type)
-> Returns the specified bonus amount for the unit
-> Example: set amount = GetUnitBonus(GetTriggerUnit(), BONUS_AGILITY)
function SetUnitBonus(unit, type, value)
-> Set the specified bonus type to amount for the unit
-> Example: call SetUnitBonus(GetTriggerUnit(), BONUS_DAMAGE, 100)
function RemoveUnitBonus(unit, type)
-> Removes the Specified bonus type from unit
-> Example: call RemoveUnitBonus(GetTriggerUnit(), BONUS_AGILITY)
function AddUnitBonus(unit, type, value)
-> Add the specified amount for the specified bonus tyte for unit
-> Example: call AddUnitBonus(GetTriggerUnit(), BONUS_DAMAGE, 100)
function AddUnitBonusTimed(unit, type, amount, duration)
-> Add the specified amount for the specified bonus type for unit for a duration
-> Example: call AddUnitBonusTimed(GetTriggerUnit(), BONUS_ARMOR, 13, 10.5)
function LinkBonusToBuff(unit, type, amount, buff)
-> Links the bonus amount specified to a buff or ability. As long as the unit has the buff or
-> the ability represented by the parameter buffId the bonus is not removed.
-> Example: call LinkBonusToBuff(GetTriggerUnit(), BONUS_ARMOR, 10, 'B000')
function LinkBonusToItem(unit, type, amount, item)
-> Links the bonus amount specified to an item. As long as the unit has that item the bonus is not removed.
-> Note that it will work for items with the same id, because it takes as parameter the item object.
-> Example: call LinkBonusToItem(GetManipulatingUnit(), BONUS_ARMOR, 10, GetManipulatedItem())
function UnitCopyBonuses(source, target)
-> Copy the source unit bonuses using the Add functionality to the target unit
-> Example: call UnitCopyBonuses(GetTriggerUnit(), GetSummonedUnit())
function UnitMirrorBonuses(source, target)
-> Copy the source unit bonuses using the Set functionality to the target unit
-> Example: call UnitMirrorBonuses(GetTriggerUnit(), GetSummonedUnit())
function RegisterBonusEvent(code)
-> Register code to run when any unit bonus is modified
-> Example: RegisterBonusEvent(function() YourFunctionc end)
function RegisterBonusTypeEvent(type, code)
-> Register code to run when a specific unit bonus is modified
-> Example: RegisterBonusTypeEvent(BONUS_DAMAGE, function() YourFunction end)
function GetBonusUnit()
-> Call this function to get the bonus event unit
function GetBonusType()
-> Call this function to get the bonus event type
function SetBonusType(type)
-> Call this function to set the bonus event type
function GetBonusAmount()
-> Call this function to get the bonus event amount
function SetBonusAmount(real)
-> Call this function to set the bonus event amount- BONUS_DAMAGE
- BONUS_ARMOR
- BONUS_AGILITY
- BONUS_STRENGTH
- BONUS_INTELLIGENCE
- BONUS_HEALTH
- BONUS_MANA
- BONUS_MOVEMENT_SPEED
- BONUS_SIGHT_RANGE
- Real Value Bonusses
- BONUS_HEALTH_REGEN
- BONUS_MANA_REGEN
- BONUS_ATTACK_SPEED
- BONUS_MAGIC_RESISTANCE
- BONUS_EVASION_CHANCE
- BONUS_CRITICAL_CHANCE
- BONUS_CRITICAL_DAMAGE
- BONUS_LIFE_STEAL
- BONUS_DAMAGE
- BONUS_ARMOR
- BONUS_AGILITY
- BONUS_STRENGTH
- BONUS_INTELLIGENCE
- BONUS_HEALTH
- BONUS_MANA
- BONUS_MOVEMENT_SPEED
- BONUS_SIGHT_RANGE
- Real Value Bonusses
- BONUS_HEALTH_REGEN
- BONUS_MANA_REGEN
- BONUS_ATTACK_SPEED
- BONUS_MAGIC_RESISTANCE
- BONUS_EVASION_CHANCE
- BONUS_MISS_CHANCE
- BONUS_CRITICAL_CHANCE
- BONUS_CRITICAL_DAMAGE
- BONUS_SPELL_POWER_FLAT
- BONUS_SPELL_POWER_PERCENT
- BONUS_LIFE_STEAL
- BONUS_SPELL_VAMP
- BONUS_COOLDOWN_REDUCTION
- BONUS_COOLDOWN_REDUCTION_FLAT
- BONUS_COOLDOWN_OFFSET
- BONUS_TENACITY
- BONUS_TENACITY_FLAT
- BONUS_TENACITY_OFFSET
(v1.0)
- Submission
(v1.1)
- Updated the code to use BlzSetUnitMaxHP() and BlzSetUnitMaxMana() in order to make Bonus_Health and Bonus_Mana work properly.
(v1.2)
- Implemented the ability to link a bonus amount to a buff or ability as per requested by @The_Silent . Refactored the code and added a new example of this new functionality in the test map.
(v1.3)
- FIxed a bug on AddUnitBonusExTimed()
(v1.4)
- Normalized the AMOUNT input parameter to Integer instead of real to fix a type conversion problem when converting real to integer for abilities which field value is a integer value.
(v1.5)
- Updated the system to respect integer fields bounds when adding to existing bonus (max 2147483647 and min -2147483648).
- It's still the users job to pass the correct amount, the system will only handle addtions and subtractions that overflow/underflow.
(v1.6)
- Split NewBonus into 2 libraries
- NewBonus contains the core system to set / remove / add bonus types
- NewBonusUtils contains extra functionalities such as timed and linked bonuses
- Redesigned timed and linked bonuses to improve performance.
- New utility functions AddUnitBonusTimed(), LinkBonusToBuff(), LinkBonusToItem()
- Renamed Constans to upper case to be more visible.
- Updated test map: included examples for the 3 new utility functions.
(v1.7)
- Fixed a bug when Adding Health/Mana bonus not keeping the unit Health/Mana Percentage
- Added the funcitons: They manipuilate real bonuses values correctly.
- GetUnitBonusReal()
- SetUnitBonusReal()
- RemoveUnitBonusReal()
- AddUnitBonusReal()
- Refactored the LinkBonusToItem() to use the On Drop event instead of a periodic timer to check the link
- Included an Expanded version of NewBonus and NewBonusUtils that take advangtage of the Damage Inteface System and Cooldown Reduction System
- Renamed 4 bonus types for better readability.
- Removed the "Ex" from the end of the API functions
(v1.8)
- 2 new bonus types:
- Sight Range
- Magic Resistence (real)
- 2 new functionalities in the NewBonusUtils (See API for usage): Thx to SinisterLuffy for the idea
function UnitCopyBonuses takes unit source, unit target returns nothingfunction UnitMirrorBonuses takes unit source, unit target returns nothing
(v1.9)
- Correction of a minor spelling error.
(v2.0)
- Fixed a minor syntax error for the non extended Utils library
(v2.1)
- System ported to LUA
- 4 new bonus types for the non-Extended version of the system
- Evasion Chance
- Critical Strike Chance
- Critical Strike Damage
- Life Steal
- Removed the functions GetUnitBonusReal, SetUnitBonusReal, AddUnitBonusReal and RemoveUnitBonusReal
- Now the functions GetUnitBonus, SetUnitBonus, AddUnitBonus and RemoveUnitBonus handles both real and integer bonus types correctly
- Fix a minor bug in the NewBonusUtils Library
- Support for Bonus Events!!
- Merged the normal and extended version into one library. (You can control which version is enabled by setting the new EXTENDED constant in the global section)
- Code Cleaning and formatting.
- Fixed a bug in bonus event evaluation
- 3 new bonus types included from the new Tenacity system
- BONUS_TENACITY,
- BONUS_TENACITY_FLAT
- BONUS_TENACITY_OFFSET
For a quick import of the abilities use the editor Object Data.
For those with problems to open the map because of Reforged 1.32 patch, please see this
Contents
Reviews
Spell Reviewer
- Joined
- Nov 18, 2012
- Messages
- 1,888
Chopinski uses his own "damage engine" called DamageInterface. You need to have that script file for LifeSteal to work.
- Joined
- Aug 6, 2015
- Messages
- 637
The problem is that i get this bug when i put both systems together.
Attachments
Spell Reviewer
- Joined
- Nov 18, 2012
- Messages
- 1,888
Looks like Jasshelper is pointing to the wrong line. I checked the script and I can't find s_Damage_get_source function anywhere in this resource. Disable Bribe's damage engine and every trigger that uses it and tell me if you still have the same error.
Spell Reviewer
- Joined
- Nov 18, 2012
- Messages
- 1,888
DamageInterface trigger had the struct name "Damage2" while everywhere else was using "Damage", which is the struct name of Bribe's damage engine. I replaced all Chopinski's triggers named "Damage" with "DamageInterface" besides the "Damage2" one. It has no errors now.
- Joined
- Aug 6, 2015
- Messages
- 637
Thank you!
- Joined
- Feb 8, 2015
- Messages
- 681
Hello there.
SetUnitBonus(u,BONUS_HEALTH) is bugged. When repeated on the same unit the previous bonus is kept and the new one stacks on top of it, so it works like an add instead of a set.
Latest Warcraft 3 version at this day.
SetUnitBonus(u,BONUS_HEALTH) is bugged. When repeated on the same unit the previous bonus is kept and the new one stacks on top of it, so it works like an add instead of a set.
Latest Warcraft 3 version at this day.
- Joined
- Aug 6, 2015
- Messages
- 637
Encountered a bug : When dropping and picking up an item with 3 strength (with 12.50 hp per STR gain - in game constants) - the hero will get permanent additional health.
