New Bonus [vJASS][LUA]

[Aldeia]

So , i encountered another problem , i am trying to use these functions too:

But i get such an error. (i am also using Bribe's damage engine) - and i am not sure what i need to do to fix this.

---

 

[Wrda]

Chopinski uses his own "damage engine" called DamageInterface. You need to have that script file for LifeSteal to work.

 

[Aldeia]

Chopinski uses his own "damage engine" called DamageInterface. You need to have that script file for LifeSteal to work.

The problem is that i get this bug when i put both systems together.

 

[Wrda]

Well I do, in the screenshot above, the Damage Interface is present.

Looks like Jasshelper is pointing to the wrong line. I checked the script and I can't find s_Damage_get_source function anywhere in this resource. Disable Bribe's damage engine and every trigger that uses it and tell me if you still have the same error.

 

[Aldeia]

I attached the map with both systems in it. (for some reason after closing the editor and then opening it again now gives a different error)

 

[Wrda]

DamageInterface trigger had the struct name "Damage2" while everywhere else was using "Damage", which is the struct name of Bribe's damage engine. I replaced all Chopinski's triggers named "Damage" with "DamageInterface" besides the "Damage2" one. It has no errors now.

 

[Aldeia]

DamageInterface trigger had the struct name "Damage2" while everywhere else was using "Damage", which is the struct name of Bribe's damage engine. I replaced all Chopinski's triggers named "Damage" with "DamageInterface" besides the "Damage2" one. It has no errors now.

Thank you!

 

[FlameofChange]

Hello there.
SetUnitBonus(u,BONUS_HEALTH) is bugged. When repeated on the same unit the previous bonus is kept and the new one stacks on top of it, so it works like an add instead of a set.
Latest Warcraft 3 version at this day.

 

[Aldeia]

Encountered a bug : When dropping and picking up an item with 3 strength (with 12.50 hp per STR gain - in game constants) - the hero will get permanent additional health.

https://imgur.com/AuC0C2Z

 

[P3in]

What a strange bug, lol

Encountered a bug : When dropping and picking up an item with 3 strength (with 12.50 hp per STR gain - in game constants) - the hero will get permanent additional health.

https://imgur.com/AuC0C2Z

Also, does this has a tutorial to use in more situations?
Or how to use the cooldown reduction / crowd control ?

 

[Uncle]

Encountered a bug : When dropping and picking up an item with 3 strength (with 12.50 hp per STR gain - in game constants) - the hero will get permanent additional health.

Looks like a rounding error, 37.50 rounds up to 38, thus adding more hp. Maybe you could account for it in your own math.

 

[Tasyen]

Or how to use the cooldown reduction / crowd control ?

you set the values for cooldown reduction and the system updates the cooldown of casted abilities automatic on a SPELL_EFFECT events.
Crowd control mods only works for crowd control applied over this system's functions for this feature.

 

[P3in]

Yeah, i want to change my crowd control into these triggers, so i am in fully control of the actions, but how do i call the functions ?
This interferes with bribe's knockback system so i removed bribe's one and kept crowd control.

 

[Tasyen]

Copy the 14 buffs and 15 abilities with the CC prefix and match their raw code below.
you need to copy/create the skills and buffs of crowd control and make sure they have the rawCode expected by the crowd System. or change the constants ids to match the rawCodes in your map:

]
 // The raw code of the silence ability
private constant integer SILENCE    = 'U000'
// The raw code of the stun ability
private constant integer STUN       = 'U001'
// The raw code of the attack slow ability
private constant integer ATTACK_SLOW= 'U002'
// The raw code of the movement slow ability
private constant integer MOVEMENT_SLOW      = 'U003'
// The raw code of the banish ability
private constant integer BANISH     = 'U004'
// The raw code of the ensnare ability
private constant integer ENSNARE    = 'U005'
// The raw code of the purge ability
private constant integer PURGE      = 'U006'
// The raw code of the hex ability
private constant integer HEX= 'U007'
// The raw code of the sleep ability
private constant integer SLEEP      = 'U008'
// The raw code of the cyclone ability
private constant integer CYCLONE    = 'U009'
// The raw code of the entangle ability
private constant integer ENTANGLE   = 'U010'
// The raw code of the disarm ability
private constant integer DISARM     = 'U011'
// The raw code of the fear ability
private constant integer FEAR       = 'U012'
// The raw code of the taunt ability
private constant integer TAUNT      = 'U013'
// The raw code of the true sight ability
private constant integer TRUE_SIGHT = 'U014'
// The raw code of the silence buff
private constant integer SILENCE_BUFF       = 'BU00'
// The raw code of the stun buff
private constant integer STUN_BUFF  = 'BU01'
// The raw code of the attack slow buff
private constant integer ATTACK_SLOW_BUFF   = 'BU02'
// The raw code of the movement slow buff
private constant integer MOVEMENT_SLOW_BUFF = 'BU03'
// The raw code of the banish buff
private constant integer BANISH_BUFF= 'BU04'
// The raw code of the ensnare buff
private constant integer ENSNARE_BUFF       = 'BU05'
// The raw code of the purge buff
private constant integer PURGE_BUFF = 'BU06'
// The raw code of the hex buff
private constant integer HEX_BUFF   = 'BU07'
// The raw code of the sleep buff
private constant integer SLEEP_BUFF = 'BU08'
// The raw code of the cyclone buff
private constant integer CYCLONE_BUFF       = 'BU09'
// The raw code of the entangle buff
private constant integer ENTANGLE_BUFF      = 'BU10'
// The raw code of the disarm buff
private constant integer DISARM_BUFF= 'BU11'
// The raw code of the fear buff
private constant integer FEAR_BUFF  = 'BU12'
// The raw code of the taunt buff
private constant integer TAUNT_BUFF = 'BU13'

seems like this are the orders which tell the base abilities. so you can just create them in your map and dont need to swap around.

]
set order[CROWD_CONTROL_SILENCE] = "drunkenhaze"
set order[CROWD_CONTROL_STUN] = "thunderbolt"
set order[CROWD_CONTROL_SLOW] = "cripple"
set order[CROWD_CONTROL_SLOW_ATTACK] = "cripple"
set order[CROWD_CONTROL_BANISH] = "banish"
set order[CROWD_CONTROL_ENSNARE] = "ensnare"
set order[CROWD_CONTROL_PURGE] = "purge"
set order[CROWD_CONTROL_HEX] = "hex"
set order[CROWD_CONTROL_SLEEP] = "sleep"
set order[CROWD_CONTROL_CYCLONE] = "cyclone"
set order[CROWD_CONTROL_ENTANGLE] = "entanglingroots"
set order[CROWD_CONTROL_DISARM] = "drunkenhaze"

When you have the abilities
you can in trigger editor use the api functions to apply an cc.
call DisarmUnit(unit target, real duration, string model, string point, boolean stack)
call SilenceUnit(unit target, real duration, string model, string point, boolean stack)

example
call DisarmUnit(udg_Unit, 5, "", "", false)

no idea, why disarm would stack?

 

[P3in]

Thanks mate, this is very helpful.
Yeah, i've already imported and everything is good, i just wanted to know how can i make use of them, since it has more options like life steals/spell vamp/spell power etc and tenacity which works only with crowd control spells from the system.

 

[thatkyle]

Very useful for RPG map.

 

[P3in]

I notice a strange behaviour, the stats work fine for all players except neutral hostile, if i give them items using the bonus, it will double the bonus that the item has, for ex, if the item has 50 str, the unit will receive 100 str, anyone encountered this?

 

[kokon]

Can I set negative mana regen?
it seems that i can't.

UPD: It works fine! But one problem is that if regen is 0 and bonus is 0.5 then it will regen 1.0 per second

 

[P3in]

@chopinski or @Tasyen do you have any idea why items stats made with this system, gives double amount if the items are used on neutral hostile? Is there any fix to that or shall i make the enemy into a player and it will work fine?

 

[kokon]

Could be nice to have a chance to miss bonus (not a chance to evade)
Omg it is there?

• BONUS_MISS_CHANCE
  
  
  
• if amount > 0 and not (neverMiss[Damage.source.id] > 0) then
  set evade = GetRandomReal(0, 100) <= evasion[Damage.target.id] or GetRandomReal(0, 100) <= miss[Damage.source.id]
  if evade then
  set source = Damage.source
  set target = Damage.target
  set damage = amount
  call TriggerEvaluate(trigger)
  call BlzSetEventDamage(0)
  call BlzSetEventWeaponType(WEAPON_TYPE_WHOKNOWS)
  call text(source.unit, "miss", 1.5, 255, 0, 0, 255)
  set damage = 0
  set source = 0
  set target = 0
  endif
  endif
  
  it just sets damage to 0 if i understand correctly

 

[kokon]

Can you add miss chance via curse?...
This is not a real miss chance here...

 

[Uncle]

Can you add miss chance via curse?...
This is not a real miss chance here...

That would require that a Dummy unit casts Curse on the target which involves a Buff that can be dispelled/transferred. I don't think that's in the same spirit of the system which is meant to add passive stats, but maybe I'm wrong.

Anyway, if you need this effect in your map then you can just trigger it yourself:

• Unit - Create 1 Dummy...
• Set Variable MyDummy = (Last created unit)
• Set Variable MyTarget = (Some unit to curse)
• Set Variable MyAmount = (Some value between 0.00 and 1.00) // You could get this from NewBonus's stat value
• Unit - Add Curse (Dummy) to MyDummy
• Ability - Set Miss Chance for Curse (Dummy) at Level: 0 to value MyAmount
• Unit - Order MyDummy to Undead - Curse MyTarget

Now you're also hoping that the target isn't spell immune or that it doesn't have spell block.

 

[Barade]

It would be nice to have more ability specific bonuses. For example, increase the number of summoned units for certain abilities only like:

call AddUnitBonusAbilityIntegerLevelField(whichUnit, ABILITY_ILF_SUMMONED_UNIT_COUNT_HWE2, 'A000', 5)

This would allow some kind of enchanting/inscription systems which improve the effect of abilities without changing the ability level.
However, it would only work for certain fields due to limitations for certain fields by Blizzard.

 

[kokon]

• 
  Unit - Create 1 Dummy...
• 
  Set Variable MyDummy = (Last created unit)
• 
  Set Variable MyTarget = (Some unit to curse)
• 
  Set Variable MyAmount = (Some value between 0.00 and 1.00) // You could get this from NewBonus's stat value
• 
  Unit - Add Curse (Dummy) to MyDummy
• 
  Ability - Set Miss Chance for Curse (Dummy) at Level: 0 to value MyAmount
• 
  Unit - Order MyDummy to Undead - Curse MyTarget

Can i transkate it into jass somehow? From your notation?

 

[Uncle]

Can i transkate it into jass somehow? From your notation?

You can convert GUI triggers into code form (Edit -> Convert to Custom Text).

But why are you using Jass if you don't know how to write any yourself?

Maybe you're not using the proper tools, it's very easy with the correct setup:

vjass support extension for Visual Studio Code

# Abstract I made an extension for the coders who wants to use jass or vjass on the Visual Studio Code. The latest version of this extension is 0.1.0, I've made a lot of coooool features of this extension. Enjoy the extension. If you find any bugs or you have any questions of this extension...

www.hiveworkshop.com

 

[kokon]

You can convert GUI triggers into code form (Edit -> Convert to Custom Text).

But why are you using Jass if you don't know how to write any yourself?

Maybe you're not using the proper tools, it's very easy with the correct setup:

vjass support extension for Visual Studio Code

# Abstract I made an extension for the coders who wants to use jass or vjass on the Visual Studio Code. The latest version of this extension is 0.1.0, I've made a lot of coooool features of this extension. Enjoy the extension. If you find any bugs or you have any questions of this extension...

www.hiveworkshop.com

I just wanted to copypaste your code without writing myself )

 

[itayush]

The system in the test map works so smoothly and perfectly, as if it's part of the game engine.

I downloaded this for my own educational purposes, and I am still working on understanding what every single line does and how it works together, but this is just awesome.

EDIT:
While reviewing the Lua code (I am a beginner in Lua language), I noticed a few things and I wonder if anyone encountered issues because of it.

1. In the file "RegisterPlayerUnitEvent", inside the function RegisterPlayerUnitEvent:
   

   function RegisterPlayerUnitEvent(playerunitevent, code)
           if type(code) == "function" then
               local i = GetHandleId(playerunitevent)
           
               if not trigger[i] then
                   trigger[i] = CreateTrigger()
               
                   for j = 0, bj_MAX_PLAYERS do
                       TriggerRegisterPlayerUnitEvent(trigger[i], Player(j), playerunitevent, null)
                   end
               end
           
               if not n[i] then n[i] = 1 end
               if not f[i] then f[i] = {} end
               table.insert(f[i], code)
           
               TriggerAddCondition(trigger[i], Filter(function()
                   f[i][n[i]]()
                   n[i] = n[i] + 1
                   if n[i] > #f[i] then n[i] = 1 end
               end))
           end
       end

   null here throws a warning of "undefined global null". Was this forgotten to be changed to nil during the conversion from Jass to Lua? I saw this in about 20 places in the entire Lua version of this. Should I simply replace any null to nil in the entire system?
2. The same function above is using GetHandleId in the line "local i = GetHandleId(playerunitevent)"; Based on the Lua guide I read, it mentions that the function GetHandleId causes desyncs, and in Lua is not required anyway. Should I adjust the code to simply work with the playerunitevent directly and delete the GetHandleId native?
   E.g
   

   local i = GetHandleId(playerunitevent) -- Remove this line
   local i = playerunitevent -- Add this line instead (or simply use "playerunitevent" variable instead)

   I saw the usage of GetHandleId in multiple places. If the solution is what I wrote above, I will do that for the rest of the code.
3. Under Utilities file (inside Utilities folder), inside the function "UnitDamageGroup":
   

   function UnitDamageGroup(unit, group, damage, attacktype, damagetype, effect, attach, destroy)
           for i = 0, BlzGroupGetSize(group) - 1 do
               local u = BlzGroupUnitAt(group, i)
               UnitDamageTarget(unit, u, damage, true, false, attacktype, damagetype, nil)
   
               if effect and attach then
                   DestroyEffect(AddSpecialEffectTarget(effect, u, attach))
               end
           end
   
           if destroy then
               DestroyGroup(group)
           end
   
           return group
       end

   nil throws the warning: "Cannot assign nil to parameter weapontype. Type nil cannot match `weapontype` Lua Diagnostics.(param-type-mismatch)"
   Should the nil be replaced to "WEAPON_TYPE_WHOKNOWS"? I checked how the native "UnitDamageTargetBJ" is using "UnitDamageTarget".
4. Under Utilities file, inside the function "CreateChainLightning":
   

   function CreateChainLightning(source, target, damage, aoe, duration, interval, bounces, attacktype, damagetype, lightning, effect, attach, rebounce)
           local player = GetOwningPlayer(source)
           local group = GetEnemyUnitsInRange(player, GetUnitX(target), GetUnitY(target), aoe, false, false)
   
           if BlzGroupGetSize(group) == 1 then
               DestroyLightningTimed(AddLightningEx(lightning, true, GetUnitX(source), GetUnitY(source), GetUnitZ(source) + 60.0, GetUnitX(target), GetUnitY(target), GetUnitZ(target) + 60.0), duration)
               DestroyEffect(AddSpecialEffectTarget(effect, target, attach))
               UnitDamageTarget(source, target, damage, false, false, attacktype, damagetype, nil)
               DestroyGroup(group)
           else
               local timer = CreateTimer()
               local damaged = CreateGroup()
               local prev = nil
               local this = target
               local next = nil
   
               GroupRemoveUnit(group, this)
               GroupAddUnit(damaged, this)
               UnitDamageTarget(source, this, damage, false, false, attacktype, damagetype, nil)
               DestroyEffect(AddSpecialEffectTarget(effect, this, attach))
               TimerStart(timer, interval, true, function()
                   DestroyGroup(group)
                   if bounces > 0 then
                       group = GetEnemyUnitsInRange(player, GetUnitX(this), GetUnitY(this), aoe, false, false)
                       GroupRemoveUnit(group, this)
   
                       if not rebounce then
                           BlzGroupRemoveGroupFast(damaged, group)
                       end
   
                       if BlzGroupGetSize(group) == 0 then
                           PauseTimer(timer)
                           DestroyTimer(timer)
                           DestroyGroup(group)
                           DestroyGroup(damaged)
                       else
                           next = GetClosestUnitGroup(GetUnitX(this), GetUnitY(this), group)
   
                           if next == prev and BlzGroupGetSize(group) > 1 then
                               GroupRemoveUnit(group, prev)
                               next = GetClosestUnitGroup(GetUnitX(this), GetUnitY(this), group)
                           end
   
                           if next then
                               DestroyLightningTimed(AddLightningEx(lightning, true, GetUnitX(this), GetUnitY(this), GetUnitZ(this) + 60.0, GetUnitX(next), GetUnitY(next), GetUnitZ(next) + 60.0), duration)
                               DestroyEffect(AddSpecialEffectTarget(effect, next, attach))
                               GroupAddUnit(damaged, next)
                               UnitDamageTarget(source, next, damage, false, false, attacktype, damagetype, nil)
                               DestroyGroup(group)
                               prev = this
                               this = next
                               next = nil
                           else
                               PauseTimer(timer)
                               DestroyTimer(timer)
                               DestroyGroup(group)
                               DestroyGroup(damaged)
                           end
                       end
                   else
                       PauseTimer(timer)
                       DestroyTimer(timer)
                       DestroyGroup(group)
                       DestroyGroup(damaged)
                   end
                   bounces = bounces - 1
               end)
           end
           DestroyGroup(group)
       end

   The variable prev is set to nil, and the line "GroupRemoveUnit(group, prev)" throws a warning saying: "Cannot assign nil to parameter unit. Type nil cannot match `unit`Lua Diagnostics.(param-type-mismatch)"
   If I understand this correctly, this if statement will not fire when prev is nil, so I assume no ingame error will rise, so this should be ignored?
5. The guide recommends to avoid using "location" and instead use x,y coords. I saw a few places where the code uses location. Should I change it to use x,y coords and adjust the code where ever needed to work with the change?

 

[Barade]

Could you add an attack range bonus like:

BONUS_ATTACK_RANGE_0
BONUS_ATTACK_RANGE_1
BONUS_ACQUISITION_RANGE

It would be really useful.

 

[FlameofChange]

Could you add an attack range bonus like:

BONUS_ATTACK_RANGE_0
BONUS_ATTACK_RANGE_1
BONUS_ACQUISITION_RANGE

It would be really useful.

There's no ability changing a unit range, thus this system cannot use it.
The native functions are also bugged, but TL;DR you can only change the first range index.

 

[emperor_d3st]

Hi @chopinski !

My homemade system contains the following stats too. Consider adding them to your system. If you want to, I can tell you which ability, which field, and even give you the jass code.

HP Percent Per Sec

Damage Percent

Melee Damage

Melee Damage Percent

Ranged DMG

Ranged DMG Percent

Attack Range

Movement Speed Percent

Spell Damage Taken Percent

Magic Damage Taken Percent

Melee Damage Taken Percent

Pierce Damage Taken Percent

Life on Hit (Gives a set amount. Different than the % based lifesteal)

Cleave Percent

Cleave Area

 

[P3in]

Hi @chopinski !

My homemade system contains the following stats too. Consider adding them to your system. If you want to, I can tell you which ability, which field, and even give you the jass code.

HP Percent Per Sec

Damage Percent

Melee Damage

Melee Damage Percent

Ranged DMG

Ranged DMG Percent

Attack Range

Movement Speed Percent

Spell Damage Taken Percent

Magic Damage Taken Percent

Melee Damage Taken Percent

Pierce Damage Taken Percent

Life on Hit (Gives a set amount. Different than the % based lifesteal)

Cleave Percent

Cleave Area

That would be a nice addition to the system if you can share.

There is also another one made by @ThompZon that allows the use of any extra custom stat like the one's you mentioned.

ExtendableBonusSystem

What is this system? Inspired by chopinski New Bonus system, I wanted a system that you can add your own bonuses using a simple coding interface. Hopefully the interface will be simple so it is easy to implement but also this means that the core can upgrade without impacting the extensions...

www.hiveworkshop.com

 

[nana7mi]

The mana regeneration part may could be optimized.
Brilliance Aura and Mana Fountain are flat regen (already supported),
but Sobi Mask should be % bonus based on base mana regen, which doesn’t seem to be implemented.