[Trigger] Need some help

[utha]

Ok so i always read that

• Wait X seconds

this is bad or not good to use but i don't know how not to use it so i need help fixing that with this

Trigger

• Wolf Fang
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Wolf Fang Fist
  • Actions
    • Set Caster[3] = (Triggering unit)
    • Set CasterLoc[2] = (Position of Caster[3])
    • Set integer_variable[3] = (Level of (Ability being cast) for Caster[3])
    • Set Target[1] = (Target unit of ability being cast)
    • Unit - Pause Target[1]
    • Unit - Pause Caster[3]
    • Unit - Make Caster[3] Invulnerable
    • Unit - Make Target[1] Invulnerable
    • Special Effect - Create a special effect at CasterLoc[2] using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
    • Animation - Play Caster[3]'s attack animation
    • Special Effect - Create a special effect at CasterLoc[2] using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
    • Floating Text - Create floating text that reads Wolf at TargetPoint[1] with Z offset 30.00, using font size 20.00, color (100.00%, 0.00%, 0.00%), and 0.00% transparency
    • Set WolfFang_FT = (Last created floating text)
    • Special Effect - Destroy (Last created special effect)
    • Wait 0.45 seconds
    • Animation - Play Caster[3]'s attack animation
    • Special Effect - Create a special effect at CasterLoc[2] using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
    • Floating Text - Change text of WolfFang_FT to Fang using font size 20.00
    • Special Effect - Destroy (Last created special effect)
    • Wait 0.55 seconds
    • Animation - Play Caster[3]'s attack animation
    • Special Effect - Create a special effect at CasterLoc[2] using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
    • Floating Text - Change text of WolfFang_FT to Fist using font size 20.00
    • Special Effect - Destroy (Last created special effect)
    • Unit - Unpause Target[1]
    • Unit - Unpause Caster[3]
    • Unit - Make Caster[3] Vulnerable
    • Unit - Make Target[1] Vulnerable
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • integer_variable[3] Greater than 0
      • Then - Actions
        • Unit - Cause Caster[3] to damage Target[1], dealing ((Real(integer_variable[3])) x 400.00) damage of attack type Spells and damage type Normal
      • Else - Actions
    • Set KBA_Caster = Caster[3]
    • Set KBA_TargetUnit = Target[1]
    • Set KBA_StartingPosition = CasterLoc[2]
    • Set KBA_Level = (Level of (Ability being cast) for Caster[3])
    • Set KBA_Speed = 10.00
    • Set KBA_DistancePerLevel = 250.00
    • Set KBA_SpecialEffects[1] = Objects\Spawnmodels\Orc\OrcSmallDeathExplode\OrcSmallDeathExplode.mdl
    • Set KBA_SpecialEffects[2] = Abilities\Spells\Orc\FeralSpirit\feralspiritdone.mdl
    • Set KBA_DestroyTrees = True
    • Wait 0.20 seconds
    • Trigger - Run Cast A Knockback <gen> (checking conditions)
    • Floating Text - Destroy WolfFang_FT
    • Custom script: call DestroyTextTag( udg_Combo_FT )
    • Custom script: call RemoveLocation (udg_CasterLoc[2])

 

[mckill2009]

depends how you use it, if MUI spells, it's not bad but 'very bad', I suggest you switch to looping timers/triggers and use indexing or hashtables systems for awesome results...

but wait can be useful, like in cinematics...

 

[Bannar]

You can create a second trigger that runs loop with time event (lets say every 0.05 sec).

You want to wait 0.45 sec?
Instead of this:

• Wait 0.45 seconds

Do this:

• Set Time[Index] = 0.45

And in loop:

• Loop
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Set Time[Index] = (Time[Index] - 0.05)
    • If (All conditions are true) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Time[Index] Less or equal to 0.00
      • Then - Actions
        • <your actions>
      • Else - Actions

Index means proper indexing for real variable Time[Index] for making it MUI. However I see that your spell isn't MUI at all..

For multiple actions divided in time you can use Time[Index] followed by integer variable, which would be an additional condition.
Lets say, when Int[Index] = 1 and Time[] reaches 0.00, you do actions:

• If (All conditions are true) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Time[Index] Less or equal to 0.00
  • Then - Actions
    • If (All conditions are true) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Time[Index] Less or equal to 0.00
        • Int[Index] = 1
      • Then - Actions
        • <your actions>
        • Animation - Play Caster[3]'s attack animation
        • Special Effect - Create a special effect at CasterLoc[2] using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
        • Floating Text - Change text of WolfFang_FT to Fang using font size 20.00
        • Special Effect - Destroy (Last created special effect)
        • Set Time[Index] = 0.55
        • Set Int[Index] = 2

Then you want to wait 0.55 so we set Timer[Index] again, but this time to 0.55, and integer variable Int[Index] to 2.
When that reaches 0.00 you follow this with next part of actions.

• If (All conditions are true) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Time[Index] Less or equal to 0.00
  • Then - Actions
    • If (All conditions are true) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Time[Index] Less or equal to 0.00
        • Int[Index] = 1
      • Then - Actions
        • <your actions>
        • Animation - Play Caster[3]'s attack animation
        • Special Effect - Create a special effect at CasterLoc[2] using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
        • Floating Text - Change text of WolfFang_FT to Fang using font size 20.00
        • Special Effect - Destroy (Last created special effect)
        • Set Time[Index] = 0.55
        • Set Int[Index] = 2
      • Else - Actions
        • <next part of actions>

Ofcourse your loop needs to end somewhere, your job to do this.

Hashtables can help here too, they are much safer. Click here for great Hash tutorial. I bet tons of people sent you this link, but wyrmlord shows there an egzample how to trigger proper MUI Healing over Time spell, you can learn from it.

 

[utha]

ok that is helpful

but why are waits exactly bad

 

[mckill2009]

wait is TriggerSleepAction in JASS, so from the word itself, it will make the trigger 'sleep' or inactive(not off) so its really bad for MUI spells...

 

[utha]

so if i make a trigger that only unit A uses for one of his spells an there is only 1 unit A on the map which uses waits
will it bug the trigger really badly?

 

[Bannar]

If you make triggers only for one unit, you spell is not spammed by it, there is nothing wrong with Waits, furthermore TriggerSleepAction() gives your Warcraft3 small break which reduces lag.

You can even check democampaign in warcraft3 folder how blizzard uses waits for many triggers - but its only for one occasion, for one unit.

 

[utha]

thats good to know now i won't have to redo my triggers

i will give you rep when i can Spinnaker but says i need to spread it around more...

 

[Bannar]

There is a limit, if I'm not mistaken. After giving rep to someone, you have to give it to other 5 members before you're able to add him rep again.

 

[Magtheridon96]

TriggerSleepAction starts a new thread.
It stops the current thread, pauses, creates a new one and continues the actions.
This can cause errors sometimes.
Plus, TriggerSleepAction doesn't go lower than 0.27 seconds.