[Trigger] Need a leaks check for simple triggers.

[Dragonkillerrus]

So here is a simple Divine Shield spell not for caster but for friendly unit (Based on Rejuvenation)

Spoiler: ”triggers”

• Hand of Protection Start
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Hand of Protection
  • Actions
    • Set triggeringHoProt = (Triggering unit)
    • Set IntegerHoProt = (Level of Hand of Protection for triggeringHoProt)
    • Set TargetHoProt = (Target unit of ability being cast)
    • Custom script: set udg_HoProtHashKey = GetHandleId(udg_TargetHoProt)
    • Unit - Make TargetHoProt Invulnerable
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • IntegerHoProt Equal to 1
      • Then - Actions
        • Hashtable - Save 15 as 0 of HoProtHashKey in ZHandOfProt
        • Unit Group - Add TargetHoProt to HandOfProtGroup
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • IntegerHoProt Equal to 2
          • Then - Actions
            • Hashtable - Save 30 as 0 of HoProtHashKey in ZHandOfProt
            • Unit Group - Add TargetHoProt to HandOfProtGroup
          • Else - Actions
            • Hashtable - Save 45 as 0 of HoProtHashKey in ZHandOfProt
            • Unit Group - Add TargetHoProt to HandOfProtGroup

• Hand Of Protection
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in HandOfProtGroup and do (Actions)
      • Loop - Actions
        • Set PickedHoProt = (Picked unit)
        • Custom script: set udg_HoProtHashKey1 = GetHandleId(udg_PickedHoProt)
        • Set HandOfProtTimer = (Load 0 of HoProtHashKey1 from ZHandOfProt)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • HandOfProtTimer Greater than 0
          • Then - Actions
            • Game - Display to (All players) the text: (String(HandOfProtTimer))
            • Hashtable - Save (HandOfProtTimer - 1) as 0 of HoProtHashKey1 in ZHandOfProt
          • Else - Actions
            • Unit - Make PickedHoProt Vulnerable
            • Unit Group - Remove PickedHoProt from HandOfProtGroup
            • Hashtable - Clear all child hashtables of child HoProtHashKey1 in ZHandOfProt

Also for some reason this ability can be casted on enemies despite of allowed targets Friend, Ground, Not self, Organic, Vulnerable.

 

[Chaosy]

Disable the loop trigger on init, and when adding a unit to the group check if number of units in group is equal to 0, if true enable the trigger.
And then reverse when removing the unit, the idea is to prevent the timer loop from running when the group is empty.

 

[Dragonkillerrus]

Disable the loop trigger on init, and when adding a unit to the group check if number of units in group is equal to 0, if true enable the trigger.
And then reverse when removing the unit, the idea is to prevent the timer loop from running when the group is empty.

Oh each, forgot about that. So I guess I should turn off second trigger in the editor and then add "turn on Hand of Protection" to the first trigger and add if the amount of units in HandofProtGroup = 0 turn off this trigger to the second trigger?

 

[Chaosy]

Yes.
Though you should check if size == 0 when enabling the trigger as well as it might already be on.

 

[Dragonkillerrus]

Yes.
Though you should check if size == 0 when enabling the trigger as well as it might already be on.

Wait, why is turning on a trigger that is already on a bad thing?

 

[Chaosy]

Performance, probably.
I actually do not know the math behind it, I just know it is the standard practice.

I suspect @IcemanBo might have a more detailed answer.

 

[Dragonkillerrus]

Performance, probably.
I actually do not know the math behind it, I just know it is the standard practice.

I suspect @IcemanBo might have a more detailed answer.

Doesn't checking if unit group has >0 units before turning on trigger only adds more calculations?

 

[IcemanBo]

Wait, why is turning on a trigger that is already on a bad thing?

It won't change result, but an integer comparison is for sure faster. But it doesn't really matter for you, you can also turn it always on.

Also, the check in GUI, if a group is empty, is pretty slow and also very inefficient in comparison to a simple integer comparison, because it loops through the whole unit group each time. But it's also not really critical, just some performance optimization. One could also then say directly to use arrays to replace unit group loop completly, etc, but just keep it simple for you to maintain.

I can't see leaks.

• Unit Group - Add TargetHoProt to HandOfProtGroup

^You do this in any case, so it might be moved out of the if-statement to be always last operation in the trigger.

 

[Dragonkillerrus]

Also, the check in GUI, if a group is empty, is pretty slow and also very inefficient in comparison to a simple integer comparison, because it loops through the whole unit group each time. But it's also not really critical, just some performance optimization. One could also then say directly to use arrays to replace unit group loop completly, etc, but just keep it simple for you to maintain.

Interesting. Is there a tutorial for that?

 

[IcemanBo]

Yes, click my signature -> Tutorials -> Dynamic Indexing
It explains a tequnique to use arrays and to recyclde its indices. Do it if you're curious, not because to say unit groups are bad. They do their job, and can simplify things, too. : )