Leak/Efficiency check

[EricDaRed]

Hey guys. I'm starting to train myself how to avoid/deal with leaks. Please tell me if the following trigger leaks or not. Also, please tell me if it is MUI or not.

Also, please let me know if there is anything I can do to make the trigger better.

Just so you know, this spell makes the caster ethereal and heals them for x hit points over 10 seconds (via dummy units casting rejuv and banish).

• Accursed State
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Accursed State
  • Actions
    • Set Temp_Point = (Position of (Triggering unit))
    • Unit - Create 1 UNIT_ACCUR_DUMMY[(Level of Accursed State for (Triggering unit))] for (Owner of (Triggering unit)) at Temp_Point facing Temp_Point
    • Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
    • Unit - Order (Last created unit) to Human Blood Mage - Banish (Triggering unit)
    • Unit - Create 1 UNIT_ACCUR_DUMMY[(Level of Accursed State for (Triggering unit))] for (Owner of (Triggering unit)) at Temp_Point facing Temp_Point
    • Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
    • Unit - Order (Last created unit) to Night Elf Druid Of The Claw - Rejuvenation (Triggering unit)
    • Custom script: call RemoveLocation (udg_Temp_Point)

EDIT: I fixed the facing unit location leak. Thanks marven15.

 

[marven15]

I used Leak Check. It says your leaking two locations. I'm talking about "Temp_Point" facing (Position of(Triggering Unit))".

 

[EricDaRed]

Thanks! Leak check? What's that and where can I get it?

 

[marven15]

Check the Tools section. You will see it there.

 

[EricDaRed]

Thank you very much!!

 

[Ciebron]

i cant start my leak check just hear an error sound :<

 

[marven15]

I also experienced that. Did you downloaded the 3.1 version? If you downloaded it, Download the 3.0 version. That will work.

 

[Ciebron]

nop it dont

but dunno if leak check works for jass

 

[EricDaRed]

Leak check doesn't work for jass because it checks for things that leak and recommends fixes, in Jass there aren't fixes because you shouldn't have code that leaks

 

[HINDYhat]

That isn't necessarily the reason that there is no 'leak check' type program for Jass...

Anyway, I find it quite ironic that you're worrying about efficiency while working with the GUI.

 

[EricDaRed]

Just because I'm working in GUI, that doesn't mean that I don't want my triggers to be as efficient as GUI will allow. I enjoy map-making, but am not really inclined to put in the effort to learn JASS.

Despite popular opinion: Functional, Fun, and lag-resistant maps can be made in GUI.

 

[GhostWolf]

Just because I'm working in GUI, that doesn't mean that I don't want my triggers to be as efficient as GUI will allow. I enjoy map-making, but am not really inclined to put in the effort to learn JASS.

Despite popular opinion: Functional, Fun, and lag-resistant maps can be made in GUI.

I'm happy for you that you enjoy making maps.
Anyway, of course good maps can be made with GUI, but most of the stuff you will want to make MUI (can be cast by any unit, any time, without bugging anything) is almost impossible.
And Jass will always be better at coding more efficient codes.

Now about the subject itself, you might as well just learn what leaks are instead of using a leak checker (which is not always right if I remember correctly).
You can read this little explanation I made or find many other explanations.

 

[EricDaRed]

Yea, I've been studying up on leaks with tutorials/etc.

Is the trigger above MUI? I would think that it is since Temp_Point is set and cleared in the same trigger, so it would be reset and re-cleared each time the ability is used.

Also, my answer to the MUI issue is to make abilities semi-MUI. By using arrays, If can make abilities able to be cast by 1 unit/hero for each player simultaneously. I just have to be careful that the effect of the spell is not longer than the cooldown. This limits me to hero arena/maul/aos/etc type maps, but I'm cool with that. Once I get really good at GUI, I might consider learning JASS. Not yet, though.

I'm still discovering useful GUI functions that I didn't know existed on a weekly basis.

 

[PurplePoot]

If you want a more reliable leak checker for some things, download JassNewGenPack - when you test maps with war3err (automatically built in to the test function in it), it will tell you whenever you are leaking groups and/or locations, where you're leaking them, and how many you've leaked.

 

[EricDaRed]

I can't find JassNewJenPack in the tools section. Were can I find it? Also, can I/should I use it without any knowledge of Jass?

Also, is the trigger in the original post MUI?

 

[Silvenon]

Here it is.

Yeah, the trigger in the original post is MUI. Triggers which have no waits are MUI, always keep that in mind.

 

[redscores]

Not necessarily true, they can bug if they are cast at exactly the same time for example, and waitless spells are mostly not really... useful? Well, it depends on what you want.

 

[EricDaRed]

I thought from a programming standpoint that is was impossible for any two triggers to occur at exactly the same time.

Oh, and good to 'see' you again redscores. I hope to run into on b.net sometime.

 

[PurplePoot]

redscores, there are plenty of reasons to have waitless spells, for example, a shockwave nova.

Also, Silvenon is right; two triggers will not be run during the execution of each other, no matter how close together the events occur.