Lightsworn Paladin Spellpack v 1.3

Moderator · Aug 21, 2013

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Lightsworn Paladin Spellpack | Reviewed by Maker | 21st Sept 2013

NEEDS FIX

	You need to learn how to clear the leaks correctly. You could post a thread in Triggers and Scripts forum to improve your code Light Wave is not multi unit instanceable (MUI)
	Things that leak Dynamic indexing Spell Submission Rules

[tr]

nhocklanhox6 · Aug 21, 2013

Spell have no CONFIGURABLES, not MUI, too Simple, and cause Leak

You must fix leak, like this

Set leak = (Position of Purify_Caster)
Unit - Create 1 Purification for (Owner of Purify_Caster) at leak facing Default building facing degrees
Custom script: call RemoveLocation(udg_leak)

Things that leak
MUI spells using artificial waits
How easily post triggers

Mapcreator_BL · Aug 21, 2013

oh, thank you... I'll fix this

FUJI · Aug 21, 2013

nhocklanhox6 said:
Spell have no CONFIGURABLES, not MUI, too Simple, and cause Leak

You must fix leak, like this

Set leak = (Position of Purify_Caster)

Unit - Create 1 Purification for (Owner of Purify_Caster) at leak facing Default building facing degrees

Custom script: call RemoveLocation(udg_leak)

Things that leak
MUI spells using artificial waits
How easily post triggers

Agree,

FUJI · Aug 21, 2013

Code of his Spell

Anyway here is the code of HIS spell.

Purification
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Purification
- Actions
  - Set Purify_Caster = (Casting unit)
  - Set Purify_Heal[1] = 150.00
  - Set Purify_Heal[2] = 180.00
  - Set Purify_Heal[3] = 200.00
  - Set Purify_UnitGroup = (Units within 300.00 of (Position of Purify_Caster))
  - Unit Group - Pick every unit in Purify_UnitGroup and do (Actions)
    - Loop - Actions
      - Set Purify_Picked = (Picked unit)
      - Unit - Create 1 Purification for (Owner of Purify_Caster) at (Position of Purify_Caster) facing Default building facing degrees
      - Set Purify_Dummy = (Last created unit)
      - Unit - Set level of Heal (Dummy) for Purify_Dummy to 1
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Purify_Picked belongs to an enemy of (Owner of Purify_Caster)) Equal to True
        
        (Level of Purification for Purify_Caster) Equal to 1
        
        Then - Actions
        
        Unit - Cause Purify_Caster to damage Purify_Picked, dealing Purify_Heal[1] damage of attack type Spells and damage type Normal
        
        Unit - Order Purify_Dummy to Human Paladin - Holy Light Purify_Caster
        
        Unit - Add a 0.50 second Generic expiration timer to Purify_Dummy
        
        Custom script: call DestroyGroup(udg_Purify_UnitGroup)
        
        Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Purify_Picked belongs to an enemy of (Owner of Purify_Caster)) Equal to True
        
        (Level of Purification for Purify_Caster) Equal to 2
        
        Then - Actions
        
        Unit - Set level of Heal (Dummy) for Purify_Dummy to 2
        
        Unit - Cause Purify_Caster to damage Purify_Picked, dealing Purify_Heal[2] damage of attack type Spells and damage type Normal
        
        Unit - Order Purify_Dummy to Human Paladin - Holy Light Purify_Caster
        
        Unit - Add a 0.50 second Generic expiration timer to Purify_Dummy
        
        Custom script: call DestroyGroup(udg_Purify_UnitGroup)
        
        Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Purify_Picked belongs to an enemy of (Owner of Purify_Caster)) Equal to True
        
        (Level of Purification for Purify_Caster) Equal to 2
        
        Then - Actions
        
        Unit - Set level of Heal (Dummy) for Purify_Dummy to 3
        
        Unit - Cause Purify_Caster to damage Purify_Picked, dealing Purify_Heal[3] damage of attack type Spells and damage type Normal
        
        Unit - Order Purify_Dummy to Human Paladin - Holy Light Purify_Caster
        
        Unit - Add a 0.50 second Generic expiration timer to Purify_Dummy
        
        Custom script: call DestroyGroup(udg_Purify_UnitGroup)
        
        Else - Actions

Light Wave
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Lightwave
- Actions
  - Set Light_Caster = (Casting unit)
  - Set Light_Damage = (120.00 x (Real((Level of Lightwave for Light_Caster))))
  - Unit - Create 1 Light Wave for (Owner of Light_Caster) at (Position of Light_Caster) facing (Facing of Light_Caster) degrees
  - Set Light_Dummy = (Last created unit)
  - Set Light_Timer = 0.00
  - Set Light_Life = (Life of Light_Caster)
  - Trigger - Turn on Light Wave move <gen>
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Level of Lightwave for Light_Caster) Equal to 2
    - Then - Actions
      - Set Light_Damage = (Light_Damage - 40.00)
    - Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Level of Lightwave for Light_Caster) Equal to 3
        
        Then - Actions
        
        Set Light_Damage = (Light_Damage - 60.00)
        
        Else - Actions

Light Wave move
- Events
  - Time - Every 0.03 seconds of game time
- Conditions
- Actions
  - Set Light_Point[1] = (Position of Light_Dummy)
  - Set Light_Point[2] = (Light_Point[1] offset by 40.00 towards (Facing of Light_Dummy) degrees)
  - Unit - Move Light_Dummy instantly to Light_Point[2]
  - Set Light_Timer = (Light_Timer + 25.00)
  - Unit - Cause Light_Caster to damage circular area after 0.00 seconds of radius 50.00 at Light_Point[2], dealing Light_Damage damage of attack type Spells and damage type Normal
  - Unit - Set life of Light_Caster to Light_Life%
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - Light_Timer Greater than or equal to 1000.00
    - Then - Actions
      - Custom script: call RemoveLocation(udg_Light_Point[1])
      - Custom script: call RemoveLocation(udg_Light_Point[2])
      - Set Light_Timer = 0.00
      - Unit - Kill Light_Dummy
      - Trigger - Turn off (This trigger)
    - Else - Actions
  - Custom script: call RemoveLocation(udg_Light_Point[1])
  - Custom script: call RemoveLocation(udg_Light_Point[2])

Revealing Light
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Revealing Light
- Actions
  - Set R_Caster = (Casting unit)
  - Set R_Damage[1] = 300.00
  - Set R_Damage[2] = 380.00
  - Set R_Damage[3] = 430.00
  - Set R_Point = (Target point of ability being cast)
  - Set R_UnitGroup = (Units within 500.00 of R_Point)
  - Unit - Create 1 Radiance for (Owner of R_Caster) at R_Point facing 0.00 degrees
  - Set R_dummy = (Last created unit)
  - Unit - Order R_dummy to Human Mountain King - Thunder Clap
  - Unit - Add a 4.00 second Generic expiration timer to R_dummy
  - Unit Group - Pick every unit in R_UnitGroup and do (Actions)
    - Loop - Actions
      - Set R_Picked = (Picked unit)
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (R_Picked belongs to an enemy of (Owner of R_Caster)) Equal to True
        
        (Level of Revealing Light for R_Caster) Equal to 1
        
        Then - Actions
        
        Unit - Cause R_Caster to damage R_Picked, dealing R_Damage[1] damage of attack type Spells and damage type Normal
        
        Custom script: call RemoveLocation(udg_R_Point)
        
        Custom script: call DestroyGroup(udg_R_UnitGroup)
        
        Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (R_Picked belongs to an enemy of (Owner of R_Caster)) Equal to True
        
        (Level of Revealing Light for R_Caster) Equal to 2
        
        Then - Actions
        
        Unit - Cause R_Caster to damage R_Picked, dealing R_Damage[2] damage of attack type Spells and damage type Normal
        
        Custom script: call RemoveLocation(udg_R_Point)
        
        Custom script: call DestroyGroup(udg_R_UnitGroup)
        
        Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (R_Picked belongs to an enemy of (Owner of R_Caster)) Equal to True
        
        (Level of Revealing Light for R_Caster) Equal to 3
        
        Then - Actions
        
        Unit - Cause R_Caster to damage R_Picked, dealing R_Damage[3] damage of attack type Spells and damage type Normal
        
        Custom script: call RemoveLocation(udg_R_Point)
        
        Custom script: call DestroyGroup(udg_R_UnitGroup)
        
        Else - Actions

Maker · Aug 21, 2013

Use [hidden=Triggers][/hidden] tags.

FUJI · Aug 21, 2013

Maker said:
Use [hidden=Triggers][/hidden] tags.

Oops, Sorry

.

Rheiko · Aug 28, 2013

full of leaks..
my suggestion is.. read tutorial before you post your spell here

Mapcreator_BL · Aug 29, 2013

well I'm sorry im just a beginner, all i wanted is to learn more, so i've decided to post this spellpack to know what mistakes i have done.

Rheiko · Aug 29, 2013

you should post this in trigger & scripts to ask people to find your mistakes.
not here..
a little present from me
+REP

Mapcreator_BL · Sep 18, 2013

what is that?

Rheiko · Sep 18, 2013

this

nhocklanhox6 · Sep 18, 2013

Spell still NOT MUI.

If (All Conditions are True) then do (Then Actions) else do (Else Actions)
- If - Conditions
  - (Level of Purification for Purify_Caster) Equal to 2
- Then - Actions
  - Unit - Set level of Heal (Dummy) for Purify_Dummy to 2
- Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
- If - Conditions
  - (Level of Purification for Purify_Caster) Equal to 3
- Then - Actions
  - Unit - Set level of Heal (Dummy) for Purify_Dummy to 3
- Else - Actions

Fix it like this:

Unit - Set level of Heal (Dummy) for Purify_Dummy to (Level of Purification for Purify_Caster)

How easily post triggers

Anyway, i love your terrain, so cool..

Rheiko · Sep 18, 2013

maybe you should try terraining again nee-san

FUJI · Sep 18, 2013

Reading this will make you learn about GUI MUI. MUI making in this tutorial is seperated to Indexed Arrays and Hashtables, so choose one in there ^^. Things a GUI User Should Know
Or use some Simple MUI Spells in the Spell Sections as a template.

Xonok · Sep 18, 2013

I don't understand. Most of these spells already exist.

Rheiko · Sep 18, 2013

well, you mention it. now i wondering about that as well

T. D. W. · Sep 18, 2013

v 2 Review

Review

Suggestions

Rating

Judgement

My Words

Set Purify_Caster = (Casting unit)

Change this to Triggering Unit not Casting Unit

Custom script: call RemoveLocation(udg_Purify_Point)

This should be in another place

Unit - Set level of Heal (Dummy) for Purify_Dummy to 2

Those 2 If Then Else Should be removed and all of those i just said should be like that:

Unit Group - Pick every unit in Purify_UnitGroup and do (Actions)
- Loop - Actions
  - Set Purify_Picked = (Picked unit)
  - Set Purify_Point = (Position of Purify_Caster)
  - Unit - Create 1 Purification for (Owner of Purify_Caster) at Purify_Point facing Default building facing degrees
  - Set Purify_Dummy = (Last created unit)
  - Unit - Set level of Heal (Dummy) for Purify_Dummy to (Level of Purification for Purify_Caster)
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Purify_Picked belongs to an enemy of (Owner of Purify_Caster)) Equal to True
    - Then - Actions
      - Unit - Cause Purify_Caster to damage Purify_Picked, dealing Purify_Heal[1] damage of attack type Spells and damage type Normal
      - Unit - Order Purify_Dummy to Human Paladin - Holy Light Purify_Caster
      - Unit - Add a 0.50 second Generic expiration timer to Purify_Dummy
      - Custom script: call DestroyGroup(udg_Purify_UnitGroup)
    - Else - Actions
  - Custom script: call RemoveLocation(udg_Purify_Point)

Light Wave is not MUI at all and does not DAMAGE units
For a reason i don't understand, revealing light does not "always" damage units

Those are pretty basic spells, practice more so i can see you make greater spells, good luck

None

Purification: 3/5
Light Wave: 1/5
Revealing Light: 2/5
TOTAL:

If You want me to review an Update of This Spell, Please Notifiy me this by VM or PM

nhocklanhox6 · Sep 19, 2013

Jad said:
[COLOR="White"

[COLOR="White"

[COLOR="White"

[COLOR="White"

[COLOR="White"

Review[/COLOR]]

Set Purify_Caster = (Casting unit)

Change this to Triggering Unit not Casting Unit

Custom script: call RemoveLocation(udg_Purify_Point)

This should be in another place

Unit - Set level of Heal (Dummy) for Purify_Dummy to 2

Those 2 If Then Else Should be removed and all of those i just said should be like that:

Unit Group - Pick every unit in Purify_UnitGroup and do (Actions)

Loop - Actions

Set Purify_Picked = (Picked unit)

Set Purify_Point = (Position of Purify_Caster)

Unit - Create 1 Purification for (Owner of Purify_Caster) at Purify_Point facing Default building facing degrees

Set Purify_Dummy = (Last created unit)

Unit - Set level of Heal (Dummy) for Purify_Dummy to (Level of Purification for Purify_Caster)

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(Purify_Picked belongs to an enemy of (Owner of Purify_Caster)) Equal to True

Then - Actions

Unit - Cause Purify_Caster to damage Purify_Picked, dealing Purify_Heal[1] damage of attack type Spells and damage type Normal

Unit - Order Purify_Dummy to Human Paladin - Holy Light Purify_Caster

Unit - Add a 0.50 second Generic expiration timer to Purify_Dummy

Custom script: call DestroyGroup(udg_Purify_UnitGroup)

Else - Actions

Custom script: call RemoveLocation(udg_Purify_Point)

Light Wave is not MUI at all and does not DAMAGE units
For a reason i don't understand, revealing light does not "always" damage units

Those are pretty basic spells, practice more so i can see you make greater spells, good luck

Suggestions[/COLOR]]None

Rating[/COLOR]]
Purification: 3/5
Light Wave: 1/5
Revealing Light: 2/5
TOTAL:

Judgement[/COLOR]]

My Words[/COLOR]]If You want me to review an Update of This Spell, Please Notifiy me this by VM or PM

Hmm, so colorful

Rheiko · Sep 19, 2013

what do you mean by that nee-san?
i think it's not that colorful :\

T. D. W. · Sep 19, 2013

Rheiko said:
what do you mean by that nee-san?
i think it's not that colorful :\

Go to my ratings album and see the colorful ;p

Rheiko · Sep 19, 2013

still, for me
it's not that colorful :\

Mapcreator_BL · Sep 19, 2013

Oh, thank you everybody!!!!

))
I'm so glad

Thank you so much xD

nhocklanhox6 · Oct 6, 2013

Lacks trigger, please post the trigger, use

[/ TRIGGER] tags.

Mapcreator_BL · Oct 6, 2013

is my map, not leaking?

sorry i didn't follow Jad, because I can't understand it xD

how can i post the trigger, i just put the "

[/ TRIGGER] tags?"

Rheiko · Oct 6, 2013

do this

[trigger]Stupid
Events
Unit - A unit dies
Conditions
Actions
Set TempPoint = Position of (Triggering unit)
Hero - Revive Rheiko at TempPoint
[/trigger]

it will change into this

Stupid
Events
- Unit - A unit dies
Conditions
Actions
- Set TempPoint = Position of (Triggering unit)
- Hero - Revive Rheiko at TempPoint

Maker · Oct 6, 2013

Get rid of the wait in Purification. Light Wave is not MUI. Needs Fix

Rheiko, you can use noparse tags, like this [trigger][/trigger]

Rheiko · Oct 6, 2013

i know, just.. hmm

Lightsworn Paladin Spellpack v 1.3

Ruman's Map version 1 (Map)

Moderator

Moderator

Review

Suggestions

Rating

Judgement

My Words

[COLOR="White"

[COLOR="White"

[COLOR="White"

[COLOR="White"

[COLOR="White"

Similar threads