Battle Focus v 1.3

[Moderator]

Reviewed by Maker, Battle Focus v 1.3, 27th Dec

Approved. Possible improvements: Use dynamic indexing You could use a init trigger where you can set up abilities, time and AoE Improve tooltip to match standard Blizzard ability tooltips I don't think it is necessary to do the enumerations every 0.03 seconds. 0.1 seconds could be fine.

Old review

Maker, Battle Focus v 1.1, 22nd Dec

Contains no importing instructions Auras should place a buff on units You could improve the learn tooltip. List stats for all levels You don't have to remove all units from a group if you're going to destroy it right away I recommend you create a setup trigger, where one can set up the unit types and abilities. Otherwise the spell is a pain to import and configure Dead units bestow aura?

 

[xIceShotx]

You can put a title like this in the first tag: [hidden=Title goes here]
And for triggers:
Whenever you use a unit group that does "Unit Group - Pick every unit in "Unit Group" and do (Actions)",
you can do this custom script:

• Custom script: set bj_wantDestroyGroup = true

right before the unit group is created instead of doing "call DestoryGroup(bla bla bla)"
And then while you're at it, you forgot to destroy this unit group:

• Unit Group - Pick every unit in BFGroup[BFIndex] and do (Actions)
  • Loop - Actions
    • Unit - Add Battle Focus Book to (Picked unit)

 

[Magtheridon96]

In the cast trigger (Battle Focus), when you cache (Triggering unit) and (Last created unit) into variables, why aren't you using them? It's much more efficient to use the variables instead of repeating the functions.

Also:

• Unit Group - Pick every unit in BFGroup[BFInteger] and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) is in TempGroup) Equal to True
      • Then - Actions
      • Else - Actions
        • Unit Group - Remove (Picked unit) from BFGroup[BFInteger]
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Battle Focus Critical for (Picked unit)) Greater than 0
          • Then - Actions
            • Unit - Remove Battle Focus Book from (Picked unit)
          • Else - Actions

The group is never destroyed and why are you putting the code in the else block when you can simply change the condition to: ((Picked unit) is in TempGroup) Equal to False

The same goes for this:

• Unit Group - Pick every unit in TempGroup and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) is in BFGroup[BFInteger]) Equal to True
      • Then - Actions
      • Else - Actions
        • Unit Group - Add (Picked unit) to BFGroup[BFInteger]
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Battle Focus Critical for (Picked unit)) Greater than 0
          • Then - Actions
          • Else - Actions
            • Unit - Add Battle Focus Book to (Picked unit)

 

[Marsal]

Oh, well it's an "old" spell. I created it when I didn't have net connection. Haven't seen the code itself long time ago, just separated it from the map. I'll check the mentioned things.
Oookay, let's see.

You can put a title like this in the first tag: [hidden=Title goes here]

I know that I can add title for hidden tags but I prefer to keep it that way. It's more cleaner for me and I guess for most of the people.
Edit: Oh now I remember why didn't I use this function at there. Because of the second unit group calling. It uses the TempGroup to check the things. That function would destroy the group before it can be checked so I've just set it to a variable.

And for triggers:
Whenever you use a unit group that does "Unit Group - Pick every unit in "Unit Group" and do (Actions)",
you can do this custom script:

• Custom script: set bj_wantDestroyGroup = true

right before the unit group is created instead of doing "call DestoryGroup(bla bla bla)"

I know ~.~ I just haven't checked the code for a while. As you can see it in my other spells I already used this function a lot.

And then while you're at it, you forgot to destroy this unit group:

• Unit Group - Pick every unit in BFGroup[BFIndex] and do (Actions)
  • Loop - Actions
    • Unit - Add Battle Focus Book to (Picked unit)

Eeerm. Nope! Chuck Testa
At the end it gets destroyed.

• Custom script: call DestroyGroup (udg_BFGroup[udg_BFInteger])

In the cast trigger (Battle Focus), when you cache (Triggering unit) and (Last created unit) into variables, why aren't you using them? It's much more efficient to use the variables instead of repeating the functions.

I just forgot to use it in the cast trigger itself but it the loop it will be used. I'll change this though.

Also:

• Unit Group - Pick every unit in BFGroup[BFInteger] and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) is in TempGroup) Equal to True
      • Then - Actions
      • Else - Actions
        • Unit Group - Remove (Picked unit) from BFGroup[BFInteger]
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Battle Focus Critical for (Picked unit)) Greater than 0
          • Then - Actions
            • Unit - Remove Battle Focus Book from (Picked unit)
          • Else - Actions

The group is never destroyed and why are you putting the code in the else block when you can simply change the condition to: ((Picked unit) is in TempGroup) Equal to False

The same goes for this:

• Unit Group - Pick every unit in TempGroup and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) is in BFGroup[BFInteger]) Equal to True
      • Then - Actions
      • Else - Actions
        • Unit Group - Add (Picked unit) to BFGroup[BFInteger]
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Battle Focus Critical for (Picked unit)) Greater than 0
          • Then - Actions
          • Else - Actions
            • Unit - Add Battle Focus Book to (Picked unit)

The group will be destroyed at the end.... Check the whole trigger before writing anything about it.
I'll change the else thingie.

 

[gorillabull]

ooo this is interesting, little imba but interesting

 

[jms]

youtube.com/user/RealSuperEffective