Lightning Bolt by Flame_Phoenix

[Moderator]

15:48, 11th Jun 2015
BPower:
The spell is no longer meeting the minimum standart of spell submissions
on THW.

If you wish your spell to be re-approved, change what I pointed
out in my comment

PurplePoot: It's nice (but the test map is a little overdone ), but is there really any reason to have the non-optimized one? It has bugs because it rechecks the chances several times (so the chance is actually much less than it says!), and it's much less clean/efficient.

 

[Flame_Phoenix]

Ok guys, here is the spell. I read the rules and I think it is Ok. No leaks, MUI , etc...

What do I have to do to see this spell approved ?

When will it be tested by the Mods ?

Btw, you guys are free to leave comments here, I would like to know what people think of the spell. Although it won't be changed (It will remain like the original from the campaign) it is always nice to read some cool comments.
Still, the JASS knowledge you need will be so low, that I believe everyone will be able to change it if needed.

 

[Flame_Phoenix]

Well, first of all, thx for approving the spell for the campaign =). I hope people like it and download it together with the campaign.

But as I say in the mini.tutorial: "The non-optimized code is for those who want to change the spell, but understand very few of JASS"

In other words, your optimization is perfect except but one thing: requires JASS knowledges that many people don't have.

Well, what can I say ?? it's your fault that you are a professional in jASS, not mine ... LOL =P

 

[Pyritie]

Awesome that you *finally* got this finished.

 

[Flame_Phoenix]

LOL, good maps take time !
I did my best to create this one =)

I hope you like to kill the dummy units, they are kinda fun =P

EDIT

Hey today I was so happy, that I made a print screen of THW main page and saved it !! lol !! My moment of glory shall be remembered =P

 

[PurplePoot]

It's still there, by the way.

In other news, you should at least fix the problem of the chances re-checking several times (in your longhand version) - save the three results in boolean variables.

 

[Flame_Phoenix]

Well, if I do so, the "bug" will still remain there and the spell will get more complicated.
Also, that can not be considered a bug as it does not causes problems to the spell - the spells works just fine with it.

As I already said, the goal of my code is not performance (as it is in yours) but to be very simple and intuitive.

Therefore I shall not change it, because it is not a real threat to anything.

 

[Dr Super Good]

Can easilly be optimized further by re ordering condtions to prevent multi check (in opt version as other is pointless). You could also remove the need for a miss local which would up efficency greatly by re-ordering the if statements.

Overall it is an ok spell, seems not to efficent thou.

 

[Herman]

Heh, i can only imagine how simple this spell must be xD

 

[Flame_Phoenix]

=) good to see you found your way into this spell DSG.

Well, as I already explained, the point of my version is not efficiency, but to be very and really very easy to understand and modify/use. It was specially made for people who don't know JASS, or have trouble understanding it.

The second version of the spell, the optimization made by PurplePoot, has the objective of being super efficient.

I will not make any changes in my code, unless needed.

If you are a pro with JASS and look for efficiency, then you can use the opt PurplePoot made. However, for begginers I advice my code, because i doubt anyone could make a code more simple than mine.

Now the question is, why two versions ??
Well, simple, the more people use it, the more will know about Pyritie's campaign, and that's the main goal here. Make people know this campaign exists and give them the incentive to play it.

Btw, thx for the comment Herman =)

 

[Flame_Phoenix]

Well, I've finally updated this resource, and decided to remove the not optimizated version.
The optimized code is commented enough for people to understand what is going on.

I hope you people like the spell, and download the campaign.

Cya all, Flame_Phoenix

 

[constellcreate]

i say this is pretty good , but the third effect - 3 - to instantly kill the target.
<-- aint this a little bit to strong? what if people want to add this spell into a hero arena game? One hit killing a hero is too rig, aint it? You should think of a different effect other than this one.

 

[Flame_Phoenix]

i say this is pretty good , but the third effect - 3 - to instantly kill the target.
<-- aint this a little bit to strong? what if people want to add this spell into a hero arena game? One hit killing a hero is too rig, aint it? You should think of a different effect other than this one.

No it is not too strong. First because it is balanced with the "miss chance". Second, because if you don't like it, you can just set it's chance to zero, and it will never occur. That's is why the spell is JESP =)

 

[constellcreate]

emm ok i guess

 

[BPower]

Re-moderated by BPower

AbilityId, DummyId, etc ... everyrthing which may change after importing the spell into a new map should be configurable via constant function call.

i.e.
constant function LB_Ability takes nothing returns integer

TriggerSleepAction can be very inaccurate and should be avoided in public resources.
Especially when dealing with timed buffs like stun or slow.

There is a constant representing the value of pi with is bj_PI and should be used instead of 3.14....

You do not apply timed life to the dummy unit in all cases, but always create one.
That's a major mistake!

Hardcoded spells are very hard to setup, that's why we always support a configuration block.

I will set this spell back to need fix ( after 7 years beeing approved ) oO