leaks?! help!!

kirtap1001 · Nov 17, 2010

Hi

I'm not often write in forum but my map laggs a bit and i think it is somthing that calls "Leaks"... i am not very good at this so i maby thought sombady could help me :grin:

I will try to learn about the leaks... sooner....
+Rep to the helper....

So is this trigger leaks?! i have try "leak cheacker" and it dosent find anything...

Start
- Events
  - Unit - A unit Begins casting an ability
- Conditions
  - (Ability being cast) Equal to Shot
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - AR_Arrowsss Less than 28
    - Then - Actions
      - Set AR_Arrowsss = (AR_Arrowsss + 1)
    - Else - Actions
      - Set AR_Arrowsss = 1
  - Set AR_speed = 8.00
  - Set AR_Caster[AR_Arrowsss] = (Casting unit)
  - Set AR_Point[AR_Arrowsss] = (Target point of ability being cast)
  - Set AR_Point_Caster[AR_Arrowsss] = (Position of AR_Caster[AR_Arrowsss])
  - Set AR_Angel[AR_Arrowsss] = (Angle from AR_Point_Caster[AR_Arrowsss] to AR_Point[AR_Arrowsss])
  - Set AR_Angel[AR_Arrowsss] = (Angle from AR_Point_Caster[AR_Arrowsss] to AR_Point[AR_Arrowsss])
  - Wait 0.20 seconds
  - Unit - Create 1 Magic Ball for (Owner of AR_Caster[AR_Arrowsss]) at (AR_Point_Caster[AR_Arrowsss] offset by 40.00 towards AR_Angel[AR_Arrowsss] degrees) facing AR_Angel[AR_Arrowsss] degrees
  - Set AR_Arrow[AR_Arrowsss] = (Last created unit)
  - Wait 1.00 seconds
  - Unit - Remove AR_Arrow[AR_Arrowsss] from the game

And this

Move
- Events
  - Time - Every 0.01 seconds of game time
- Conditions
- Actions
  - For each (Integer A) from 1 to 30, do (Actions)
    - Loop - Actions
      - Set AR_Point_Arrow[(Integer A)] = ((Position of AR_Arrow[(Integer A)]) offset by AR_speed towards AR_Angel[(Integer A)] degrees)
      - Unit - Move AR_Arrow[(Integer A)] instantly to AR_Point_Arrow[(Integer A)]

baassee · Nov 17, 2010

Yeah it leaks, second the trigger shouldn't run at 0.01, 0.03 is fine.

First leak

Create 1 Magic Ball for (Owner of AR_Caster[AR_Arrowsss]) at (AR_Point_Caster[AR_Arrowsss] offset by 40.00 towards AR_Angel[AR_Arrowsss] degrees)

Second leak

Set AR_Point_Arrow[(Integer A)] = ((Position of AR_Arrow[(Integer A)]) offset by AR_speed towards AR_Angel[(Integer A)] degrees)

and also you don't remove the locations.

Maker · Nov 17, 2010

Set AR_Point[AR_Arrowsss] = (Target point of ability being cast)
Set AR_Point_Caster[AR_Arrowsss] = (Position of AR_Caster[AR_Arrowsss])
Wait 0.20 seconds
Unit - Create 1 Magic Ball for (Owner of AR_Caster[AR_Arrowsss]) at (AR_Point_Caster[AR_Arrowsss] offset by 40.00 towards AR_Angel[AR_Arrowsss] degrees) facing AR_Angel[AR_Arrowsss] degrees
Wait 1.00 seconds
Custom script: call RemoveLocation(udg_AR_Point[udg_AR_Arrowsss]
Custom script: call RemoveLocation(udg_AR_Point_Caster[udg_AR_Arrowsss]

^Point with offset leaks too.

Do like this:

Set point1 = Position of...
Set point2 = point1 offset by...
Create unit at point2

Move
- Events
  - Time - Every 0.01 seconds of game time
- Conditions
- Actions
  - For each (Integer A) from 1 to 30, do (Actions)
    - Loop - Actions
      - Set AR_Point_Arrow[(Integer A)] = ((Position of AR_Arrow[(Integer A)]) offset by AR_speed towards AR_Angel[(Integer A)] degrees)
      - Unit - Move AR_Arrow[(Integer A)] instantly to AR_Point_Arrow[(Integer A)]

^The offset point must be set to a variable too, and clear the leaks using custom scripts.

kirtap1001 · Nov 17, 2010

Ok, Maker and Baassee... i will try... if i dont make it i will post back :wink:

And I post back if it works :grin:

baassee · Nov 17, 2010

Do so.

kirtap1001 · Nov 17, 2010

Ok I dont understand the last trigger leak... and i don't know if i have fix the other leak?!
but is this correct?!

Start
- Events
  - Unit - A unit Begins casting an ability
- Conditions
  - (Ability being cast) Equal to Shot
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - AR_Arrowsss Less than 28
    - Then - Actions
      - Set AR_Arrowsss = (AR_Arrowsss + 1)
    - Else - Actions
      - Set AR_Arrowsss = 1
  - Set AR_speed = 24.00
  - Set AR_Caster[AR_Arrowsss] = (Casting unit)
  - Set AR_Point[AR_Arrowsss] = (Target point of ability being cast)
  - Set AR_Point_Caster[AR_Arrowsss] = (Position of AR_Caster[AR_Arrowsss])
  - Set AR_Angel[AR_Arrowsss] = (Angle from AR_Point_Caster[AR_Arrowsss] to AR_Point[AR_Arrowsss])
  - Set AR_Angel[AR_Arrowsss] = (Angle from AR_Point_Caster[AR_Arrowsss] to AR_Point[AR_Arrowsss])
  - Set AR_Spawn[AR_Arrowsss] = (AR_Point_Caster[AR_Arrowsss] offset by 40.00 towards AR_Angel[AR_Arrowsss] degrees)
  - Wait 0.20 seconds
  - Unit - Create 1 Magic Ball for (Owner of AR_Caster[AR_Arrowsss]) at AR_Spawn[AR_Arrowsss] facing AR_Angel[AR_Arrowsss] degrees
  - Set AR_Arrow[AR_Arrowsss] = (Last created unit)
  - Wait 1.00 seconds
  - Unit - Remove AR_Arrow[AR_Arrowsss] from the game
  - Custom script: call RemoveLocation(udg_AR_Point[udg_AR_Arrowsss])
  - Custom script: call RemoveLocation(udg_AR_Point_Caster[udg_AR_Arrowsss])

And i don't get this one?! what is leaking?!?!

Move
- Events
  - Time - Every 0.03 seconds of game time
- Conditions
- Actions
  - For each (Integer A) from 1 to 30, do (Actions)
    - Loop - Actions
      - Set AR_Point_Arrow[(Integer A)] = ((Position of AR_Arrow[(Integer A)]) offset by AR_speed towards AR_Angel[(Integer A)] degrees)
      - Unit - Move AR_Arrow[(Integer A)] instantly to AR_Point_Arrow[(Integer A)]

baassee · Nov 17, 2010

This leaks: (Position of AR_Arrow[(Integer A), also you don't remove that variable.

kirtap1001 · Nov 17, 2010

What is the custom script to remove this points?!

Set AR_Arrow_Point[(Integer A)] = (Position of AR_Arrow[(Integer A)])

AR_Arrow_Point[(Integer A)]

and

Set AR_Point_Arrow[(Integer A)] = (AR_Arrow_Point[(Integer A)] offset by AR_speed towards AR_Angel[(Integer A)] degrees)

AR_Point_Arrow[(Integer A)]

baassee · Nov 17, 2010

These two lines

call RemoveLocation(udg_AR_Arrow_Point[bj_forLoopAIndex])
call RemoveLocation(udg_AR_Point_Arrow[bj_forLoopAIndex])

in custom script as you did with one

defskull · Nov 18, 2010

And, please, avoid using Waits
It may decrease the performance of the Trigger

Maker · Nov 18, 2010

^There's nothing wrong with using wait if you know when you can use them.

They don't really decrease performance per se.

baassee · Nov 18, 2010

They can break the MUI part if used wrong as said above

kirtap1001 · Nov 18, 2010

Finish!
Here is the finish triggers... Hope it is correct....

Start
- Events
  - Unit - A unit Begins casting an ability
- Conditions
  - (Ability being cast) Equal to Shot
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - AR_Arrowsss Less than 28
    - Then - Actions
      - Set AR_Arrowsss = (AR_Arrowsss + 1)
    - Else - Actions
      - Set AR_Arrowsss = 1
  - Set AR_speed = 24.00
  - Set AR_Caster[AR_Arrowsss] = (Casting unit)
  - Set AR_Point[AR_Arrowsss] = (Target point of ability being cast)
  - Set AR_Point_Caster[AR_Arrowsss] = (Position of AR_Caster[AR_Arrowsss])
  - Set AR_Angel[AR_Arrowsss] = (Angle from AR_Point_Caster[AR_Arrowsss] to AR_Point[AR_Arrowsss])
  - Set AR_Angel[AR_Arrowsss] = (Angle from AR_Point_Caster[AR_Arrowsss] to AR_Point[AR_Arrowsss])
  - Set AR_Spawn[AR_Arrowsss] = (AR_Point_Caster[AR_Arrowsss] offset by 40.00 towards AR_Angel[AR_Arrowsss] degrees)
  - Wait 0.20 seconds
  - Unit - Create 1 Magic Ball for (Owner of AR_Caster[AR_Arrowsss]) at AR_Spawn[AR_Arrowsss] facing AR_Angel[AR_Arrowsss] degrees
  - Set AR_Arrow[AR_Arrowsss] = (Last created unit)
  - Wait 1.00 seconds
  - Unit - Remove AR_Arrow[AR_Arrowsss] from the game
  - Custom script: call RemoveLocation(udg_AR_Point[udg_AR_Arrowsss])
  - Custom script: call RemoveLocation(udg_AR_Point_Caster[udg_AR_Arrowsss])
  - Custom script: call RemoveLocation(udg_AR_Spawn[udg_AR_Arrowsss])

And

Move
- Events
  - Time - Every 0.03 seconds of game time
- Conditions
- Actions
  - For each (Integer A) from 1 to 30, do (Actions)
    - Loop - Actions
      - Set AR_Arrow_Point[(Integer A)] = (Position of AR_Arrow[(Integer A)])
      - Set AR_Point_Arrow[(Integer A)] = (AR_Arrow_Point[(Integer A)] offset by AR_speed towards AR_Angel[(Integer A)] degrees)
      - Unit - Move AR_Arrow[(Integer A)] instantly to AR_Point_Arrow[(Integer A)]
      - Custom script: call RemoveLocation(udg_AR_Arrow_Point[bj_forLoopAIndex])
      - Custom script: call RemoveLocation(udg_AR_Point_Arrow[bj_forLoopAIndex])

baassee · Nov 18, 2010

It's not good but it's a nice start. No leaks what I could see but change the "casting unit" to "triggering unit" and the begins casting an ability to starts an effect of an ability.

kirtap1001 · Nov 18, 2010

OK... But thanx fore the help

+Rep

baassee · Nov 18, 2010

You're welcome.

leaks?! help!!

Similar threads