Leaking Maps

[Shadow Fury]

I'm posting this thread due to the inactivity of the group and because I want to discuss something with you.
Recently, I'm getting maps which are full of leaks but that do not cause heavy lag after playing for a long time or let me take 10 minutes to quit from the game. According to our dear map submission rules, such maps should be rejected because they are not mostly leakless yet I think they can be approved if the game is lagless.
What do you think guys?

 

[StoPCampinGn00b]

Mostly could mean 51% leakless. If a map isn't work in properly due to lag, fatal errors, and such, then I (or we?) will check for leaks. If not, it's fine.

Do remember, however, that many leaks affect the map over time. So a massive map that offers hours of gameplay hould get checked.

 

[Daffa]

The prime targets are these triggers (and we know HOW BAD it will end if not checked) :
Timed Triggers (Repetitive ones like unit spawns in AOS)
Actively Used Triggers (Chain from one to another <Jass Case>, Item Manipulations, General Unit Events, etc)

These 2 kinds of triggers, if leaked will be worse than you can expect in the long run. They should be abolished as much as possible.

It's also recommended to stay away from spamming unit spawns due to their permanent leaks (the unit leaks some byte AFAIR), and a little harsh one : disallow terrain deformations due to their permanent leaks (main case : SHOCKWAVE <capped that on purpose>).

 

[Chaosy]

Save yourself some trouble and don't judge triggers AT ALL.

Why? Because you don't know what the f*ck you're doing (take that with a BIG grain of salt!). In GUI you know enough to point out most leaks. But if a map is done in vjass you wont be able to judge at all so you'll just assume that it doesn't leak. That will just be unfair, so just don't judge it.

 

[Shadow Fury]

In fact, I rarely judge triggers. Only if the map lags heavily or there are some serious bugs I have a look at them. Otherwise, it's like if they do not exist for me.

 

[Ardenian]

Yeah, I noticed that, Shadow Fury. The Ice Wars Defence map I reviewed and you approved recently had many leaking issues, as far as I know.
I am not sure about the 51% mark, but it included many leaks.

I did not notice any lag tho, but not judging it at all means that the creators are not going fix the leaks in future projects and then the leaks might be a problem.
Telling them about the leaks and creating some kind of pressure might be recommended to avoid that map creators do the same 'mistake' again and again until it causes a problem.

 

[Chaosy]

I did not notice any lag tho, but not judging it at all means that the creators are not going fix the leaks in future projects and then the leaks might be a problem.
Telling them about the leaks and creating some kind of pressure might be recommended to avoid that map creators do the same 'mistake' again and again until it causes a problem.

In a perfect world, you're right. But if you choose to judge triggers there are more than one issue that comes with it.

1. The map mods need to be extremely good at GUI to catch every single leak (on a level of a spell mod actually). Otherwise the statistics will be invalid. If the moderator finds 30 leaks and the moderator also see that he cleared 30 leaks location leaks. So 50%. However, if I a spell mod would review it he would like find 10x more errors and improvements in those triggers (take this from someone who got a few rejected things in the spell section xD). Making it more like 5% of the leaks were removed.

2. Not to mention that now the map mods needs to be adapt in jass, vjass and even WURST since that's supported too.

3. There's also the time issue, going through every single trigger in a huge map will take more time than actually playing the map. You simply don't want to go through all triggers in a map like, let's say Iceborn.

 

[Daffa]

The easiest way is to only check WHEN it's necessary.
Else, pretend nothing happens.

"Keep it Simple"

 

[Shadow Fury]

That's what I always do Daffa. Only checking the triggers when really necessary. Since deciphering the massive number of triggers, understanding them and eventually estimating the quantity of leaks present would let me review one map every week, I prefer not to judge triggers if possible.