Knockup system GUI

[Moderator]

Knockup system GUI | Reviewed by Maker | 17th Feb 2013

APPROVED

Simple to use and useful. Suggested changes Do this only if KUS_knockup is true, it can cause leaks otherwise If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Current flying height of KUS_target) Greater than or equal to KUS_height Then - Actions Set KUS_knockup = False Custom script: call SaveBoolean(udg_KUS_hash, h, 0, udg_KUS_knockup) Else - Actions The flying height equation could be more realistic, the change in direction is a bit abrupt The system could be more configurable

[td]
[/td]

Old review

Knockup system - Reviewed by Maker - 15th Feb 2013

Needs Fix

Required changes Adding Crow Form properly Suggested changes The flying height could use better method, some equation It could look better You could set turn speed to 0 while being knocked up

[td]
[/td]

 

[Chaosy]

changed stuff
-bug fixed
-variable names changed
-added more variables
-added config
-effect, animation, speed and heigh is now set in the demo trigger insted of the init trigger
-flying units height is now reseted properly
-loop now turns of when group is empty
-changed the function name to "PrepareKnockUp"
-crow form wont be removed for units that allready got the ability
-uses unitpropwindow insted of pause unit
-added a local integer for one of the handles

 

[Maker]

• prepare is not a proper function name
• The effect, height and speed should be optional/configurable for each knockup separately
• Removing Crow Form like that will remove it from units that are supposed to have it
• Don't use Pause unit, it pauses unit also and if paused units die, it bugs a bit
• The animation should be configurable/optional
• The looping trigger should be off when there are no units to loop
• Flying units will bug with this

 

[Chaosy]

1. hm ok I will fix that
2. well it could be that but I thought it would be nice with a general height but I guess your right since you might use it to more than one spell in a map
3. did not think of that I will put it in a ITE
4. what do you suggest then? that is a good way to make sure the unit wont move somewhere. should I move it to the original location insted?
5. true, will do
6. hm, if I set the units fly height to default and its a ground unit it will be set to 0 right?

 

[Maker]

4. what do you suggest then? that is a good way to make sure the unit wont move somewhere. should I move it to the original location insted?
6. hm, if I set the units fly height to default and its a ground unit it will be set to 0 right?

4. Custom script: call SetUnitPropWindow(unit, 0)
Reset it with SetUnitPropWindow(unit, GetUnitDefaultPropWindow(unit))
6. Yes, it should work like that.

 

[Chaosy]

-effect, animation, speed and heigh is now set in the demo trigger insted of the init trigger
-flying units height is now reseted properly
-loop now turns of when group is empty
-changed the function name to "PrepareKnockUp"
-crow form wont be removed for units that allready got the ability

@maker what do that script do I have never used i before.

to do:
add a local integer for hashtable key
find a better way to stun the unit

 

[gorillabull]

knockup means to get some 1 to have a baby knock back means to push something back

 

[Magtheridon96]

The PropWindow function stops the unit from moving.
Try it.

 

[Chaosy]

that seems to work fine, I use 0 to stun and 1 to unstun there is no problem with that?

 

[Matarael]

So this basically is a function for an impale-like spell/ability? Please let it be that...

 

[Chaosy]

Yes.

 

[Wolf_Wing]

[QUOTE="gorillabull']knockup means to get some 1 to have a baby[/QUOTE]
yeah i translate it to some translater and...... yes that the mean like gorillabull say

 

[Almia]

• -------- DON*T TOUCH BELLOW --------
• Custom script: set udg_KUS_hash = InitHashtable()
• Skip remaining actions
• Custom script: endfunction

eh?

functions should have prefixes in their names(that's because we dont have privates)

This would be better if this uses Physics so much,just like my old knockback 3D hayss

hmm,because i remember my KB3D,i should start fixing it as well

 

[Chaosy]

I don't get what you mean ;(

 

[Almia]

Skip remaining actions
why did you use it?It doesnt even have any use!
Prefixes means letters before a certain word to add meaning.Like : (Re)Cycle

 

[Chaosy]

else the prepare function will run at init which is only waste of memory.

 

[Chaosy]

updated.

1. created a new trigger insted of a function inside the init trigger
2. the hashtble is now created in GUI this fixed a import issue since it did not copy the variable correctly.

less jass yay

 

[Marcos DAB]

You could add things like damage when landing, and special effects when flying with few lines of code.

Overall seems pretty good and very useful.

 

[Chaosy]

I could indeed do that, tho the damage will be hard to trigger since it depend on the spell using the system.

thanks for the comment tho