Knockback Unit

[Deaod]

GetLocationZ has the ability to desync.

 

[Silvenon]

Is it possible to detect cliffs with the terrain-type check? You know, how you detect other terrain types.

 

[Deep Sea Kraken]

function Test takes nothing returns nothing
    local unit c = GetTriggerUnit()
    local unit t = GetSpellTargetUnit()
    local real x1 = GetUnitX(c)
    local real y1 = GetUnitY(c)
    local real x2 = GetUnitX(t)
    local real y2 = GetUnitY(t)
    local real dist = 500
    local real angle = Atan2(y2 - y1, x2, x1)
    local real dur = 2
    call Knockback(t, dist, angle, dur)
    set c = null
    set t = null
endfunction

Shouldn't the line

local real angle = Atan2(y2 - y1, x2, x1)

Be

local real angle = Atan2(y2 - y1, x2 - x1)

?

 

[DKG]

Shouldn't the line

local real angle = Atan2(y2 - y1, x2, x1)

Be

local real angle = Atan2(y2 - y1, x2 - x1)

?

Yeah it should, but thats easy to figure out when you chuck it in and jasshelper tells you you're passing too many arguments.

 

[Deep Sea Kraken]

><, also, any reason why this code gives me a @$#%load of syntax errors, each one saying that theres a line outside a function?

And yes, I have the latest ver of NewGen

 

[DKG]

Are you using NewGen world editor? Need Jasshelper or it'll throw a fit.

 

[Deep Sea Kraken]

And yes, I have the latest ver of NewGen

I alrdy said I do, and I put it in JASSCraft, and I get the same problem.

Does this require anything else? Like Caster System or something?

Also, I think a cool think to add would be an UPWARD (as in aeriel) aspect to this knockback, because there pretty much aren't any knockbacks that do that.

i.e: most knockback functions pretty much look like this: ____ (as the path), but one that went like this .-`-. would be rather unique and really cool.

 

[DKG]

Well I just chucked it into a new map and everything compiled just fine, not sure whats wrong with yours.

I'm assuming you copied everything correctly, put it into its own trigger etc?

 

[Deep Sea Kraken]

If it coppied and theres like 2 spaces between every line would that mess it up?

 

[DKG]

Try quoting the post, and copying the raw code, apparently that can be a problem for some people.

 

[Deep Sea Kraken]

I dd quote it and copied it ><, still doesnt work, The very first error I get in a syntax error, which might be causing the rest of the problems

library Knockback initializer Init

Is the first line

 

[DKG]

Looks exactly the same as mine ><

whats the specifics of the syntax error?

 

[Deep Sea Kraken]

Just says syntax error..........Lol, then after that it gives me an error that is the same for every single line of code: call made outside a function

 

[Silvenon]

Of course JassCraft returns an error, it doesn't have the vJass syntax, I thought that was already known.

Thanks for pointing the Test error out. Everything should be fine, if your syntax checker doesn't recognize libraries, then something is obviously wrong with it.

 

[HINDYhat]

Deep See Kraiken, be sure you click Save before Test, so there is no little star next to the map's name on the top bar in World Edit, when you test the map.

 

[Deep Sea Kraken]

.....I know how to properly test maps.
Also, WE doesn't even LET me test the map, just like Warcraft wont let me play the map.
And this knockback function is the only new thing I added, it worked perfectly fine before.

Also, I used the integrate WeU funtion of the NewGen editor, I'll see if turning that off makes any difference.

 

[Vercas]

Lol

It doesn't works for me, look here at the attached image, please ask me where's my mistake!!!

 

[Deaod]

youd better use "Angle between Points" than facing of Unit.

But i think your problem lies within your Condition. You should change "(Hero manipulating Item)" to "(Attacking Unit)".

 

[Vercas]

LOl.... I'l try... But i think not that's the problem...

 

[Vercas]

It does not work, not that was the problem!!!

 

[Silvenon]

I added you on MSN, so we should better talk there.

 

[Vercas]

Great! I realy like to use my messenger to talk!

 

[Bobo_The_Kodo]

        set dat.u = u
        set dat.u = u

Fix that..

 

[Silvenon]

Done, thanks.

 

[Vercas]

NOW, Silvenon, when will you use the messenger to talk to me? I realy did waht you sayd, even with JASS and it does not works, i copyed it exactly! i modified what i needed... Still does not works... I've stupidly deleted the knockback trigger...

 

[Bobo_The_Kodo]

            if (x < MAX_X and y < MAX_Y and x > MIN_X and y > MIN_Y) and not BoolAr[1] then
                call SetUnitX(dat.u, x)
                call SetUnitY(dat.u, y)
            endif

            set dat.d1 = dat.d1 - dat.d2

            if dat.d1 <= 0 or (x > MAX_X or y > MAX_Y or x < MIN_X or y < MIN_Y) or BoolAr[1] then
                set Ar[i] = Ar[Total - 1]
                set Total = Total - 1

                call dat.destroy()
            endif

->

            if dat.d1 <= 0 or (x > MAX_X or y > MAX_Y or x < MIN_X or y < MIN_Y) or BoolAr[1] then
                set Ar[i] = Ar[Total - 1]
                set Total = Total - 1

                call dat.destroy()
            else
                call SetUnitX(dat.u, x)
                call SetUnitY(dat.u, y)
            endif

More efficient (tho very slightly), and doesn't slide partially into the wall on the last interval, also, won't this go through cliffs?

You could do

            if dat.d1 <= 0 or (x > MAX_X or y > MAX_Y or x < MIN_X or y < MIN_Y) or BoolAr[1] or IsTerrainPathable( x, y, PATHING_TYPE_WALKABILITY ) == false then

(IsTerrainPathable is bugged and returns the opposite of what it should, thats why I put == false)

Soo, overall, change what i Quoted from yours to:

            if dat.d1 <= 0 or (x > MAX_X or y > MAX_Y or x < MIN_X or y < MIN_Y) or BoolAr[1] or IsTerrainPathable( x, y, PATHING_TYPE_WALKABILITY ) == false then
                set Ar[i] = Ar[Total - 1]
                set Total = Total - 1

                call dat.destroy()
            else
                call SetUnitX(dat.u, x)
                call SetUnitY(dat.u, y)
            endif

 

[Silvenon]

I think it's not the same, since there is an and.

About that pathable terrain thing, I did that in a different way.

 

[lightphoenix2]

How do i import JASS file as i keeping getting errors saying that there is missing value.

 

[NoobinJass]

How do i import JASS file as i keeping getting errors saying that there is missing value.

May be because it need some variables

 

[lightphoenix2]

yar , but i dont know how to do it.

 

[NoobinJass]

yar , but i dont know how to do it.

what do you mean don't know? you don't know how to create variables?

 

[Vercas]

Lol )))))

 

[DPL]

You all are talking nosense !
This sistem is great . Easy to understand

 

[Saishy]

* unit u = the unit being knockbacked
* real d = the distance the unit is knockbacked to
* real a = the angle (direction of the knockback) in RADIANS
* real w = the duration of the knockback
* real r = the radius of tree destroying, but there's a new trick: if you put a negative number as the radius, the unit will stop knockbacking when it gets in that range of a tree and if you put a positive value, the unit will destroy trees when it gets in that range of a tree (if you don't want any of those, just put 0)
* integer t = type 0 means no effect (both s and p should be ""), type 1 means periodic effect (meaning you should put "" as the attachment point, parameter p), type 2 means a special effect attached on the unit and destroyed when the knockback is finished (this is where you use parameter p)
* string s = the path to the special effect you want to use (periodic), that effect will be destroyed immediatelly (you can put "" if you don't want a special effect)
* string p = used for type 2, it's the attachment point of the effect, "chest" is default (so if you put "", it will be "chest")

I can only use (u, d, a, w) if I try to use the others input it says: "Too many arguments"
How can I fix it? Also, how can I make two attached effects instead of one?
Thanks

Edit1: Lolz I found it xD But how can I make it spawns two effects instead of one?
Edit2: Some tips to make it looks like the unit is pushing the floor?
Edit3: The unit still pass trough trees and walls even if I put -1 to -250 in real r.

 

[Adiktuz]

jass

how to use the jass library??? will I put it in the trigger or somewhere else?? help please, I'm noob in jass....

 

[Vercas]

Check the Tutorials section before asking this questions.

 

[Adiktuz]

where will I place the library? will I put it in one trigger or in the map custom script in the top of the trigger editor tree??????? help.... thanks... I really want to learn JASS.......

can you make the variables local instead of globals???????????

 

[Archian]

Please do not double post.

 

[Beast(TrOg)]

non-jasser here!
I need help calling it, with the special effects
I did:

• tempUnit[1] = attacked unit
• tempReal[1] = 100
• tempReal[2] = radians(angle between attacker and attacked) - im aware of the leaks
• tempReal[3] = 1.10
• custom script: call KnockbackEx(udg_tempUnit[1], udg_tempReal[1], udg_tempReal[2], udg_tempReal[3], 0, 1, "Abilities\Weapons\\AncientProtectorMissile\\AncientProtectorMissile.mdl", "")

eh, dont' know how to make the fancy trigger images...anyways please help
it's not working for some reason but I can get the Knockback(target, distance, angle, duration) to work, but I'm not sure how to correctly put in the parameters for the KnockbackEx (I want no destroying trees and periodic effect)

 

[CheatEnabled]

Hey Silvenon, Does this knockback function work with missiles?

What would i have to change to make it work for missiles? AkA how to make it detect a collision?

 

[MapperMalte]

Efficient system.
Can units slide into water?
But not very useful for GUI-users.

 

[MapperMalte]

This is bugged!
All knockback systems except mine are bugged!
You loop thorugh the knockbacks and if a knockback is finished, you decrease Total.
But:
You have knockbacks 1-4
knockback 2 finishes.
So knockback 4 stops.
wtf?
Thats just bugged!

Solution that I use:

function PushUp_Structs takes integer fromwhere returns nothing
    local integer i = fromwhere
        loop
    set i = i + 1
    exitwhen i > Total
    set Knockbackdata[i-1] = Knockbackdata[i]
        endloop
    set Total = Total - 1
endfunction

So the following first numbers are the knockbacks.
And the number after '=' is the new number of the knockback
--- means knockback ended

1 = 1
2 = ---
3 = 2
4 = 3

1 = 1
2 = ---
3 = 2

1 = 1
2 = ---

1 = ---

 

[Viikuna]

You should test it before posting lol. It works just fine.

Lets say that we have: [a] [c] [d] Total = 4

[a]=0 =1 [c]=2 [d]=3

stops:

set Ar = Ar[Total - 1]
set Ar[1] = Ar[4-1]
set Ar[1] = Ar[3]

Result: [a] [d] [c] - Total = 3


You get it?

edit. some editing..

 

[MapperMalte]

I am sorry.
You are right, I'm not.
Ill think more when I post next time.

 

[xXMephistoXx]

One thing; how do you make it the other way around? So that you drag them towards you, not push them away from you?

Because this is a really neat system with little or no bugs as far as I've tested the last version.

 

[Deaod]

use a negative d (while still using the correct angle).

 

[xXMephistoXx]

Well, i'm not a complete idot. I tried it, doesn't work...

 

[Deaod]

Replace: (method Execute)

            if dat.d1 <= 0 or (x > MAX_X or y > MAX_Y or x < MIN_X or y < MIN_Y) or BoolAr[1] then
                set Ar[i] = Ar[Total - 1]
                set Total = Total - 1

                call dat.destroy()
            endif

With:

            if ((dat.d1<=(dat.d2/2) and dat.d2>=0) or (dat.d1>=(dat.d2/2) and dat.d2<0)) or (x > MAX_X or y > MAX_Y or x < MIN_X or y < MIN_Y) or BoolAr[1] then
                set Total = Total - 1 // if im already changing his code, i might as well do some optimization
                set Ar[i] = Ar[Total]

                call dat.destroy()
            endif

And then use a negative distance.

Edit: That wont work for now....ill update when i have a solutionThat was easy.

 

[xXMephistoXx]

Worked perfectly, thanks alot =)

 

[Hordeon]

... Look at this mess... Reply please