KB3D - Knock back 3D

[T. D. W.]

:3 oh...kay

Edit: PS: gone for a bath..

 

[Vinz]

The System has 180+ comments! within just 12 days!!

*Ahem* Just like any other WEHZ group thread, KB3D got some off topic comments about japan, how the day was, and other things. So the number of comments don't really make it popular.

Anyways, Jad, go finish that function. I need it. Thanks.

 

[T. D. W.]

^^' yeah i know xD
But still the ratings are excellent

 

[chobibo]

function GetNearestUnitInGroupFromXY takes real x1, real y1, group g returns unit
    local unit u=FirstOfGroup(g)
    local real x2=GetUnitX(u)-x1
    local real y2=GetUnitY(u)-y1
    local real dist1=SquareRoot(x2*x2+y2*y2)
    local real dist2
    
    set bj_ghoul[0]=u // Replace with a global variable you defined
    
    loop
        set u=FirstOfGroup(g)
        exitwhen u==null
        set x2=GetUnitX(u)-x1
        set y2=GetUnitY(u)-y1
        set dist2=SquareRoot(x2*x2+y2*y2)
        if (dist1>dist2) then
            set dist1=dist2
            set bj_ghoul[0]=u // Replace with a global variable you defined
        endif
        call GroupRemoveUnit(g,u)
    endloop
   
    set u=null
    return bj_ghoul[0] // Replace with a global variable you defined
endfunction

EDIT: I still don't like FirstOfGroup loops, there's a critical bug with that method but it doesn't affect instant groups like this one.

 

[T. D. W.]

can't it be like this:

function GetNearestUnitInGroupFromXY takes real x1, real y1, group g returns unit
    local unit u=FirstOfGroup(g)
    local real x2=GetUnitX(u)-x1
    local real y2=GetUnitY(u)-y1
    local real dist1=SquareRoot(x2*x2 + y2*y2) // there should be a 'space' here to prevent the (x2*x2) to be added to y2 and then the sum will be multiplied by y2
    local real dist2
    local unit U=u
   
    loop
        set u=FirstOfGroup(g)
        exitwhen u==null
        set x2=GetUnitX(u)-x1
        set y2=GetUnitY(u)-y1
        set dist2=SquareRoot(x2*x2+y2*y2)
        if (dist1>dist2) then
            set dist1=dist2
            set U=u
        endif
        call GroupRemoveUnit(g,u)
    endloop
   
    set u=null
    return U
endfunction

 

[chobibo]

You don't need to initialize dist2 upon declaration, it's initialized in the loop. And U will leak the reference (handle id) it's holding, you need to use a global variable to not leak the reference.

EDIT: Error's like that occur if you use the variable in math ops or conditional statements. May I ask who taught you that?
EDIT: No spaces are needed, multiplication and division is always evaluated first before addition and subtraction. I remember that's called precedence, I believe this is also true for c and c++.

 

[T. D. W.]

I edited the post, removing the dist 2 init
okay for the U
I saw in the JPAG i think bribe saying that maths operations that are separated by a space will execute last, but maybe it will act like you said

maybe like this:

function GetNearestUnitInGroupFromXY takes unit U, real x1, real y1, group g returns unit
    local unit u=FirstOfGroup(g)
    local real x2=GetUnitX(u)-x1
    local real y2=GetUnitY(u)-y1
    local real dist1=SquareRoot(x2*x2 + y2*y2)
    local real dist2
   
    loop
        set u=FirstOfGroup(g)
        exitwhen u==null
        set x2=GetUnitX(u)-x1
        set y2=GetUnitY(u)-y1
        set dist2=SquareRoot(x2*x2+y2*y2)
        if (dist1>dist2) then
            set dist1=dist2
            set U=u
        endif
        call GroupRemoveUnit(g,u)
    endloop
   
    set u=null
    return U
endfunction

function Call takes group g returns nothing
    local unit U
    local real x = 0
    local real y = 0
    local unit u = GetNearestUnitInGroupFromXY(U, x, y, g)

 

[chobibo]

Not that, JPAG standard suggests that you provide spaces in them for readability, so you should follow it if you're going to submit it here.

function Call takes group g returns nothing
    local real x = 0
    local real y = 0
    local unit u = GetNearestUnitInGroupFromXY(u, x, y, g)

That's valid too, one less variable. If only jass allowed pointers lol.

EDIT: yeah, I forgot to tell you in my previous post that you should also initialize variables that are going to be passed to functions (passed as arguments). Malhorne must be busy...

 

[T. D. W.]

oh ^^' check the edit

 

[chobibo]

bump

 

[T. D. W.]

okay!

Wrathion you can have the function now!

 

[chobibo]

You should post the revised script Jad, Wrathion might be confused which one to copy.

 

[T. D. W.]

Here:

// First unit argument can be any null unit
// Final argument group (g) is the group where the function is called (something like this [the explanation]
function GetNearestUnitInGroupFromXY takes unit U, real x1, real y1, group g returns unit
    local unit u=FirstOfGroup(g)
    local real x2=GetUnitX(u)-x1
    local real y2=GetUnitY(u)-y1
    local real dist1=SquareRoot(x2*x2 + y2*y2)
    local real dist2
   
    loop
        set u=FirstOfGroup(g)
        exitwhen u==null
        set x2=GetUnitX(u)-x1
        set y2=GetUnitY(u)-y1
        set dist2=SquareRoot(x2*x2+y2*y2)
        if (dist1>dist2) then
            set dist1=dist2
            set U=u
        endif
        call GroupRemoveUnit(g,u)
    endloop
   
    set u=null
    return U
endfunction

//Example Usage:

function Call takes group g returns nothing
    local unit U
    local real x = 0
    local real y = 0
    set U = GetNearestUnitInGroupFromXY(U,x,y,g)
endfunction

 

[chobibo]

set dist2=SquareRoot(x2*x2 + y2*y2) for the JPAG stuff.

EDIT: You forgot this:

    local real dist2
    set U=FirstOfGroup(g)
    call GroupRemoveUnit(g,u)
    loop
        set u=FirstOfGroup(g)

You need to set the first unit, so that when it is the nearest, it won't return null, I added the remove from group call to avoid redundancy.

 

[T. D. W.]

this can easily be done also by this:

// First unit argument can be any null unit
// Final argument group (g) is the group where the function is called (something like this [the explanation]
function GetNearestUnitInGroupFromXY takes unit U, real x1, real y1, group g returns unit
    local unit u=FirstOfGroup(g)
    local real x2=GetUnitX(u)-x1
    local real y2=GetUnitY(u)-y1
    local real dist1=9999999999
    local real dist2
   
    loop
        set u=FirstOfGroup(g)
        exitwhen u==null
        set x2=GetUnitX(u)-x1
        set y2=GetUnitY(u)-y1
        set dist2=SquareRoot(x2*x2+y2*y2)
        if (dist1>dist2) then
            set dist1=dist2
            set U=u
        endif
        call GroupRemoveUnit(g,u)
    endloop
   
    set u=null
    return U
endfunction

//Example Usage:

function Call takes group g returns nothing
    local unit U
    local real x = 0
    local real y = 0
    set U = GetNearestUnitInGroupFromXY(U,x,y,g)
endfunction

 

[chobibo]

My solution just looks ugly since you need to pick the first unit as the default choice, but in truth it doesn't do a needless comparison.

If you use that one, the first comparison is useless(this was the needless comparison I was talking about), as it will always be set as the first nearest unit. It just looks clean but it actually isn't.

 

[T. D. W.]

isn't it the same with setting U to first of group Oo
since the x2 and y2 will be the same, the first comparison will be useless too XD
correct me if i'm wrong

 

[chobibo]

Yes, you're wrong, the loop will actually loop N-1 times in the group list, while that thing would loop N times.

lets say the group has 5 units.

my method:

1. compute dist; 1st unit is default;
2. loop
3. compute dist; compare 1 to 2
4. compute dist; compare 1 to 3
5. compute dist; compare 1 to 4
6. compute dist; compare 1 to 5

that method:

1. set dist=9999999999
2. loop
3. compute dist; compare 9999999 to 1; set 1 as default
4. compute dist; compare 1 to 2
5. compute dist; compare 1 to 3
6. compute dist; compare 1 to 4
7. compute dist; compare 1 to 5

You've wasted one comparison operation. Yes, I was a speed freak in my youth.

EDIT: Oh I forgot to add that the second method also wastes a set operation, you've set dist1 to 9999999.

jass

function GetNearestUnitInGroupFromXY takes unit U, real x1, real y1, group g returns unit
    local unit u=FirstOfGroup(g)
    local real x2=GetUnitX(u)-x1
    local real y2=GetUnitY(u)-y1
    local real dist1=SquareRoot(x2*x2 + y2*y2)
    local real dist2

    set U=u
    call GroupRemoveUnit(g,u)

    loop
        set u=FirstOfGroup(g)
        exitwhen u==null
        set x2=GetUnitX(u)-x1
        set y2=GetUnitY(u)-y1
        set dist2=SquareRoot(x2*x2 + y2*y2)
        if (dist1>dist2) then
            set dist1=dist2
            set U=u
        endif
        call GroupRemoveUnit(g,u)
    endloop
   
    set u=null
    return U
endfunction

//Example Usage:

function Call takes group g returns nothing
    local unit U
    local real x = 0
    local real y = 0
    set U = GetNearestUnitInGroupFromXY(U,x,y,g)
endfunction

 

[T. D. W.]

Then it should be like this: (yours)

    set U=FirstOfGroup(g)
    call GroupRemoveUnit(g,U)//U not u

And in your edit, you use x and y variables (they are not declared

 

[chobibo]

I was still editing, sorry about that.

EDIT: Okay fixed it now.

 

[T. D. W.]

So i am right with switching u by U right?

 

[chobibo]

Nah, but you can if you want to, I revised it:

jass

function GetNearestUnitInGroupFromXY takes unit U, real x1, real y1, group g returns unit
    local unit u=FirstOfGroup(g)
    local real x2=GetUnitX(u)-x1
    local real y2=GetUnitY(u)-y1
    local real dist1=SquareRoot(x2*x2 + y2*y2)
    local real dist2

    set U=u
    call GroupRemoveUnit(g,u)

    loop
        set u=FirstOfGroup(g)
        exitwhen u==null
        set x2=GetUnitX(u)-x1
        set y2=GetUnitY(u)-y1
        set dist2=SquareRoot(x2*x2 + y2*y2)
        if (dist1>dist2) then
            set dist1=dist2
            set U=u
        endif
        call GroupRemoveUnit(g,u)
    endloop
   
    set u=null
    return U
endfunction

//Example Usage:

function Call takes group g returns nothing
    local unit U
    local real x = 0
    local real y = 0
    set U = GetNearestUnitInGroupFromXY(U,x,y,g)
endfunction

 

[T. D. W.]

Okay, i say we're done

 

[chobibo]

Good luck dude, where do you need this shit anyways?

 

[T. D. W.]

For the bounce feature, since the feature works needing just on unit, if by luck, there is or more units in the area around the unit it is better to choose the closest and not all or a random one, especially if also by luck the AoE (collision size of the unit x 2.5) is big

 

[chobibo]

Cool, my old shit getting used on something cool. EDIT: Thanks man.

 

[T. D. W.]

lol, something useful will always be used =D

 

[T. D. W.]

It's getting late for me, but still:
There is a problem with 'loops' in KB3D, normal WE
i know you guys will have to open the orld WE but the problem is .. From compatibility issues.. I hope you guys can find out the problems.. I go to sleep now.. :/

 

[chobibo]

what problem?

 

[Malhorne]

Yes what problem ?

 

[T. D. W.]

Didn't you try to open it in the normal WE?
Unexcpected loops and exitwhens appear on all loops, k now i will go to skl xD

 

[chobibo]

Nothing like that popped up when I used it, unless you've updated it again.

 

[T. D. W.]

It's the 1.7.1
Check it, i remember the 1.7.0 didn't do that

 

[Malhorne]

Pop the code pls

 

[chobibo]

I used 1.7.1 on Malstomp, no errors though.

 

[Malhorne]

Ahah you really coded Malstomp ?
Need map ^^

 

[chobibo]

Malstomp WIP

 

[Malhorne]

I'll see it when I'll have the time

 

[T. D. W.]

Guys seriously what can cause this problem?!

 

[chobibo]

Could you post the error here? I was serious when I said there were no errors when I tried using it.

 

[T. D. W.]

okay:
From KB3D v. 1.7.1

from KB3D v. 1.8.0 Beta

 

[Malhorne]

Why is there

if FirstOfGroup(g) == null then
else
//Blabla
endif

???

 

[T. D. W.]

if the group is empty, it will return true = the function returns a possibility to bounce (there is a unit to bounce into)

 

[Malhorne]

Prefer

if FirstOfGroup(g) != null then
//Do some stuff

In your code fix your indentation dude I don't want to say it again in the main thread of KB3D and I'll point some bugs to fix too.

 

[T. D. W.]

still

 

[chobibo]

HAHAHA! Badass moment! [link]

 

[Malhorne]

Ahah nice one chobi I didn't even see this
I wrote many things to fix thou

 

[chobibo]

Aww, shucks, thanks man... lolzerz

 

[T. D. W.]

still.. the loop problems are there, and what does indentation mean?

 

[chobibo]

what loop problems? The map I attached has none when I save it. Here's the map I attached on the thread...

EDIT: I'm using the latest version of warcraft III.