- Joined
- Aug 7, 2013
- Messages
- 1,338
Hi,
If I'm working on a large scale project and I find a grammar / spelling error in a debug message that was written by someone else (i.e. my boss), is it OK to make a commit to fix that message?
I am not sure it's very tactful or smart because:
(1) Why are you busy fixing trivial stuff instead of actually contributing new stuff to the project?
(2) A whole commit just to fix a grammar / spelling error?
My boss makes frequent spelling / grammar mistakes (but he's a linguist and by all means a genius), I never ever correct him except in the files that I also work in (where I am making actual code changes and not just changing a debug message).
So I am guessing I should only make that grammar fix if I also begin working in that file on something else? This commit otherwise would be silly:
"fixed a few spelling / grammar mistakes in the debug message"
If I'm working on a large scale project and I find a grammar / spelling error in a debug message that was written by someone else (i.e. my boss), is it OK to make a commit to fix that message?
I am not sure it's very tactful or smart because:
(1) Why are you busy fixing trivial stuff instead of actually contributing new stuff to the project?
(2) A whole commit just to fix a grammar / spelling error?
My boss makes frequent spelling / grammar mistakes (but he's a linguist and by all means a genius), I never ever correct him except in the files that I also work in (where I am making actual code changes and not just changing a debug message).
So I am guessing I should only make that grammar fix if I also begin working in that file on something else? This commit otherwise would be silly:
"fixed a few spelling / grammar mistakes in the debug message"