[JASS] is CreateUnitByName bugged?

[Ironside]

Hello, I have a trigger which should summon a unit by a string variable, using the function CreateUNitByName, however in most cases, unless it's something as simple as Grunt, the function just fails to create the unit for some reason.

Any ideas?

 

[Maker]

I recommend unit type id. Do you have any spesific reason for using the name?

 

[Ironside]

Yes, the map has ingame unit creation command, if it was with IDs a player who is not the map developer wouldn't possibly know what he's going to summon, with name it would work fine.

 

[Maker]

You can use stringhash function with hastables to convert given string into a unit type id.

 

[Ironside]

Like this?

call CreateUnit(GetTriggerPlayer(), StringHash(udg_MS10UnitName) , udg_MS10X, udg_MS10Y, 0.00)

 

[Maker]

Triggers

• Melee Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Hashtable - Create a hashtable
    • Set uht = (Last created hashtable)
    • -------- -------------------------------------------- --------
    • Set str = paladin
    • Set ut = Paladin
    • Custom script: call SaveInteger(udg_uht, StringHash(udg_str), 0, udg_ut)
    • -------- -------------------------------------------- --------
    • Set str = footman
    • Set ut = Footman
    • Custom script: call SaveInteger(udg_uht, StringHash(udg_str), 0, udg_ut)
    • -------- -------------------------------------------- --------
    • Set str = grunt
    • Set ut = Grunt
    • Custom script: call SaveInteger(udg_uht, StringHash(udg_str), 0, udg_ut)

• Untitled Trigger 001
  • Events
    • Player - Player 1 (Red) types a chat message containing create as A substring
  • Conditions
  • Actions
    • Set str = (Substring((Entered chat string), 8, (Length of (Entered chat string))))
    • Custom script: if HaveSavedInteger(udg_uht, StringHash(udg_str), 0) then
    • Custom script: set udg_ut = LoadInteger(udg_uht, StringHash(udg_str), 0)
    • Unit - Create 1 ut for (Triggering player) at (Center of (Playable map area)) facing Default building facing degrees
    • Custom script: endif

create paladin
create grunt
create footman
etc.

 

[Ironside]

But the trigger must be able to create any unit, which is over 1600 units.

 

[Xonok]

But the trigger must be able to create any unit, which is over 1600 units.

The CreateUnitByName function probably doesn't allow spaces
Try replacing every space with _
Edit: 1600 units? Warcraft doesn't have that many.

 

[Ironside]

It's a custom map, which has the default 800 and another 800 custom. I'll try the _.

 

[Dr Super Good]

Yes it is bugged. It can cause a game desynchroniztion because units have different names for different client localizations.

 

[WaterKnight]

I have the german version and it reacts only on english names. Those are not necessarily the ones you see in object editor though. For example, Hall of the Dead is "necropolis1", Black Citadel "necropolis2".

The name of custom units is "custom_" + rawId, e.g. "custom_h000".

 

[Ironside]

I have the german version and it reacts only on english names. Those are not necessarily the ones you see in object editor though. For example, Hall of the Dead is "necropolis1", Black Citadel "necropolis2".

The name of custom units is "custom_" + rawId, e.g. "custom_h000".

Well, seems to work this way.