Infernal Collapse v1.4

[Moderator]

Infernal Collapse v1.2 | Reviewed by BPower | 02.07.2015 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] Ultimately a meteor type spell. The effect models are very well chosen and fit to the spell desciption. The spell itself is very configurable and the fun to cast. Good job! Code[/COLOR]] The code is MUI, leakless and working. The documentation is very good. For 3D collision you have to take the orbs terrainZ and the hit unit terrainZ into account. Ofc also their fly height. Objects[/COLOR]] Object editor data is good. Effects[/COLOR]] The effect models are well chosen and fit to the spell description. Rating[/COLOR]] CONCEPT CODE OBJECTS EFFECTS RATING STATUS 4/5 4/5 5/5 4.5/5 4/5 APPROVED

 

[BPower]

Thread set to open.

Towards your previous question:
The map can be opened, I didn't have recieve fatal error.

You deindex the main part of the spell not in dependency of your orbs,
but there is backwards reference i.e udg_ICol__Caster[udg_ICol__Orb__Source[i]]
As conclusion your data may be incorrect ( wrong caster unit ).
Also you never null the caster in case only one instance is allocated.

This jumped now into my eye and might also be wrong in your other submission.
I have to double check that code again.
Edit: Yes same problem, I was too fast approving your spell. Set back to Need Fix until further updates.

I recommend to use spell effect event over call TriggerRegisterAnyUnitEventBJ(gg_trg_Infernal_Collapse, EVENT_PLAYER_UNIT_SPELL_CAST) as it fires after mana is used.

It's a welcome bonus that hastables return 0, if nothing is stored a key.
However I would like to recommend to you the usage of HaveSavedInteger
as 0 is also a value which you can save on a child key.

You skip array index 0 and start off at 1. Not a big deal.

 

[Kazeon]

Thread set to open.

Towards your previous question:
The map can be opened, I didn't have recieve fatal error.

You deindex the main part of the spell not in dependency of your orbs,
but there is backwards reference i.e udg_ICol__Caster[udg_ICol__Orb__Source[i]]
As conclusion your data may be incorrect ( wrong caster unit ).
Also you never null the caster in case only one instance is allocated.

This jumped now into my eye and might also be wrong in your other submission.
I have to double check that code again.
Edit: Yes same problem, I was too fast approving your spell. Set back to Need Fix until further updates.

I recommend to use spell effect event over call TriggerRegisterAnyUnitEventBJ(gg_trg_Infernal_Collapse, EVENT_PLAYER_UNIT_SPELL_CAST) as it fires after mana is used.

It's a welcome bonus that hastables return 0, if nothing is stored a key.
However I would like to recommend to you the usage of HaveSavedInteger
as 0 is also a value which you can save on a child key.

You skip array index 0 and start off at 1. Not a big deal.

Nice catch. I didn't realize even after making this one. I gonna fix it soon.


EDIT:

I recommend to use spell effect event over call TriggerRegisterAnyUnitEventBJ(gg_trg_Infernal_Collapse, EVENT_PLAYER_UNIT_SPELL_CAST) as it fires after mana is used.

What's their difference? Except if by saying spell effect event you want me to use vJass library, then I will say absolute no.

EDIT 2:
Ah wait a sec, it's my mistake to use spell cast event. I didn't notice it. It's just in this spell right? Gonna check the other one.

Woop, it has the same mistake as well.

 

[BPower]

They fire at different stages of spell casting. Iirc spell effect event fire after animation and mana manipulation. ( Not sure about this )

Yes both share the same mistake. That's why both are set back to Need Fix.

 

[FaLLeN]

Absolute genius combing effects to create a cool effect.. great but not all tiles are black

so need functionality too! any ways g8

 

[Kazeon]

Update: Everything's fixed.

 

[SayazEmil]

How do i configure the spell? I copied as you said but nothing happens when i cast it.

 

[Kazeon]

How do i configure the spell? I copied as you said but nothing happens when i cast it.

Have you configured the spell correctly (this is a common mistake)? Like setting the spell id and dummy id? You can find those at this part:

    // ********************************************************
    // *    
    // *                   Configuration
    // *    
    // *    1. Dummy unit's raw code at object editor
            constant function ICol__DummyID takes nothing returns integer
                return 'h000'
            endfunction
    // *    
    // *    2. Main ability's raw code at object editor
            constant function ICol__SpellID takes nothing returns integer
                return 'A000'
            endfunction

By id it means "raw code". You can find those in object editor by pressing CTRL+D.

 

[BPower]

Your idea of collision3D is only valid when source and target are standing on the same terrain level.
For uneven terrain it can be incorrect or fail.

Code looks good.

 

[Kazeon]

Update:
- Fixed nulling issue
- Fixed 3D collision issue
- Updated hashtable usage

I will update the other spell as well sometimes later.

 

[kakuzu]

Looks awesome !

 

[BPower]

I changed my review according to your changes. The 3D cloosion only works if you
consider both unit and orb terrainZ. Fly height is really not easy to manage in wc3.

 

[SayazEmil]

Hey Quilnez, happend after your help is: i tried to add everything to a clean new map. it worked. But changing the jazz code to the raw data dependent on my map didn't work.

 

[Kazeon]

I changed my review according to your changes. The 3D cloosion only works if you
consider both unit and orb terrainZ. Fly height is really not easy to manage in wc3.

I already did it:

set z = udg_ICol__Orb__Z[i]-(ICol__getZ(x, y)+GetUnitFlyHeight(u))

But there is still bug with explode effects height. Will fix it asap.

Hey Quilnez, happend after your help is: i tried to add everything to a clean new map. it worked. But changing the jazz code to the raw data dependent on my map didn't work.

Have you imported the dummy.mdx and other effect files and set them correctly both in object editor and trigger editor? Or maybe you can upload your map?

 

[SayazEmil]

Hello again Quilnez i deleted the spell in my map and readded everything and now it works (also visiual) just a final last qustion, how i can or where (in which row) i can/could change number of the orbs or the their damage? Thanks for everything and this really cool.. no its hot spell!

 

[Kazeon]

Hello again Quilnez i deleted the spell in my map and readded everything and now it works (also visiual) just a final last qustion, how i can or where (in which row) i can/could change number of the orbs or the their damage? Thanks for everything and this really cool.. no its hot spell!

In the configuration part, just read the documentation (texts above every function).

I'm glad you like it.

 

[Ofel]

Cool and neat...

5/5

 

[kruzerg]

good spell sir but i have prob the moment i add this spell to my map
your spell is worked, but one of my spell not worked anymore after i using your spell
this is my bugged spell:

• carrion splash
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Carrion Splash Active
  • Actions
    • Set Position_SpellsFire[2] = (Position of (Triggering unit))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
      • Then - Actions
        • For each (Integer A) from 1 to 20, do (Actions)
          • Loop - Actions
            • Unit - Create 1 ILLIDAN CARRION SWARM for (Owner of (Triggering unit)) at Position_SpellsFire[2] facing ((Real((Integer A))) x 18.00) degrees
            • Set Loc_SpellsFire = (Position of (Last created unit))
            • Set Position_SpellsFire[4] = (Loc_SpellsFire offset by 0.00 towards ((Real((Integer A))) x 18.00) degrees)
            • Unit - Order (Last created unit) to Undead Dreadlord - Carrion Swarm Position_SpellsFire[4]
            • Custom script: call RemoveLocation (udg_Position_SpellsFire[4])
      • Else - Actions
    • Custom script: call RemoveLocation (udg_Position_SpellsFire[2])
    • Custom script: call RemoveLocation (udg_Loc_SpellsFire)
    • Custom script: call RemoveLocation (udg_Position_SpellsFire[4])

my spell base ability is warstomp , then create dummy around caster and shoot carrion swarm, your spell base id is carrion swarm
i use my spell on hero A, and use infernal collapse on hero B
but somehow my spell didnt worked anymore (as if the trigger not running)

but after i change channel order id infernal collapse from carrion swarm into shockwave, my spell is worked again

why is that? and i just worried there's possibility your spell making my specific basic spell not worked anymore (depend on infernal collapse order id), any clue?

 

[Kazeon]

No idea. Probably caused by order id collision. But good thing it works for you eventually. And thanks for using. Good luck with the project.

Just a hint, there is still a bug regarding to cliff levels which I'm still too lazy to fix. But as long as you don't have multiple cliff levels in your map, there's nothing to worry about.

 

[Kazeon]

Update. Fixed orb z bugs on different cliff levels, hopefully.